[Pkg-voip-commits] [bctoolbox] 25/60: Respect bctoolbox naming conventions.

Bernhard Schmidt berni at moszumanska.debian.org
Sun Oct 15 22:42:24 UTC 2017


This is an automated email from the git hooks/post-receive script.

berni pushed a commit to branch debian/sid
in repository bctoolbox.

commit cb6314384fd108ce206e1467e9c253bc8cddd161
Author: Ghislain MARY <ghislain.mary at belledonne-communications.com>
Date:   Tue Apr 11 15:29:26 2017 +0200

    Respect bctoolbox naming conventions.
---
 include/bctoolbox/port.h |  45 +++++----
 src/utils/port.c         | 240 ++++++++++++++++++-----------------------------
 tester/port.c            |  72 +++++++-------
 3 files changed, 149 insertions(+), 208 deletions(-)

diff --git a/include/bctoolbox/port.h b/include/bctoolbox/port.h
index 5a150b4..43bf9bc 100644
--- a/include/bctoolbox/port.h
+++ b/include/bctoolbox/port.h
@@ -550,73 +550,72 @@ BCTBX_PUBLIC bool_t bctbx_is_multicast_addr(const struct sockaddr *addr);
  * @brief	convert an hexa char [0-9a-fA-F] into the corresponding unsigned integer value
  * Any invalid char will be converted to zero without any warning
  *
- * @param[in]	inputChar	a char which shall be in range [0-9a-fA-F]
+ * @param[in]	input_char	a char which shall be in range [0-9a-fA-F]
  *
  * @return		the unsigned integer value in range [0-15]
  */
-BCTBX_PUBLIC uint8_t bctbx_charToByte(const uint8_t inputChar);
+BCTBX_PUBLIC uint8_t bctbx_char_to_byte(uint8_t input_char);
 
 /**
  * @brief	convert a byte which value is in range [0-15] into an hexa char [0-9a-fA-F]
  *
- * @param[in]	inputByte	an integer which shall be in range [0-15]
- *
+ * @param[in]	input_byte	an integer which shall be in range [0-15]
  * @return		the hexa char [0-9a-f] corresponding to the input
  */
-BCTBX_PUBLIC uint8_t bctbx_byteToChar(const uint8_t inputByte);
+BCTBX_PUBLIC uint8_t bctbx_byte_to_char(uint8_t input_byte);
 
 
 /**
  * @brief Convert an hexadecimal string into the corresponding byte buffer
  *
- * @param[out]	outputBytes			The output bytes buffer, must have a length of half the input string buffer
- * @param[in]	inputString			The input string buffer, must be hexadecimal(it is not checked by function, any non hexa char is converted to 0)
- * @param[in]	inputStringLength	The lenght in chars of the string buffer, output is half this length
+ * @param[out]	output_bytes			The output bytes buffer, must have a length of half the input string buffer
+ * @param[in]	input_string			The input string buffer, must be hexadecimal(it is not checked by function, any non hexa char is converted to 0)
+ * @param[in]	input_string_length	The lenght in chars of the string buffer, output is half this length
  */
-BCTBX_PUBLIC void bctbx_strToUint8(uint8_t *outputBytes, const uint8_t *inputString, const uint16_t inputStringLength);
+BCTBX_PUBLIC void bctbx_str_to_uint8(uint8_t *output_bytes, const uint8_t *input_string, size_t input_string_length);
 
 /**
  * @brief Convert a byte buffer into the corresponding hexadecimal string
  *
- * @param[out]	outputString		The output string buffer, must have a length of twice the input bytes buffer
- * @param[in]	inputBytes			The input bytes buffer
- * @param[in]	inputBytesLength	The lenght in bytes buffer, output is twice this length
+ * @param[out]	output_string		The output string buffer, must have a length of twice the input bytes buffer
+ * @param[in]	input_bytes			The input bytes buffer
+ * @param[in]	input_bytes_length	The lenght in bytes buffer, output is twice this length
  */
-BCTBX_PUBLIC void bctbx_int8ToStr(uint8_t *outputString, const uint8_t *inputBytes, const uint16_t inputBytesLength);
+BCTBX_PUBLIC void bctbx_int8_to_str(uint8_t *output_string, const uint8_t *input_bytes, size_t input_bytes_length);
 
 /**
  * @brief Convert an unsigned 32 bits integer into the corresponding hexadecimal string(including null termination character)
  *
- * @param[out]	outputString		The output string buffer, must have a length of at least 9 bytes(8 nibbles and the '\0')
- * @param[in]	inputUint32		The input unsigned int
+ * @param[out]	output_string		The output string buffer, must have a length of at least 9 bytes(8 nibbles and the '\0')
+ * @param[in]	input_uint32		The input unsigned int
  */
-BCTBX_PUBLIC void bctbx_uint32ToStr(uint8_t outputString[9], const uint32_t inputUint32);
+BCTBX_PUBLIC void bctbx_uint32_to_str(uint8_t output_string[9], uint32_t input_uint32);
 
 /**
  * @brief Convert an hexadecimal string of 8 char length into the corresponding 32 bits unsigned integer
  *
- * @param[in]	inputString		The input string buffer, must be hexadecimal and at least 8 char long
+ * @param[in]	input_string		The input string buffer, must be hexadecimal and at least 8 char long
  *
  * Note : there is no check on the length or validity as an hexa string on the input, incorrect byte is silently mapped to 0
  */
-BCTBX_PUBLIC uint32_t bctbx_strToUint32(const uint8_t inputString[9]);
+BCTBX_PUBLIC uint32_t bctbx_str_to_uint32(const uint8_t input_string[9]);
 
 /**
  * @brief Convert an unsigned 64 bits integer into the corresponding hexadecimal string(including null termination character)
  *
- * @param[out]	outputString		The output string buffer, must have a length of at least 17 bytes(16 nibbles and the '\0')
- * @param[in]	inputUint64		The input unsigned int
+ * @param[out]	output_string		The output string buffer, must have a length of at least 17 bytes(16 nibbles and the '\0')
+ * @param[in]	input_uint64		The input unsigned int
  */
-BCTBX_PUBLIC void bctbx_uint64ToStr(uint8_t outputString[17], const uint64_t inputUint64);
+BCTBX_PUBLIC void bctbx_uint64_to_str(uint8_t output_string[17], uint64_t input_uint64);
 
 /**
  * @brief Convert an hexadecimal string of 8 char length into the corresponding 64 bits unsigned integer
  *
- * @param[in]	inputString		The input string buffer, must be hexadecimal and at leat 16 char long
+ * @param[in]	input_string		The input string buffer, must be hexadecimal and at leat 16 char long
  *
  * Note : there is no check on the length or validity as an hexa string on the input, incorrect byte is silently mapped to 0
  */
-BCTBX_PUBLIC uint64_t bctbx_strToUint64(const uint8_t inputString[17]);
+BCTBX_PUBLIC uint64_t bctbx_str_to_uint64(const uint8_t input_string[17]);
 
 #ifdef __cplusplus
 }
diff --git a/src/utils/port.c b/src/utils/port.c
index 2cfb661..0abe9d3 100644
--- a/src/utils/port.c
+++ b/src/utils/port.c
@@ -1567,30 +1567,20 @@ void bctbx_freeaddrinfo(struct addrinfo *res){
 }
 
 
-/* Useful byte buffer to/from hexa string manipulation */
-
-/**
- * @brief	convert an hexa char [0-9a-fA-F] into the corresponding unsigned integer value
- * Any invalid char will be converted to zero without any warning
- *
- * @param[in]	inputChar	a char which shall be in range [0-9a-fA-F]
- *
- * @return		the unsigned integer value in range [0-15]
- */
-uint8_t bctbx_charToByte(const uint8_t inputChar) {
+uint8_t bctbx_char_to_byte(uint8_t input_char) {
 	/* 0-9 */
-	if (inputChar>0x29 && inputChar<0x3A) {
-		return inputChar - 0x30;
+	if (input_char>0x29 && input_char<0x3A) {
+		return input_char - 0x30;
 	}
 
 	/* a-f */
-	if (inputChar>0x60 && inputChar<0x67) {
-		return inputChar - 0x57; /* 0x57 = 0x61(a) + 0x0A*/
+	if (input_char>0x60 && input_char<0x67) {
+		return input_char - 0x57; /* 0x57 = 0x61(a) + 0x0A*/
 	}
 
 	/* A-F */
-	if (inputChar>0x40 && inputChar<0x47) {
-		return inputChar - 0x37; /* 0x37 = 0x41(a) + 0x0A*/
+	if (input_char>0x40 && input_char<0x47) {
+		return input_char - 0x37; /* 0x37 = 0x41(a) + 0x0A*/
 	}
 
 	/* shall never arrive here, string is not Hex*/
@@ -1598,139 +1588,91 @@ uint8_t bctbx_charToByte(const uint8_t inputChar) {
 
 }
 
-/**
- * @brief	convert a byte which value is in range [0-15] into an hexa char [0-9a-fA-F]
- *
- * @param[in]	inputByte	an integer which shall be in range [0-15]
- *
- * @return		the hexa char [0-9a-f] corresponding to the input
- */
-uint8_t bctbx_byteToChar(const uint8_t inputByte) {
-	uint8_t inputByteCrop = inputByte&0x0F; /* restrict the input value to range [0-15] */
+uint8_t bctbx_byte_to_char(uint8_t input_byte) {
+	uint8_t input_byte_crop = input_byte&0x0F; /* restrict the input value to range [0-15] */
 	/* 0-9 */
-	if(inputByteCrop<0x0A) {
-		return inputByteCrop+0x30;
+	if(input_byte_crop<0x0A) {
+		return input_byte_crop+0x30;
 	}
 	/* a-f */
-	return inputByteCrop + 0x57;
-}
-
-
-/**
- * @brief Convert an hexadecimal string into the corresponding byte buffer
- *
- * @param[out]	outputBytes			The output bytes buffer, must have a length of half the input string buffer
- * @param[in]	inputString			The input string buffer, must be hexadecimal(it is not checked by function, any non hexa char is converted to 0)
- * @param[in]	inputStringLength	The lenght in chars of the string buffer, output is half this length
- */
-void bctbx_strToUint8(uint8_t *outputBytes, const uint8_t *inputString, const uint16_t inputStringLength) {
-	int i;
-	for (i=0; i<inputStringLength/2; i++) {
-		outputBytes[i] = (bctbx_charToByte(inputString[2*i]))<<4 | bctbx_charToByte(inputString[2*i+1]);
-	}
-}
-
-/**
- * @brief Convert a byte buffer into the corresponding hexadecimal string
- *
- * @param[out]	outputString		The output string buffer, must have a length of twice the input bytes buffer
- * @param[in]	inputBytes			The input bytes buffer
- * @param[in]	inputBytesLength	The lenght in bytes buffer, output is twice this length
- */
-void bctbx_int8ToStr(uint8_t *outputString, const uint8_t *inputBytes, const uint16_t inputBytesLength) {
-	int i;
-	for (i=0; i<inputBytesLength; i++) {
-		outputString[2*i] = bctbx_byteToChar((inputBytes[i]>>4)&0x0F);
-		outputString[2*i+1] = bctbx_byteToChar(inputBytes[i]&0x0F);
-	}
-}
-
-/**
- * @brief Convert an unsigned 32 bits integer into the corresponding hexadecimal string(including null termination character)
- *
- * @param[out]	outputString		The output string buffer, must have a length of at least 9 bytes(8 nibbles and the '\0')
- * @param[in]	inputUint32		The input unsigned int
- */
-void bctbx_uint32ToStr(uint8_t outputString[9], const uint32_t inputUint32) {
-
-	outputString[0] = bctbx_byteToChar((uint8_t)((inputUint32>>28)&0x0F));
-	outputString[1] = bctbx_byteToChar((uint8_t)((inputUint32>>24)&0x0F));
-	outputString[2] = bctbx_byteToChar((uint8_t)((inputUint32>>20)&0x0F));
-	outputString[3] = bctbx_byteToChar((uint8_t)((inputUint32>>16)&0x0F));
-	outputString[4] = bctbx_byteToChar((uint8_t)((inputUint32>>12)&0x0F));
-	outputString[5] = bctbx_byteToChar((uint8_t)((inputUint32>>8)&0x0F));
-	outputString[6] = bctbx_byteToChar((uint8_t)((inputUint32>>4)&0x0F));
-	outputString[7] = bctbx_byteToChar((uint8_t)((inputUint32)&0x0F));
-	outputString[8] = '\0';
-}
-
-/**
- * @brief Convert an hexadecimal string of 8 char length into the corresponding 32 bits unsigned integer
- *
- * @param[in]	inputString			The input string buffer, must be hexadecimal(it is not checked by function, any non hexa char is converted to 0)
- *
- * Note : there is no check on the length or validity as an hexa string on the input, incorrect byte is silently mapped to 0
- */
-uint32_t bctbx_strToUint32(const uint8_t *inputString) {
-	return  (((uint32_t)bctbx_charToByte(inputString[0]))<<28)
-		| (((uint32_t)bctbx_charToByte(inputString[1]))<<24)
-		| (((uint32_t)bctbx_charToByte(inputString[2]))<<20)
-		| (((uint32_t)bctbx_charToByte(inputString[3]))<<16)
-		| (((uint32_t)bctbx_charToByte(inputString[4]))<<12)
-		| (((uint32_t)bctbx_charToByte(inputString[5]))<<8)
-		| (((uint32_t)bctbx_charToByte(inputString[6]))<<4)
-		| (((uint32_t)bctbx_charToByte(inputString[7])));
-}
-
-/**
- * @brief Convert an unsigned 64 bits integer into the corresponding hexadecimal string(including null termination character)
- *
- * @param[out]	outputString		The output string buffer, must have a length of at least 17 bytes(16 nibbles and the '\0')
- * @param[in]	inputUint64		The input unsigned int
- */
-void bctbx_uint64ToStr(uint8_t outputString[17], const uint64_t inputUint64) {
-
-	outputString[0] = bctbx_byteToChar((uint8_t)((inputUint64>>60)&0x0F));
-	outputString[1] = bctbx_byteToChar((uint8_t)((inputUint64>>56)&0x0F));
-	outputString[2] = bctbx_byteToChar((uint8_t)((inputUint64>>52)&0x0F));
-	outputString[3] = bctbx_byteToChar((uint8_t)((inputUint64>>48)&0x0F));
-	outputString[4] = bctbx_byteToChar((uint8_t)((inputUint64>>44)&0x0F));
-	outputString[5] = bctbx_byteToChar((uint8_t)((inputUint64>>40)&0x0F));
-	outputString[6] = bctbx_byteToChar((uint8_t)((inputUint64>>36)&0x0F));
-	outputString[7] = bctbx_byteToChar((uint8_t)((inputUint64>>32)&0x0F));
-	outputString[8] = bctbx_byteToChar((uint8_t)((inputUint64>>28)&0x0F));
-	outputString[9] = bctbx_byteToChar((uint8_t)((inputUint64>>24)&0x0F));
-	outputString[10] = bctbx_byteToChar((uint8_t)((inputUint64>>20)&0x0F));
-	outputString[11] = bctbx_byteToChar((uint8_t)((inputUint64>>16)&0x0F));
-	outputString[12] = bctbx_byteToChar((uint8_t)((inputUint64>>12)&0x0F));
-	outputString[13] = bctbx_byteToChar((uint8_t)((inputUint64>>8)&0x0F));
-	outputString[14] = bctbx_byteToChar((uint8_t)((inputUint64>>4)&0x0F));
-	outputString[15] = bctbx_byteToChar((uint8_t)((inputUint64)&0x0F));
-	outputString[16] = '\0';
-}
-
-/**
- * @brief Convert an hexadecimal string of 8 char length into the corresponding 64 bits unsigned integer
- *
- * @param[in]	inputString		The input string buffer, must be hexadecimal and at leat 16 char long
- *
- * Note : there is no check on the length or validity as an hexa string on the input, incorrect byte is silently mapped to 0
- */
-uint64_t bctbx_strToUint64(const uint8_t inputString[17]) {
-	return  (((uint64_t)bctbx_charToByte(inputString[0]))<<60)
-		| (((uint64_t)bctbx_charToByte(inputString[1]))<<56)
-		| (((uint64_t)bctbx_charToByte(inputString[2]))<<52)
-		| (((uint64_t)bctbx_charToByte(inputString[3]))<<48)
-		| (((uint64_t)bctbx_charToByte(inputString[4]))<<44)
-		| (((uint64_t)bctbx_charToByte(inputString[5]))<<40)
-		| (((uint64_t)bctbx_charToByte(inputString[6]))<<36)
-		| (((uint64_t)bctbx_charToByte(inputString[7]))<<32)
-		| (((uint64_t)bctbx_charToByte(inputString[8]))<<28)
-		| (((uint64_t)bctbx_charToByte(inputString[9]))<<24)
-		| (((uint64_t)bctbx_charToByte(inputString[10]))<<20)
-		| (((uint64_t)bctbx_charToByte(inputString[11]))<<16)
-		| (((uint64_t)bctbx_charToByte(inputString[12]))<<12)
-		| (((uint64_t)bctbx_charToByte(inputString[13]))<<8)
-		| (((uint64_t)bctbx_charToByte(inputString[14]))<<4)
-		| (((uint64_t)bctbx_charToByte(inputString[15])));
+	return input_byte_crop + 0x57;
+}
+
+void bctbx_str_to_uint8(uint8_t *output_bytes, const uint8_t *input_string, size_t input_string_length) {
+	size_t i;
+	for (i=0; i<input_string_length/2; i++) {
+		output_bytes[i] = (bctbx_char_to_byte(input_string[2*i]))<<4 | bctbx_char_to_byte(input_string[2*i+1]);
+	}
+}
+
+void bctbx_int8_to_str(uint8_t *output_string, const uint8_t *input_bytes, size_t input_bytes_length) {
+	size_t i;
+	for (i=0; i<input_bytes_length; i++) {
+		output_string[2*i] = bctbx_byte_to_char((input_bytes[i]>>4)&0x0F);
+		output_string[2*i+1] = bctbx_byte_to_char(input_bytes[i]&0x0F);
+	}
+}
+
+void bctbx_uint32_to_str(uint8_t output_string[9], uint32_t input_uint32) {
+
+	output_string[0] = bctbx_byte_to_char((uint8_t)((input_uint32>>28)&0x0F));
+	output_string[1] = bctbx_byte_to_char((uint8_t)((input_uint32>>24)&0x0F));
+	output_string[2] = bctbx_byte_to_char((uint8_t)((input_uint32>>20)&0x0F));
+	output_string[3] = bctbx_byte_to_char((uint8_t)((input_uint32>>16)&0x0F));
+	output_string[4] = bctbx_byte_to_char((uint8_t)((input_uint32>>12)&0x0F));
+	output_string[5] = bctbx_byte_to_char((uint8_t)((input_uint32>>8)&0x0F));
+	output_string[6] = bctbx_byte_to_char((uint8_t)((input_uint32>>4)&0x0F));
+	output_string[7] = bctbx_byte_to_char((uint8_t)((input_uint32)&0x0F));
+	output_string[8] = '\0';
+}
+
+uint32_t bctbx_str_to_uint32(const uint8_t *input_string) {
+	return  (((uint32_t)bctbx_char_to_byte(input_string[0]))<<28)
+		| (((uint32_t)bctbx_char_to_byte(input_string[1]))<<24)
+		| (((uint32_t)bctbx_char_to_byte(input_string[2]))<<20)
+		| (((uint32_t)bctbx_char_to_byte(input_string[3]))<<16)
+		| (((uint32_t)bctbx_char_to_byte(input_string[4]))<<12)
+		| (((uint32_t)bctbx_char_to_byte(input_string[5]))<<8)
+		| (((uint32_t)bctbx_char_to_byte(input_string[6]))<<4)
+		| (((uint32_t)bctbx_char_to_byte(input_string[7])));
+}
+
+void bctbx_uint64_to_str(uint8_t output_string[17], uint64_t input_uint64) {
+
+	output_string[0] = bctbx_byte_to_char((uint8_t)((input_uint64>>60)&0x0F));
+	output_string[1] = bctbx_byte_to_char((uint8_t)((input_uint64>>56)&0x0F));
+	output_string[2] = bctbx_byte_to_char((uint8_t)((input_uint64>>52)&0x0F));
+	output_string[3] = bctbx_byte_to_char((uint8_t)((input_uint64>>48)&0x0F));
+	output_string[4] = bctbx_byte_to_char((uint8_t)((input_uint64>>44)&0x0F));
+	output_string[5] = bctbx_byte_to_char((uint8_t)((input_uint64>>40)&0x0F));
+	output_string[6] = bctbx_byte_to_char((uint8_t)((input_uint64>>36)&0x0F));
+	output_string[7] = bctbx_byte_to_char((uint8_t)((input_uint64>>32)&0x0F));
+	output_string[8] = bctbx_byte_to_char((uint8_t)((input_uint64>>28)&0x0F));
+	output_string[9] = bctbx_byte_to_char((uint8_t)((input_uint64>>24)&0x0F));
+	output_string[10] = bctbx_byte_to_char((uint8_t)((input_uint64>>20)&0x0F));
+	output_string[11] = bctbx_byte_to_char((uint8_t)((input_uint64>>16)&0x0F));
+	output_string[12] = bctbx_byte_to_char((uint8_t)((input_uint64>>12)&0x0F));
+	output_string[13] = bctbx_byte_to_char((uint8_t)((input_uint64>>8)&0x0F));
+	output_string[14] = bctbx_byte_to_char((uint8_t)((input_uint64>>4)&0x0F));
+	output_string[15] = bctbx_byte_to_char((uint8_t)((input_uint64)&0x0F));
+	output_string[16] = '\0';
+}
+
+uint64_t bctbx_str_to_uint64(const uint8_t input_string[17]) {
+	return  (((uint64_t)bctbx_char_to_byte(input_string[0]))<<60)
+		| (((uint64_t)bctbx_char_to_byte(input_string[1]))<<56)
+		| (((uint64_t)bctbx_char_to_byte(input_string[2]))<<52)
+		| (((uint64_t)bctbx_char_to_byte(input_string[3]))<<48)
+		| (((uint64_t)bctbx_char_to_byte(input_string[4]))<<44)
+		| (((uint64_t)bctbx_char_to_byte(input_string[5]))<<40)
+		| (((uint64_t)bctbx_char_to_byte(input_string[6]))<<36)
+		| (((uint64_t)bctbx_char_to_byte(input_string[7]))<<32)
+		| (((uint64_t)bctbx_char_to_byte(input_string[8]))<<28)
+		| (((uint64_t)bctbx_char_to_byte(input_string[9]))<<24)
+		| (((uint64_t)bctbx_char_to_byte(input_string[10]))<<20)
+		| (((uint64_t)bctbx_char_to_byte(input_string[11]))<<16)
+		| (((uint64_t)bctbx_char_to_byte(input_string[12]))<<12)
+		| (((uint64_t)bctbx_char_to_byte(input_string[13]))<<8)
+		| (((uint64_t)bctbx_char_to_byte(input_string[14]))<<4)
+		| (((uint64_t)bctbx_char_to_byte(input_string[15])));
 }
diff --git a/tester/port.c b/tester/port.c
index e99bb6b..1d673fe 100644
--- a/tester/port.c
+++ b/tester/port.c
@@ -22,7 +22,7 @@
 #include "bctoolbox_tester.h"
 #include "bctoolbox/port.h"
 
-static void bytesToFromHexaStrings(void) {
+static void bytes_to_from_hexa_strings(void) {
 	const uint8_t a55aBytes[2] = {0xa5, 0x5a};
 	const uint8_t a55aString[5] = "a55a";
 	const uint8_t upBytes[8] = {0x01, 0x23, 0x45, 0x67, 0x89, 0xab, 0xcd, 0xef};
@@ -32,58 +32,58 @@ static void bytesToFromHexaStrings(void) {
 	uint8_t outputBytes[16];
 	uint8_t outputString[16];
 
-	BC_ASSERT_EQUAL(bctbx_charToByte("1"[0]), 1, uint8_t, "%d");
-	BC_ASSERT_EQUAL(bctbx_charToByte("5"[0]), 5, uint8_t, "%d");
-	BC_ASSERT_EQUAL(bctbx_charToByte("a"[0]), 10, uint8_t, "%d");
-	BC_ASSERT_EQUAL(bctbx_charToByte("e"[0]), 14, uint8_t, "%d");
-	BC_ASSERT_EQUAL(bctbx_charToByte("B"[0]), 11, uint8_t, "%d");
-	BC_ASSERT_EQUAL(bctbx_charToByte("F"[0]), 15, uint8_t, "%d");
-
-	BC_ASSERT_EQUAL(bctbx_byteToChar(0), "0"[0], char, "%c");
-	BC_ASSERT_EQUAL(bctbx_byteToChar(2), "2"[0], char, "%c");
-	BC_ASSERT_EQUAL(bctbx_byteToChar(5), "5"[0], char, "%c");
-	BC_ASSERT_EQUAL(bctbx_byteToChar(0x0a), "a"[0], char, "%c");
-	BC_ASSERT_EQUAL(bctbx_byteToChar(0x0c), "c"[0], char, "%c");
-	BC_ASSERT_EQUAL(bctbx_byteToChar(0x0e), "e"[0], char, "%c");
-
-	bctbx_strToUint8(outputBytes, a55aString, 4);
+	BC_ASSERT_EQUAL(bctbx_char_to_byte("1"[0]), 1, uint8_t, "%d");
+	BC_ASSERT_EQUAL(bctbx_char_to_byte("5"[0]), 5, uint8_t, "%d");
+	BC_ASSERT_EQUAL(bctbx_char_to_byte("a"[0]), 10, uint8_t, "%d");
+	BC_ASSERT_EQUAL(bctbx_char_to_byte("e"[0]), 14, uint8_t, "%d");
+	BC_ASSERT_EQUAL(bctbx_char_to_byte("B"[0]), 11, uint8_t, "%d");
+	BC_ASSERT_EQUAL(bctbx_char_to_byte("F"[0]), 15, uint8_t, "%d");
+
+	BC_ASSERT_EQUAL(bctbx_byte_to_char(0), "0"[0], char, "%c");
+	BC_ASSERT_EQUAL(bctbx_byte_to_char(2), "2"[0], char, "%c");
+	BC_ASSERT_EQUAL(bctbx_byte_to_char(5), "5"[0], char, "%c");
+	BC_ASSERT_EQUAL(bctbx_byte_to_char(0x0a), "a"[0], char, "%c");
+	BC_ASSERT_EQUAL(bctbx_byte_to_char(0x0c), "c"[0], char, "%c");
+	BC_ASSERT_EQUAL(bctbx_byte_to_char(0x0e), "e"[0], char, "%c");
+
+	bctbx_str_to_uint8(outputBytes, a55aString, 4);
 	BC_ASSERT_NSTRING_EQUAL(outputBytes, a55aBytes, 2);
-	bctbx_strToUint8(outputBytes, upString, 16);
+	bctbx_str_to_uint8(outputBytes, upString, 16);
 	BC_ASSERT_NSTRING_EQUAL(outputBytes, upBytes, 8);
-	bctbx_strToUint8(outputBytes, downString, 16);
+	bctbx_str_to_uint8(outputBytes, downString, 16);
 	BC_ASSERT_NSTRING_EQUAL(outputBytes, downBytes, 8);
 
-	bctbx_int8ToStr(outputString, a55aBytes, 2);
+	bctbx_int8_to_str(outputString, a55aBytes, 2);
 	BC_ASSERT_NSTRING_EQUAL(outputString, a55aString, 4);
-	bctbx_int8ToStr(outputString, upBytes, 8);
+	bctbx_int8_to_str(outputString, upBytes, 8);
 	BC_ASSERT_NSTRING_EQUAL(outputString, upString, 16);
-	bctbx_int8ToStr(outputString, downBytes, 8);
+	bctbx_int8_to_str(outputString, downBytes, 8);
 	BC_ASSERT_NSTRING_EQUAL(outputString, downString, 16);
 
-	bctbx_uint32ToStr(outputString, 0x5aa5c376);
+	bctbx_uint32_to_str(outputString, 0x5aa5c376);
 	BC_ASSERT_NSTRING_EQUAL(outputString, "5aa5c376", 8);
-	bctbx_uint32ToStr(outputString, 0x01234567);
+	bctbx_uint32_to_str(outputString, 0x01234567);
 	BC_ASSERT_NSTRING_EQUAL(outputString, "01234567", 8);
-	bctbx_uint32ToStr(outputString, 0xfedcba98);
+	bctbx_uint32_to_str(outputString, 0xfedcba98);
 	BC_ASSERT_NSTRING_EQUAL(outputString, "fedcba98", 8);
 
-	BC_ASSERT_EQUAL(bctbx_strToUint32("5aa5c376"), 0x5aa5c376, uint32_t, "0x%08x");
-	BC_ASSERT_EQUAL(bctbx_strToUint32("01234567"), 0x01234567, uint32_t, "0x%08x");
-	BC_ASSERT_EQUAL(bctbx_strToUint32("fedcba98"), 0xfedcba98, uint32_t, "0x%08x");
+	BC_ASSERT_EQUAL(bctbx_str_to_uint32("5aa5c376"), 0x5aa5c376, uint32_t, "0x%08x");
+	BC_ASSERT_EQUAL(bctbx_str_to_uint32("01234567"), 0x01234567, uint32_t, "0x%08x");
+	BC_ASSERT_EQUAL(bctbx_str_to_uint32("fedcba98"), 0xfedcba98, uint32_t, "0x%08x");
 
-	bctbx_uint64ToStr(outputString, 0xfa5c37643cde8de0);
+	bctbx_uint64_to_str(outputString, 0xfa5c37643cde8de0);
 	BC_ASSERT_NSTRING_EQUAL(outputString, "fa5c37643cde8de0", 16);
-	bctbx_uint64ToStr(outputString, 0x0123456789abcdef);
+	bctbx_uint64_to_str(outputString, 0x0123456789abcdef);
 	BC_ASSERT_NSTRING_EQUAL(outputString, "0123456789abcdef", 16);
-	bctbx_uint64ToStr(outputString, 0xfedcba9876543210);
+	bctbx_uint64_to_str(outputString, 0xfedcba9876543210);
 	BC_ASSERT_NSTRING_EQUAL(outputString, "fedcba9876543210", 16);
 
-	BC_ASSERT_EQUAL(bctbx_strToUint64("fa5c37643cde8de0"), 0xfa5c37643cde8de0, uint64_t, "0x%" PRIx64);
-	BC_ASSERT_EQUAL(bctbx_strToUint64("0123456789abcdef"), 0x0123456789abcdef, uint64_t, "0x%" PRIx64);
-	BC_ASSERT_EQUAL(bctbx_strToUint64("fedcba9876543210"), 0xfedcba9876543210, uint64_t, "0x%" PRIx64);
+	BC_ASSERT_EQUAL(bctbx_str_to_uint64("fa5c37643cde8de0"), 0xfa5c37643cde8de0, uint64_t, "0x%" PRIx64);
+	BC_ASSERT_EQUAL(bctbx_str_to_uint64("0123456789abcdef"), 0x0123456789abcdef, uint64_t, "0x%" PRIx64);
+	BC_ASSERT_EQUAL(bctbx_str_to_uint64("fedcba9876543210"), 0xfedcba9876543210, uint64_t, "0x%" PRIx64);
 }
 
-static void timeFunctions(void) {
+static void time_functions(void) {
 	bctoolboxTimeSpec testTs;
 	bctoolboxTimeSpec y2k,monday6Feb2017;
 	y2k.tv_sec = 946684800;
@@ -134,8 +134,8 @@ static void timeFunctions(void) {
 }
 
 static test_t utils_tests[] = {
-	TEST_NO_TAG("Bytes to/from Hexa strings", bytesToFromHexaStrings),
-	TEST_NO_TAG("Time", timeFunctions)
+	TEST_NO_TAG("Bytes to/from Hexa strings", bytes_to_from_hexa_strings),
+	TEST_NO_TAG("Time", time_functions)
 };
 
 test_suite_t utils_test_suite = {"Utils", NULL, NULL, NULL, NULL,

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-voip/bctoolbox.git



More information about the Pkg-voip-commits mailing list