[Pkg-voip-commits] [janus] 127/163: Don't ignore ICMP errors on RTP packets in the SIP plugin

[Jonas Smedegaard]

This is an automated email from the git hooks/post-receive script.

js pushed a commit to annotated tag debian/0.2.5-1
in repository janus.

commit 2162f46bbfffb9ffaf8d8af784f3b7965e608b03
Author: Lorenzo Miniero <lminiero at gmail.com>
Date:   Tue Oct 10 16:35:18 2017 +0200

    Don't ignore ICMP errors on RTP packets in the SIP plugin
---
 plugins/janus_sip.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/plugins/janus_sip.c b/plugins/janus_sip.c
index dbb2f43..36da1e0 100644
--- a/plugins/janus_sip.c
+++ b/plugins/janus_sip.c
@@ -3810,14 +3810,15 @@ static void *janus_sip_relay_thread(void *data) {
 							session->account.username, strerror(error));
 						close(session->media.audio_rtcp_fd);
 						session->media.audio_rtcp_fd = -1;
+						continue;
 					} else if(fds[i].fd == session->media.video_rtcp_fd) {
 						JANUS_LOG(LOG_WARN, "[SIP-%s] Got a '%s' on the video RTCP socket, closing it\n",
 							session->account.username, strerror(error));
 						close(session->media.video_rtcp_fd);
 						session->media.video_rtcp_fd = -1;
+						continue;
 					}
-					/* FIXME Should we do the same with the RTP sockets as well? We may risk overreacting, there... */
-					continue;
+					/* FIXME Should we be more tolerand of ICMP errors on RTP sockets as well? */
 				}
 				JANUS_LOG(LOG_ERR, "[SIP-%s] Error polling %d (socket #%d): %s...\n", session->account.username,
 					fds[i].fd, i, fds[i].revents & POLLERR ? "POLLERR" : "POLLHUP");

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-voip/janus.git