[Pkg-voip-commits] [janus] 135/163: Add documentation to notify_joining

[Jonas Smedegaard]

This is an automated email from the git hooks/post-receive script.

js pushed a commit to annotated tag debian/0.2.5-1
in repository janus.

commit 0e11b6be27195bd6834b74434e01d6a95c968b4f
Author: Steven Tang <sttang at blackberry.com>
Date:   Fri Oct 13 09:56:25 2017 -0400

    Add documentation to notify_joining
    
    Change-Id: Ic9d727ba4434c94dacfe516d46d8200b21906002
---
 conf/janus.plugin.videoroom.cfg.sample | 5 +++++
 plugins/janus_videoroom.c              | 6 +++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/conf/janus.plugin.videoroom.cfg.sample b/conf/janus.plugin.videoroom.cfg.sample
index 3295683..57678d1 100644
--- a/conf/janus.plugin.videoroom.cfg.sample
+++ b/conf/janus.plugin.videoroom.cfg.sample
@@ -23,6 +23,11 @@
 ;		be negotiated/used or not for new publishers, default=yes)
 ; record = true|false (whether this room should be recorded, default=false)
 ; rec_dir = <folder where recordings should be stored, when enabled>
+; notify_joining = true|false (optional, whether to notify all participants when a new
+;               participant joins the room. The Videoroom plugin by design only notifies
+;               new feeds (publishers), and enabling this may result extra notification
+;               traffic. This flag is particularly useful when enabled with require_pvtid
+;               for admin to manage listening only participants. default=false)
 
 [general]
 ;admin_key = supersecret		; If set, rooms can be created via API only
diff --git a/plugins/janus_videoroom.c b/plugins/janus_videoroom.c
index 7f72a5c..95a0003 100644
--- a/plugins/janus_videoroom.c
+++ b/plugins/janus_videoroom.c
@@ -78,7 +78,11 @@ playoutdelay_ext = yes|no (whether the playout-delay RTP extension must be
 	negotiated/used or not for new publishers, default=yes)
 record = true|false (whether this room should be recorded, default=false)
 rec_dir = <folder where recordings should be stored, when enabled>
-notify_joining = yes|no (whether to notify all participants when a new participant joins the room)
+notify_joining = true|false (optional, whether to notify all participants when a new
+            participant joins the room. The Videoroom plugin by design only notifies
+            new feeds (publishers), and enabling this may result extra notification
+            traffic. This flag is particularly useful when enabled with \c require_pvtid
+            for admin to manage listening only participants. default=false)
 \endverbatim
  *
  * Note that recording will work with all codecs except iSAC.

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-voip/janus.git