[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.16-1409-g5afdf4d
oliver at apple.com
oliver at apple.com
Thu Dec 3 13:20:09 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit b383c7ca883e8fe830f1d03a9c070e453d77bc22
Author: oliver at apple.com <oliver at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Oct 27 07:10:01 2009 +0000
Crash occurs after launching Newsfire 1.6 for the first time
https://bugs.webkit.org/show_bug.cgi?id=30807
Reviewed by Maciej Stachowiak.
Use a RetainPtr in ObjcBinding to ensure that we adequately
protect the autorelease pool from GC in GC'd applications.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index a0f9c22..e0310b6 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2009-10-26 Oliver Hunt <oliver at apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Crash occurs after launching Newsfire 1.6 for the first time
+ https://bugs.webkit.org/show_bug.cgi?id=30807
+
+ Use a RetainPtr in ObjcBinding to ensure that we adequately
+ protect the autorelease pool from GC in GC'd applications.
+
+ * bridge/objc/objc_instance.h:
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::ObjcInstance):
+ (ObjcInstance::virtualEnd):
+
2009-10-26 Laszlo Gombos <laszlo.1.gombos at nokia.com>
Unreviewed.
diff --git a/WebCore/bridge/objc/objc_instance.h b/WebCore/bridge/objc/objc_instance.h
index 64cd491..1d287c6 100644
--- a/WebCore/bridge/objc/objc_instance.h
+++ b/WebCore/bridge/objc/objc_instance.h
@@ -71,7 +71,7 @@ private:
RetainPtr<ObjectStructPtr> _instance;
mutable ObjcClass *_class;
- ObjectStructPtr _pool;
+ RetainPtr<ObjectStructPtr> _pool;
int _beginCount;
};
diff --git a/WebCore/bridge/objc/objc_instance.mm b/WebCore/bridge/objc/objc_instance.mm
index f7550e4..19b5a41 100644
--- a/WebCore/bridge/objc/objc_instance.mm
+++ b/WebCore/bridge/objc/objc_instance.mm
@@ -91,7 +91,6 @@ ObjcInstance::ObjcInstance(id instance, PassRefPtr<RootObject> rootObject)
: Instance(rootObject)
, _instance(instance)
, _class(0)
- , _pool(0)
, _beginCount(0)
{
}
@@ -135,7 +134,7 @@ void ObjcInstance::virtualEnd()
_beginCount--;
ASSERT(_beginCount >= 0);
if (!_beginCount) {
- [_pool drain];
+ [_pool.get() drain];
_pool = 0;
}
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list