[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.16-1409-g5afdf4d

Thu Dec 3 13:28:44 UTC 2009

The following commit has been merged in the webkit-1.1 branch:
commit 5334cbc0dfdf6e1829fe9aa841084c8c144f3b09
Author: dbates at webkit.org <dbates at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sun Nov 8 02:31:48 2009 +0000

    2009-11-07  Daniel Bates  <dbates at webkit.org>
    
            Reviewed by Darin Adler.
    
            https://bugs.webkit.org/show_bug.cgi?id=20780
    
            Fixes an issue where the onchange event handler is not fired when the
            input field is autocompleted.
    
            We cannot test this using DRT since DRT cannot emulate autocompletion.
            So, a manual-test is included.
    
            Tests: manual-tests/autocompletion-fire-onchange.html
    
            * manual-tests/autocompletion-fire-onchange.html: Added.
            * rendering/RenderTextControl.cpp:
            (WebCore::RenderTextControl::setInnerTextValue):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index f777ac4..05e4026 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,21 @@
+2009-11-07  Daniel Bates  <dbates at webkit.org>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=20780
+        
+        Fixes an issue where the onchange event handler is not fired when the 
+        input field is autocompleted.
+        
+        We cannot test this using DRT since DRT cannot emulate autocompletion.
+        So, a manual-test is included.
+
+        Tests: manual-tests/autocompletion-fire-onchange.html
+
+        * manual-tests/autocompletion-fire-onchange.html: Added.
+        * rendering/RenderTextControl.cpp:
+        (WebCore::RenderTextControl::setInnerTextValue):
+
 2009-11-07  Benjamin Otte  <otte at gnome.org>
 
         Reviewed by Holger Freyther.
diff --git a/WebCore/manual-tests/autocompletion-fire-onchange.html b/WebCore/manual-tests/autocompletion-fire-onchange.html
new file mode 100644
index 0000000..c6ba288
--- /dev/null
+++ b/WebCore/manual-tests/autocompletion-fire-onchange.html
@@ -0,0 +1,40 @@
+<html>
+<head>
+<script>
+// This test case is based on the test case http://data.ici-bas.fr/chromiumissue10879/.
+window.changed = false;
+function checkForChange()
+{
+    if (!location.search)
+        return true;
+        
+    if (!window.changed && document.getElementById("field").value != "")
+        log("FAIL");
+    else
+        log("PASS");
+    return false;
+}
+
+function log(msg)
+{
+    document.getElementById("log").appendChild(document.createTextNode(msg + "\n"));
+}
+</script>
+</head>
+<body>
+<p id="description">This test verifies that on autocompletion the 'onchange' event is fired.</p>
+<p>Steps to reproduce:</p>
+<ol>
+  <li>In the input field, type the word &quot;apple&quot; (without quotes). Then click the button Submit or hit the return/enter 
+  key on your keyboard</li>
+  <li>Once the page reloads, in the input field, type &quot;ap&quot; (without quotes) and let the browser autocomplete the word (or select 
+  &quot;apple&quot; from the autocompletion drop-down list contextual menu). Then click the button Submit or hit the return/enter 
+  key on your keyboard.</li>
+</ol>
+<form method="get" onsubmit="return checkForChange()">
+    <p><input type="text" name="field" id="field" value="" onchange="window.changed = true"/></p>
+    <p><input type="submit" value="Submit"/></p>
+</form>
+<pre id="log"></pre>
+</body>
+</html>
diff --git a/WebCore/rendering/RenderTextControl.cpp b/WebCore/rendering/RenderTextControl.cpp
index f430399..09caab9 100644
--- a/WebCore/rendering/RenderTextControl.cpp
+++ b/WebCore/rendering/RenderTextControl.cpp
@@ -195,7 +195,7 @@ void RenderTextControl::setInnerTextValue(const String& innerTextValue)
             ASSERT(!ec);
         }
 
-        m_edited = false;
+        // We set m_userEdited to false since this change was not explicty made by the user (say, via typing on the keyboard), see <rdar://problem/5359921>.
         m_userEdited = false;
     }
 

-- 
WebKit Debian packaging

