[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.16-1409-g5afdf4d
eric at webkit.org
eric at webkit.org
Thu Dec 3 13:30:26 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 218f03397ef641b8d92f27461b9696fcddac3fdf
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Nov 10 01:46:10 2009 +0000
2009-11-09 Kent Tamura <tkent at chromium.org>
Reviewed by Darin Adler.
Add a comment about null strings and hash functions.
https://bugs.webkit.org/show_bug.cgi?id=29118
* platform/text/StringHash.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index ddd020a..30e8fc6 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,12 @@
+2009-11-09 Kent Tamura <tkent at chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Add a comment about null strings and hash functions.
+ https://bugs.webkit.org/show_bug.cgi?id=29118
+
+ * platform/text/StringHash.h:
+
2009-11-09 Martin Robinson <martin.james.robinson at gmail.com>
Reviewed by Darin Adler.
diff --git a/WebCore/platform/text/StringHash.h b/WebCore/platform/text/StringHash.h
index 336dce3..584b677 100644
--- a/WebCore/platform/text/StringHash.h
+++ b/WebCore/platform/text/StringHash.h
@@ -29,6 +29,10 @@
namespace WebCore {
+ // The hash() functions on StringHash and CaseFoldingHash do not support
+ // null strings. get(), contains(), and add() on HashMap<String,..., StringHash>
+ // cause a null-pointer dereference when passed null strings.
+
// FIXME: We should really figure out a way to put the computeHash function that's
// currently a member function of StringImpl into this file so we can be a little
// closer to having all the nearly-identical hash functions in one place.
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list