[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.16-1409-g5afdf4d
dglazkov at chromium.org
dglazkov at chromium.org
Thu Dec 3 13:45:03 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 94b1d344d8d16e23be5715a4a81600733f78158b
Author: dglazkov at chromium.org <dglazkov at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Nov 26 00:57:22 2009 +0000
WebCore:
2009-11-25 Dimitri Glazkov <dglazkov at chromium.org>
Reviewed by David Levin.
[Chromium] Implement canSetValueAttribute in the API, the clean-up part.
https://bugs.webkit.org/show_bug.cgi?id=31894
* accessibility/chromium/AccessibilityObjectWrapper.h: Added RefCounted decl.
(WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Removed mis-refcountingness.
WebKit/chromium:
2009-11-25 Dimitri Glazkov <dglazkov at chromium.org>
Reviewed by David Levin.
[Chromium] Implement canSetValueAttribute in the API.
https://bugs.webkit.org/show_bug.cgi?id=31894
* public/WebAccessibilityObject.h: Added decl.
* src/WebAccessibilityCacheImpl.h: Cleaned up mis-include.
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::canSetValueAttribute): Added impl.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 84bad77..7d79ea6 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,13 @@
+2009-11-25 Dimitri Glazkov <dglazkov at chromium.org>
+
+ Reviewed by David Levin.
+
+ [Chromium] Implement canSetValueAttribute in the API, the clean-up part.
+ https://bugs.webkit.org/show_bug.cgi?id=31894
+
+ * accessibility/chromium/AccessibilityObjectWrapper.h: Added RefCounted decl.
+ (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Removed mis-refcountingness.
+
2009-11-25 Kenneth Russell <kbr at google.com>
Reviewed by Oliver Hunt.
diff --git a/WebCore/accessibility/chromium/AccessibilityObjectWrapper.h b/WebCore/accessibility/chromium/AccessibilityObjectWrapper.h
index d7238e1..85a65ed 100644
--- a/WebCore/accessibility/chromium/AccessibilityObjectWrapper.h
+++ b/WebCore/accessibility/chromium/AccessibilityObjectWrapper.h
@@ -27,6 +27,8 @@
#ifndef AccessibilityObjectWrapper_h
#define AccessibilityObjectWrapper_h
+#include <wtf/RefCounted.h>
+
namespace WebCore {
class AccessibilityObject;
@@ -41,8 +43,6 @@ namespace WebCore {
AccessibilityObjectWrapper(AccessibilityObject* obj)
: m_object(obj)
{
- // FIXME: Remove this once our immediate subclass no longer uses COM.
- *addressOfCount() = 0;
}
AccessibilityObjectWrapper() : m_object(0) { }
diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index afec236..bbe0137 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,12 +1,14 @@
-2009-11-25 Darin Fisher <darin at chromium.org>
+2009-11-25 Dimitri Glazkov <dglazkov at chromium.org>
- Reviewed by Adam Barth.
+ Reviewed by David Levin.
- [Chromium] Unable to repost form data by hitting reload
- https://bugs.webkit.org/show_bug.cgi?id=31882
+ [Chromium] Implement canSetValueAttribute in the API.
+ https://bugs.webkit.org/show_bug.cgi?id=31894
- * src/WebFrameImpl.cpp:
- (WebKit::WebFrameImpl::loadData):
+ * public/WebAccessibilityObject.h: Added decl.
+ * src/WebAccessibilityCacheImpl.h: Cleaned up mis-include.
+ * src/WebAccessibilityObject.cpp:
+ (WebKit::WebAccessibilityObject::canSetValueAttribute): Added impl.
2009-11-25 Dimitri Glazkov <dglazkov at chromium.org>
diff --git a/WebKit/chromium/public/WebAccessibilityObject.h b/WebKit/chromium/public/WebAccessibilityObject.h
index b6c5191..d32c548 100644
--- a/WebKit/chromium/public/WebAccessibilityObject.h
+++ b/WebKit/chromium/public/WebAccessibilityObject.h
@@ -67,6 +67,7 @@ public:
WebString accessibilityDescription() const;
WebString actionVerb() const;
bool canSetFocusAttribute() const;
+ bool canSetValueAttribute() const;
unsigned childCount() const;
diff --git a/WebKit/chromium/src/WebAccessibilityCacheImpl.h b/WebKit/chromium/src/WebAccessibilityCacheImpl.h
index 7a9bf8f..5148b74 100644
--- a/WebKit/chromium/src/WebAccessibilityCacheImpl.h
+++ b/WebKit/chromium/src/WebAccessibilityCacheImpl.h
@@ -31,10 +31,6 @@
#ifndef WebAccessibilityCacheImpl_h
#define WebAccessibilityCacheImpl_h
-// FIXME: Move wtf/RefCounted.h include to AccessibilityObjectWrapper.h
-// once this file is upstream.
-#include <wtf/RefCounted.h>
-
#include "AccessibilityObjectWrapper.h"
#include "WebAccessibilityCache.h"
#include <wtf/HashMap.h>
diff --git a/WebKit/chromium/src/WebAccessibilityObject.cpp b/WebKit/chromium/src/WebAccessibilityObject.cpp
index 49fed03..bdbd260 100644
--- a/WebKit/chromium/src/WebAccessibilityObject.cpp
+++ b/WebKit/chromium/src/WebAccessibilityObject.cpp
@@ -86,6 +86,15 @@ bool WebAccessibilityObject::canSetFocusAttribute() const
return m_private->canSetFocusAttribute();
}
+bool WebAccessibilityObject::canSetValueAttribute() const
+{
+ if (!m_private)
+ return false;
+
+ m_private->updateBackingStore();
+ return m_private->canSetValueAttribute();
+}
+
unsigned WebAccessibilityObject::childCount() const
{
if (!m_private)
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list