[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
pfeldman at chromium.org
pfeldman at chromium.org
Thu Oct 29 20:31:32 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 2173c510ffa2adbde0ea8d448117392c6cbe0db1
Author: pfeldman at chromium.org <pfeldman at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Sep 21 22:15:23 2009 +0000
2009-09-21 Pavel Feldman <pfeldman at chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Expose InspectorResource fields.
https://bugs.webkit.org/show_bug.cgi?id=29537
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::sourceString):
(WebCore::InspectorResource::resourceData):
* inspector/InspectorResource.h:
(WebCore::InspectorResource::requestHeaderFields):
(WebCore::InspectorResource::responseHeaderFields):
(WebCore::InspectorResource::responseStatusCode):
(WebCore::InspectorResource::requestMethod):
(WebCore::InspectorResource::requestFormData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 15c0194..b440f75 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -2,6 +2,24 @@
Reviewed by Timothy Hatcher.
+ Web Inspector: Expose InspectorResource fields.
+
+ https://bugs.webkit.org/show_bug.cgi?id=29537
+
+ * inspector/InspectorResource.cpp:
+ (WebCore::InspectorResource::sourceString):
+ (WebCore::InspectorResource::resourceData):
+ * inspector/InspectorResource.h:
+ (WebCore::InspectorResource::requestHeaderFields):
+ (WebCore::InspectorResource::responseHeaderFields):
+ (WebCore::InspectorResource::responseStatusCode):
+ (WebCore::InspectorResource::requestMethod):
+ (WebCore::InspectorResource::requestFormData):
+
+2009-09-21 Pavel Feldman <pfeldman at chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
Web Inspector: JS error drilling down childless node.
No need to dispatch double click twice - it is already handled
in TreeElement.treeElementDoubleClicked.
diff --git a/WebCore/inspector/InspectorResource.cpp b/WebCore/inspector/InspectorResource.cpp
index 54d9f92..484a0bd 100644
--- a/WebCore/inspector/InspectorResource.cpp
+++ b/WebCore/inspector/InspectorResource.cpp
@@ -264,32 +264,8 @@ String InspectorResource::sourceString() const
if (!m_xmlHttpResponseText.isNull())
return String(m_xmlHttpResponseText);
- RefPtr<SharedBuffer> buffer;
String textEncodingName;
-
- if (m_requestURL == m_loader->requestURL()) {
- buffer = m_loader->mainResourceData();
- textEncodingName = m_frame->document()->inputEncoding();
- } else {
- CachedResource* cachedResource = m_frame->document()->docLoader()->cachedResource(requestURL());
- if (!cachedResource)
- return String();
-
- if (cachedResource->isPurgeable()) {
- // If the resource is purgeable then make it unpurgeable to get
- // get its data. This might fail, in which case we return an
- // empty String.
- // FIXME: should we do something else in the case of a purged
- // resource that informs the user why there is no data in the
- // inspector?
- if (!cachedResource->makePurgeable(false))
- return String();
- }
-
- buffer = cachedResource->data();
- textEncodingName = cachedResource->encoding();
- }
-
+ RefPtr<SharedBuffer> buffer = resourceData(&textEncodingName);
if (!buffer)
return String();
@@ -299,6 +275,31 @@ String InspectorResource::sourceString() const
return encoding.decode(buffer->data(), buffer->size());
}
+PassRefPtr<SharedBuffer> InspectorResource::resourceData(String* textEncodingName) const {
+ if (m_requestURL == m_loader->requestURL()) {
+ *textEncodingName = m_frame->document()->inputEncoding();
+ return m_loader->mainResourceData();
+ }
+
+ CachedResource* cachedResource = m_frame->document()->docLoader()->cachedResource(requestURL());
+ if (!cachedResource)
+ return 0;
+
+ if (cachedResource->isPurgeable()) {
+ // If the resource is purgeable then make it unpurgeable to get
+ // get its data. This might fail, in which case we return an
+ // empty String.
+ // FIXME: should we do something else in the case of a purged
+ // resource that informs the user why there is no data in the
+ // inspector?
+ if (!cachedResource->makePurgeable(false))
+ return 0;
+ }
+
+ *textEncodingName = cachedResource->encoding();
+ return cachedResource->data();
+}
+
void InspectorResource::startTiming()
{
m_startTime = currentTime();
diff --git a/WebCore/inspector/InspectorResource.h b/WebCore/inspector/InspectorResource.h
index 4c85315..5e37e41 100644
--- a/WebCore/inspector/InspectorResource.h
+++ b/WebCore/inspector/InspectorResource.h
@@ -87,12 +87,20 @@ namespace WebCore {
void setXMLHttpResponseText(const ScriptString& data);
String sourceString() const;
+ PassRefPtr<SharedBuffer> resourceData(String* textEncodingName) const;
+
bool isSameLoader(DocumentLoader* loader) const { return loader == m_loader; }
void markMainResource() { m_isMainResource = true; }
long long identifier() const { return m_identifier; }
String requestURL() const { return m_requestURL.string(); }
Frame* frame() const { return m_frame.get(); }
const String& mimeType() const { return m_mimeType; }
+ const HTTPHeaderMap& requestHeaderFields() const { return m_requestHeaderFields; }
+ const HTTPHeaderMap& responseHeaderFields() const { return m_responseHeaderFields; }
+ int responseStatusCode() const { return m_responseStatusCode; }
+ String requestMethod() const { return m_requestMethod; }
+ String requestFormData() const { return m_requestFormData; }
+
void startTiming();
void markResponseReceivedTime();
void endTiming();
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list