[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
aroben at apple.com
aroben at apple.com
Thu Oct 29 20:32:01 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 69f2267d45e7fd8748b65725268fe0edc3d034e3
Author: aroben at apple.com <aroben at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Sep 22 19:29:19 2009 +0000
Manage refcounts correctly in DefaultDownloadDelegate::willSendRequest
Fixes <http://webkit.org/b/29650> Crash in
WebDownload::willSendRequest when using DefaultDownloadDelegate
Reviewed by Brady Eidson.
* DefaultDownloadDelegate.cpp:
(DefaultDownloadDelegate::willSendRequest): Call AddRef() on the
object we're returning via the finalRequest out-parameter.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/win/ChangeLog b/WebKit/win/ChangeLog
index 49949ad..aa43a89 100644
--- a/WebKit/win/ChangeLog
+++ b/WebKit/win/ChangeLog
@@ -1,3 +1,16 @@
+2009-09-22 Adam Roben <aroben at apple.com>
+
+ Manage refcounts correctly in DefaultDownloadDelegate::willSendRequest
+
+ Fixes <http://webkit.org/b/29650> Crash in
+ WebDownload::willSendRequest when using DefaultDownloadDelegate
+
+ Reviewed by Brady Eidson.
+
+ * DefaultDownloadDelegate.cpp:
+ (DefaultDownloadDelegate::willSendRequest): Call AddRef() on the
+ object we're returning via the finalRequest out-parameter.
+
2009-09-21 Anders Carlsson <andersca at apple.com>
Reviewed by Adam Roben.
diff --git a/WebKit/win/DefaultDownloadDelegate.cpp b/WebKit/win/DefaultDownloadDelegate.cpp
index a50d119..cf443b5 100644
--- a/WebKit/win/DefaultDownloadDelegate.cpp
+++ b/WebKit/win/DefaultDownloadDelegate.cpp
@@ -203,6 +203,7 @@ HRESULT STDMETHODCALLTYPE DefaultDownloadDelegate::willSendRequest(IWebDownload*
download = 0;
redirectResponse = 0;
*finalRequest = request;
+ (*finalRequest)->AddRef();
return S_OK;
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list