[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
pfeldman at chromium.org
pfeldman at chromium.org
Thu Oct 29 20:34:49 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 6cf9e1808c04986ff100b03f1c30598d2dab9a67
Author: pfeldman at chromium.org <pfeldman at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sun Sep 27 09:19:13 2009 +0000
2009-09-27 Pavel Feldman <pfeldman at chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: DOM store is being unbound twice, leading to assertion failure.
https://bugs.webkit.org/show_bug.cgi?id=29770
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didOpenDatabase):
(WebCore::InspectorController::didUseDOMStorage):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::unbind):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 9a420b6..51d47bb 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2009-09-27 Pavel Feldman <pfeldman at chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: DOM store is being unbound twice, leading to assertion failure.
+
+ https://bugs.webkit.org/show_bug.cgi?id=29770
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didOpenDatabase):
+ (WebCore::InspectorController::didUseDOMStorage):
+ * inspector/InspectorDOMStorageResource.cpp:
+ (WebCore::InspectorDOMStorageResource::unbind):
+
2009-09-26 Pavel Feldman <pfeldman at chromium.org>
Reviewed by Timothy Hatcher.
diff --git a/WebCore/inspector/InspectorController.cpp b/WebCore/inspector/InspectorController.cpp
index c66c7f2..e65f21c 100644
--- a/WebCore/inspector/InspectorController.cpp
+++ b/WebCore/inspector/InspectorController.cpp
@@ -1094,7 +1094,8 @@ void InspectorController::didOpenDatabase(Database* database, const String& doma
m_databaseResources.add(resource);
- if (m_frontend)
+ // Resources are only bound while visible.
+ if (m_frontend && windowVisible())
resource->bind(m_frontend.get());
}
#endif
@@ -1115,7 +1116,8 @@ void InspectorController::didUseDOMStorage(StorageArea* storageArea, bool isLoca
m_domStorageResources.add(resource);
- if (m_frontend)
+ // Resources are only bound while visible.
+ if (m_frontend && windowVisible())
resource->bind(m_frontend.get());
}
diff --git a/WebCore/inspector/InspectorDOMStorageResource.cpp b/WebCore/inspector/InspectorDOMStorageResource.cpp
index 99a2dba..7ed0d7f 100644
--- a/WebCore/inspector/InspectorDOMStorageResource.cpp
+++ b/WebCore/inspector/InspectorDOMStorageResource.cpp
@@ -79,7 +79,9 @@ void InspectorDOMStorageResource::bind(InspectorFrontend* frontend)
void InspectorDOMStorageResource::unbind()
{
- ASSERT(m_frontend);
+ if (!m_frontend)
+ return; // Already unbound.
+
if (m_reportingChangesToFrontend) {
m_frame->domWindow()->removeEventListener(eventNames().storageEvent, this, true);
m_reportingChangesToFrontend = false;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list