[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
pfeldman at chromium.org
pfeldman at chromium.org
Thu Oct 29 20:35:13 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 7459fedb010aff61aedd611c6c829e637a311560
Author: pfeldman at chromium.org <pfeldman at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Sep 28 20:33:41 2009 +0000
2009-09-28 Pavel Feldman <pfeldman at chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add explicit frontend event for commit load.
https://bugs.webkit.org/show_bug.cgi?id=29814
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didCommitLoad):
* inspector/InspectorFrontend.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._setDocument):
* inspector/front-end/inspector.js:
(WebInspector.addResource):
(WebInspector.didCommitLoad):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 7ef816b..05f04f1 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,22 @@
+2009-09-28 Pavel Feldman <pfeldman at chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: Add explicit frontend event for commit load.
+
+ https://bugs.webkit.org/show_bug.cgi?id=29814
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didCommitLoad):
+ * inspector/InspectorFrontend.cpp:
+ (WebCore::InspectorFrontend::didCommitLoad):
+ * inspector/InspectorFrontend.h:
+ * inspector/front-end/DOMAgent.js:
+ (WebInspector.DOMAgent.prototype._setDocument):
+ * inspector/front-end/inspector.js:
+ (WebInspector.addResource):
+ (WebInspector.didCommitLoad):
+
2009-09-28 Yaar Schnitman <yaar at chromium.org>
Reviewed by Dimitri Glazkov.
diff --git a/WebCore/inspector/InspectorController.cpp b/WebCore/inspector/InspectorController.cpp
index e65f21c..bb77ebf 100644
--- a/WebCore/inspector/InspectorController.cpp
+++ b/WebCore/inspector/InspectorController.cpp
@@ -764,8 +764,10 @@ void InspectorController::didCommitLoad(DocumentLoader* loader)
// identifierForInitialRequest.
m_mainResource = 0;
}
- if (windowVisible())
+ if (windowVisible()) {
+ m_frontend->didCommitLoad();
m_domAgent->setDocument(m_inspectedPage->mainFrame()->document());
+ }
}
}
diff --git a/WebCore/inspector/InspectorFrontend.cpp b/WebCore/inspector/InspectorFrontend.cpp
index 9f329a6..63bb6e2 100644
--- a/WebCore/inspector/InspectorFrontend.cpp
+++ b/WebCore/inspector/InspectorFrontend.cpp
@@ -73,6 +73,11 @@ ScriptObject InspectorFrontend::newScriptObject()
return ScriptObject::createNew(m_scriptState);
}
+void InspectorFrontend::didCommitLoad()
+{
+ callSimpleFunction("didCommitLoad");
+}
+
void InspectorFrontend::addMessageToConsole(const ScriptObject& messageObj, const Vector<ScriptString>& frames, const Vector<ScriptValue> wrappedArguments, const String& message)
{
OwnPtr<ScriptFunctionCall> function(newFunctionCall("addMessageToConsole"));
diff --git a/WebCore/inspector/InspectorFrontend.h b/WebCore/inspector/InspectorFrontend.h
index 397868b..51f17fb 100644
--- a/WebCore/inspector/InspectorFrontend.h
+++ b/WebCore/inspector/InspectorFrontend.h
@@ -62,6 +62,7 @@ namespace WebCore {
ScriptArray newScriptArray();
ScriptObject newScriptObject();
+ void didCommitLoad();
void addMessageToConsole(const ScriptObject& messageObj, const Vector<ScriptString>& frames, const Vector<ScriptValue> wrappedArguments, const String& message);
void clearConsoleMessages();
diff --git a/WebCore/inspector/front-end/DOMAgent.js b/WebCore/inspector/front-end/DOMAgent.js
index 3207c25..a151c05 100644
--- a/WebCore/inspector/front-end/DOMAgent.js
+++ b/WebCore/inspector/front-end/DOMAgent.js
@@ -378,13 +378,16 @@ WebInspector.DOMAgent.prototype = {
_setDocument: function(payload)
{
- this.document = new WebInspector.DOMDocument(this, this._window, payload);
this._idToDOMNode = {};
- this._idToDOMNode[payload.id] = this.document;
- this._bindNodes(this.document.children);
+ if (payload) {
+ this.document = new WebInspector.DOMDocument(this, this._window, payload);
+ this._idToDOMNode[payload.id] = this.document;
+ this._bindNodes(this.document.children);
+ } else
+ this.document = null;
WebInspector.panels.elements.reset();
},
-
+
_setDetachedRoot: function(payload)
{
var root = new WebInspector.DOMNode(this.document, payload);
diff --git a/WebCore/inspector/front-end/inspector.js b/WebCore/inspector/front-end/inspector.js
index b6de65e..de4f4fb 100644
--- a/WebCore/inspector/front-end/inspector.js
+++ b/WebCore/inspector/front-end/inspector.js
@@ -919,10 +919,8 @@ WebInspector.addResource = function(identifier, payload)
this.resources[identifier] = resource;
this.resourceURLMap[resource.url] = resource;
- if (resource.mainResource) {
+ if (resource.mainResource)
this.mainResource = resource;
- this.panels.elements.reset();
- }
if (this.panels.resources)
this.panels.resources.addResource(resource);
@@ -1122,6 +1120,12 @@ WebInspector.resourceURLChanged = function(resource, oldURL)
this.resourceURLMap[resource.url] = resource;
}
+WebInspector.didCommitLoad = function()
+{
+ // Cleanup elements panel early on inspected page refresh.
+ WebInspector.setDocument(null);
+}
+
WebInspector.addMessageToConsole = function(payload)
{
var consoleMessage = new WebInspector.ConsoleMessage(
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list