[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
eric at webkit.org
eric at webkit.org
Thu Oct 29 20:41:10 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 51cc7d351a080a2f1ec065cef60852547f16a5a6
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Oct 7 18:10:26 2009 +0000
2009-10-07 Evan Martin <evan at chromium.org>
Reviewed by Simon Fraser.
Add a currently-failing test exhibiting the problem in
https://bugs.webkit.org/show_bug.cgi?id=20674:
When converting very large or small numbers back to strings, exponential
notation is used, so a value like 90010000px is returned from
getComputedStyle() as 9.001e+07px.
9.001e+07px does not parse, so such a value cannot be round-tripped.
This is a particular problem with tranformation matrices, which can often
contain very large or small numbers.
(Test written by Simon Fraser; I've just made it a committable patch.)
* fast/css/large-number-round-trip-expected.txt: Added.
* fast/css/large-number-round-trip.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 86f65d2..4ce5290 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,5 +1,26 @@
2009-10-07 Evan Martin <evan at chromium.org>
+ Reviewed by Simon Fraser.
+
+ Add a currently-failing test exhibiting the problem in
+ https://bugs.webkit.org/show_bug.cgi?id=20674:
+
+ When converting very large or small numbers back to strings, exponential
+ notation is used, so a value like 90010000px is returned from
+ getComputedStyle() as 9.001e+07px.
+
+ 9.001e+07px does not parse, so such a value cannot be round-tripped.
+
+ This is a particular problem with tranformation matrices, which can often
+ contain very large or small numbers.
+
+ (Test written by Simon Fraser; I've just made it a committable patch.)
+
+ * fast/css/large-number-round-trip-expected.txt: Added.
+ * fast/css/large-number-round-trip.html: Added.
+
+2009-10-07 Evan Martin <evan at chromium.org>
+
Reviewed by Darin Adler.
Layout test for verifying that LC_NUMERIC setting doesn't affect
diff --git a/LayoutTests/fast/css/large-number-round-trip-expected.txt b/LayoutTests/fast/css/large-number-round-trip-expected.txt
new file mode 100644
index 0000000..c9c6dc1
--- /dev/null
+++ b/LayoutTests/fast/css/large-number-round-trip-expected.txt
@@ -0,0 +1 @@
+FAIL: read 90010000px back as 9.001e+07px, read again as 0px
diff --git a/LayoutTests/fast/css/large-number-round-trip.html b/LayoutTests/fast/css/large-number-round-trip.html
new file mode 100644
index 0000000..f149f9c
--- /dev/null
+++ b/LayoutTests/fast/css/large-number-round-trip.html
@@ -0,0 +1,43 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
+ "http://www.w3.org/TR/html4/loose.dtd">
+
+<html lang="en">
+<head>
+ <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
+ <title>Round-trip large values</title>
+ <style type="text/css" media="screen">
+ #box {
+ position: absolute;
+ }
+ </style>
+</head>
+<body>
+<div id="box">
+</div>
+<div id="results">
+</div>
+<script type="text/javascript" charset="utf-8">
+ if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+
+ var box = document.getElementById('box');
+
+ var testValue = "90010000px";
+ box.style.left = testValue;
+
+ var leftValue = window.getComputedStyle(box).left;
+
+ box.style.left = "0px";
+ box.style.left = leftValue;
+ var newLeftValue = window.getComputedStyle(box).left;
+
+ var results = document.getElementById('results');
+ var result;
+ if (leftValue == newLeftValue)
+ result = "PASS: read " + testValue + " back as " + leftValue + ", read again as " + newLeftValue;
+ else
+ result = "FAIL: read " + testValue + " back as " + leftValue + ", read again as " + newLeftValue;
+ results.innerHTML = result;
+</script>
+</body>
+</html>
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list