[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
eric at webkit.org
eric at webkit.org
Thu Oct 29 20:41:57 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit da63bb3e5607ab0d383d47dbcb02c25302824bb0
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Oct 8 20:57:26 2009 +0000
2009-10-08 Patrick Mueller <Patrick_Mueller at us.ibm.com>
Reviewed by Timothy Hatcher.
unselectable resources in resource panel
https://bugs.webkit.org/show_bug.cgi?id=30079
manual test added
Also changed the way DnD for resources in the Resources panel is
handled.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceSidebarTreeElement.prototype.onattach):
(WebInspector.ResourceSidebarTreeElement.prototype.ondragstart):
* manual-tests/inspector/duplicate-resource-urls.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 698bec9..1f941be 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2009-10-08 Patrick Mueller <Patrick_Mueller at us.ibm.com>
+
+ Reviewed by Timothy Hatcher.
+
+ unselectable resources in resource panel
+ https://bugs.webkit.org/show_bug.cgi?id=30079
+
+ manual test added
+
+ Also changed the way DnD for resources in the Resources panel is
+ handled.
+
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
+ (WebInspector.ResourceSidebarTreeElement.prototype.ondragstart):
+ * manual-tests/inspector/duplicate-resource-urls.html: Added.
+
2009-10-08 Brian Weinstein <bweinstein at apple.com>
Reviewed by Timothy Hatcher.
diff --git a/WebCore/inspector/front-end/ResourcesPanel.js b/WebCore/inspector/front-end/ResourcesPanel.js
index b575fc3..d4da3c8 100644
--- a/WebCore/inspector/front-end/ResourcesPanel.js
+++ b/WebCore/inspector/front-end/ResourcesPanel.js
@@ -1269,13 +1269,12 @@ WebInspector.ResourceSidebarTreeElement.prototype = {
{
WebInspector.SidebarTreeElement.prototype.onattach.call(this);
- var link = document.createElement("a");
- link.href = this.resource.url;
- link.className = "invisible";
- while (this._listItemNode.firstChild)
- link.appendChild(this._listItemNode.firstChild);
- this._listItemNode.appendChild(link);
this._listItemNode.addStyleClass("resources-category-" + this.resource.category.name);
+ this._listItemNode.draggable = true;
+
+ // FIXME: should actually add handler to parent, to be resolved via
+ // https://bugs.webkit.org/show_bug.cgi?id=30227
+ this._listItemNode.addEventListener("dragstart", this.ondragstart.bind(this), false);
},
onselect: function()
@@ -1288,6 +1287,13 @@ WebInspector.ResourceSidebarTreeElement.prototype = {
InjectedScriptAccess.openInInspectedWindow(this.resource.url, function() {});
},
+ ondragstart: function(event) {
+ event.dataTransfer.setData("text/plain", this.resource.url);
+ event.dataTransfer.setData("text/uri-list", this.resource.url + "\r\n");
+ event.dataTransfer.effectAllowed = "copy";
+ return true;
+ },
+
get mainTitle()
{
return this.resource.displayName;
diff --git a/WebCore/inspector/front-end/inspector.css b/WebCore/inspector/front-end/inspector.css
index 561288f..ffd5562 100644
--- a/WebCore/inspector/front-end/inspector.css
+++ b/WebCore/inspector/front-end/inspector.css
@@ -826,11 +826,6 @@ body.drawer-visible #drawer {
vertical-align: top;
}
-.invisible {
- color: inherit;
- text-decoration: none;
-}
-
.webkit-line-gutter-backdrop {
/* Keep this in sync with view-source.css (.webkit-line-gutter-backdrop) */
width: 31px;
diff --git a/WebCore/manual-tests/inspector/duplicate-resource-urls.html b/WebCore/manual-tests/inspector/duplicate-resource-urls.html
new file mode 100644
index 0000000..7a9be7e
--- /dev/null
+++ b/WebCore/manual-tests/inspector/duplicate-resource-urls.html
@@ -0,0 +1,61 @@
+<html>
+<head>
+<title>Tests for Bug 30079</title>
+<meta http-equiv="Content-Type" content="text/html;charset=utf-8" >
+</head>
+
+<body>
+<p>Tests for
+<ul>
+<li><p><a href="https://bugs.webkit.org/show_bug.cgi?id=30079">Bug 30079: unselectable resources in resource panel</a>
+</ul>
+
+<p>To test, open the Inspector on this page, go to the Resources panel.
+
+<p>First off, you should be able to actually select each "abc" resource to see
+the HTTP info / content. Bug 30079 didn't allow you to select all of these.
+
+<p>For each of the "abc" resources open the <b>HTTP Information</b> and
+<b>Request Payload</b> tree elements above the content. One of the resources
+will not have a <b>Request Payload</b>.
+
+<p>There should be one each of the following resources:
+
+<ul>
+<li><p>One with a Request Method: GET and no Request Payload
+<li><p>One with a Request Method: POST and Request Payload of "123"
+<li><p>One with a Request Method: POST and Request Payload of "456"
+</ul>
+
+<p>Another change made by this bug was to change the way the drag/drop of
+the resource itself worked. The previous method of handling drag/drop of
+the resource was actually causing the unselectability. So the drag/drop
+of the resources needs to be tested as well.
+
+<ul>
+<li><p>Select one of the resources.
+<li><p>Drag it to an application that can accept text or a link
+<li><p>The application should provide some feedback indicating it will accept
+the drop, but may not
+<li>Drop, and the URL for the resource should be rendered appropriately.
+
+<script>
+
+var xhr;
+
+xhr = new XMLHttpRequest();
+xhr.open("POST", "http://example.org/abc");
+xhr.send("123");
+
+xhr = new XMLHttpRequest();
+xhr.open("POST", "http://example.org/abc");
+xhr.send("456");
+
+xhr = new XMLHttpRequest();
+xhr.open("GET", "http://example.org/abc");
+xhr.send();
+
+</script>
+
+</body>
+</html>
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list