[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
darin at chromium.org
darin at chromium.org
Thu Oct 29 20:42:48 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 41f5d52342fa82ea81f02ae87943b4280c6862e6
Author: darin at chromium.org <darin at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sat Oct 10 13:53:52 2009 +0000
2009-10-09 Darin Fisher <darin at chromium.org>
Reviewed by Eric Seidel.
[Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
https://bugs.webkit.org/show_bug.cgi?id=30262
This is not testable from WebKit since WebKit never uses the member
function form of protocolIs with input that can be controlled from a
web page. It always passes string literals lacking hyphens.
* platform/KURLGoogle.cpp:
(WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would
transform the input character.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index e11dd38..76a9cb1 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2009-10-09 Darin Fisher <darin at chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ [Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
+ https://bugs.webkit.org/show_bug.cgi?id=30262
+
+ This is not testable from WebKit since WebKit never uses the member
+ function form of protocolIs with input that can be controlled from a
+ web page. It always passes string literals lacking hyphens.
+
+ * platform/KURLGoogle.cpp:
+ (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would
+ transform the input character.
+
2009-10-10 Adam Barth <abarth at webkit.org>
Reviewed by Oliver Hunt.
diff --git a/WebCore/platform/KURLGoogle.cpp b/WebCore/platform/KURLGoogle.cpp
index b323332..d0aae0c 100644
--- a/WebCore/platform/KURLGoogle.cpp
+++ b/WebCore/platform/KURLGoogle.cpp
@@ -106,7 +106,7 @@ static inline bool isUnicodeEncoding(const TextEncoding* encoding)
static bool lowerCaseEqualsASCII(const char* begin, const char* end, const char* str)
{
while (begin != end && *str) {
- ASSERT(isASCIILower(*str));
+ ASSERT(toASCIILower(*str) == *str);
if (toASCIILower(*begin++) != *str++)
return false;
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list