[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75

dimich at chromium.org dimich at chromium.org
Thu Oct 29 20:44:08 UTC 2009


The following commit has been merged in the webkit-1.1 branch:
commit 731fbb5347d08f69e0bfeabe55a64f96bc8ffa48
Author: dimich at chromium.org <dimich at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Oct 14 01:16:01 2009 +0000

    Chrome's "Skia" theme paints select controls backwards in RTL.
    
    Patch by Evan Martin <evan at chromium.org> on 2009-10-13
    Reviewed by Dmitry Titov.
    
    https://bugs.webkit.org/show_bug.cgi?id=30320
    
    Test: fast/text/international/bidi-menulist.html
    (The test is about something else, but it includes RTL selects.)
    
    * rendering/RenderThemeChromiumSkia.cpp:
    (WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 32d56ec..c4254cf 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2009-10-13  Evan Martin  <evan at chromium.org>
+
+        Reviewed by Dmitry Titov.
+
+        Chrome's "Skia" theme paints select controls backwards in RTL.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30320
+
+        Test: fast/text/international/bidi-menulist.html
+        (The test is about something else, but it includes RTL selects.)
+
+        * rendering/RenderThemeChromiumSkia.cpp:
+        (WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case.
+
 2009-10-13  Dmitry Titov  <dimich at chromium.org>
 
         Reviewed by Alexey Proskuryakov.
diff --git a/WebCore/rendering/RenderThemeChromiumSkia.cpp b/WebCore/rendering/RenderThemeChromiumSkia.cpp
index 3a39423..fb42bb7 100644
--- a/WebCore/rendering/RenderThemeChromiumSkia.cpp
+++ b/WebCore/rendering/RenderThemeChromiumSkia.cpp
@@ -585,8 +585,9 @@ bool RenderThemeChromiumSkia::paintMenuList(RenderObject* o, const RenderObject:
     paint.setAntiAlias(true);
     paint.setStyle(SkPaint::kFill_Style);
 
+    int arrowXPosition = (o->style()->direction() == RTL) ? rect.x() + 7 : right - 13;
     SkPath path;
-    path.moveTo(right - 13, middle - 3);
+    path.moveTo(arrowXPosition, middle - 3);
     path.rLineTo(6, 0);
     path.rLineTo(-3, 6);
     path.close();

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list