[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75

eric at webkit.org eric at webkit.org
Thu Oct 29 20:44:52 UTC 2009


The following commit has been merged in the webkit-1.1 branch:
commit 22141f273b6c8d379be46229311ca04ee4cd6011
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Oct 15 02:39:34 2009 +0000

    2009-10-14  Evan Martin  <evan at chromium.org>
    
            Reviewed by Darin Adler.
    
            Document what state the build tree is expected to be in after a patch.
    
            * coding/contributing.html:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitSite/ChangeLog b/WebKitSite/ChangeLog
index a9db049..9b0d2ac 100644
--- a/WebKitSite/ChangeLog
+++ b/WebKitSite/ChangeLog
@@ -1,3 +1,11 @@
+2009-10-14  Evan Martin  <evan at chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Document what state the build tree is expected to be in after a patch.
+
+        * coding/contributing.html:
+
 2009-10-11  Cameron McCormack  <cam at mcc.id.au>
 
         Reviewed by Eric Seidel.
diff --git a/WebKitSite/coding/contributing.html b/WebKitSite/coding/contributing.html
index 6f343b1..ca5154d 100644
--- a/WebKitSite/coding/contributing.html
+++ b/WebKitSite/coding/contributing.html
@@ -63,10 +63,14 @@ believes the feature should never be committed to the tree. The review process c
 the reviewer as revisions are made to your patch.</p>
 
 <h3 id="landing">Landing in the tree</h3>
-<p>Once a patch is approved, you should ask <a href="https://lists.webkit.org/mailman/roster.cgi/webkit-committers">someone with commit access</a> to land your patch. Alternatively you can request that your patch be committed by our <a href="#commitqueue">commit bot</a>. In either case, your responsibility for the patch does not end with the patch landing in the tree. There may be regressions from your change or additional feedback from reviewers after the patch has landed. You can watch the tree at <a href="http://build.webkit.org">build.webkit.org</a> to make sure your patch builds and passes tests on all platforms.
-It is your responsibility to be available should regressions arise and to respond to additional feedback that happens after a check-in.</p>
+<p>Once a patch is approved, you should ask <a href="https://lists.webkit.org/mailman/roster.cgi/webkit-committers">someone with commit access</a> to land your patch. Alternatively you can request that your patch be committed by our <a href="#commitqueue">commit bot</a>.</p>
 
-<h3 id="commitqueue">Optional: Use of the WebKit Commit Bot</h3>
+<h4>Keeping the tree green</h4>
+<p>In either case, your responsibility for the patch does not end with the patch landing in the tree. There may be regressions from your change or additional feedback from reviewers after the patch has landed. You can watch the tree at <a href="http://build.webkit.org">build.webkit.org</a> to make sure your patch builds and passes tests on all platforms.  It is your responsibility to be available should regressions arise and to respond to additional feedback that happens after a check-in.</p>
+
+<p>Changes should succeed on all platforms, but it can be difficult to test on every platform WebKit supports.  Be certain that your change does not introduce new test failures on the high-traffic Mac or Windows ports by comparing the list of failing tests before and after your change.  Your change must at least compile on all platforms.</p>
+
+<h4 id="commitqueue">Optional: Use of the WebKit Commit Bot</h4>
 <p>WebKit provides an automated system (commit-queue) for landing patches for any who would like to use it.  To use the commit-queue, set the <tt>commit-queue:?</tt> flag on your patch.  A committer will set <tt>commit-queue:+</tt> and an automated process will download, build, run the layout tests, and submit your patch on your behalf.  If the <a href="http://build.webkit.org/">WebKit buildbots</a> are passing, your patch should be landed within 15 minutes after <tt>commit-queue:+</tt> is set. See the <a href="https://trac.webkit.org/wiki/CommitQueue">commit-queue documentation</a> for more information.</p>
 
 <h2>WebKit Scripts</h2>

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list