[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
eric at webkit.org
eric at webkit.org
Thu Oct 29 20:45:12 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit d44d95898783af6f5a51b7ab2cafaffd3ab64100
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Oct 15 12:49:25 2009 +0000
2009-10-15 Shu Chang <Chang.Shu at nokia.com>
Reviewed by Adele Peterson.
Change behavior so that <a> element is always mouse-focusable.
* fast/events/click-focus-anchor-expected.txt:
* fast/events/click-focus-anchor.html:
2009-10-15 Shu Chang <Chang.Shu at nokia.com>
Reviewed by Adele Peterson.
Anchor elements should be mouse focusable regardless isLink flag.
https://bugs.webkit.org/show_bug.cgi?id=26856
* html/HTMLAnchorElement.cpp:
* html/HTMLAnchorElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index b5ef943..6118d35 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,12 @@
+2009-10-15 Shu Chang <Chang.Shu at nokia.com>
+
+ Reviewed by Adele Peterson.
+
+ Change behavior so that <a> element is always mouse-focusable.
+
+ * fast/events/click-focus-anchor-expected.txt:
+ * fast/events/click-focus-anchor.html:
+
2009-10-15 Yury Semikhatsky <yurys at chromium.org>
Reviewed by Dave Hyatt.
diff --git a/LayoutTests/fast/events/click-focus-anchor-expected.txt b/LayoutTests/fast/events/click-focus-anchor-expected.txt
index 604c6ae..fbd644d 100644
--- a/LayoutTests/fast/events/click-focus-anchor-expected.txt
+++ b/LayoutTests/fast/events/click-focus-anchor-expected.txt
@@ -1,7 +1,10 @@
-This test ensures that we can click to focus an a element with a tab index. Click on the element below.
+This test ensures that we can click to focus an a element. Click on the element below.
-Focusable
+Focusable anchor with tab index
+
+Focusable anchor
Result
PASS
+PASS
diff --git a/LayoutTests/fast/events/click-focus-anchor.html b/LayoutTests/fast/events/click-focus-anchor.html
index f41cde4..20957e2 100644
--- a/LayoutTests/fast/events/click-focus-anchor.html
+++ b/LayoutTests/fast/events/click-focus-anchor.html
@@ -4,20 +4,22 @@
</head>
<body>
-<p>This test ensures that we can click to focus an a element with a tab index.
+<p>This test ensures that we can click to focus an a element.
Click on the element below.
-<p><a tabindex=0 onfocus="pass()" id=t>Focusable</a>
+<p><a tabindex=0 onfocus="pass('r1')" id=t1>Focusable anchor with tab index</a>
+<p><a onfocus="pass('r2')" id=t2 href="#">Focusable anchor</a>
<p>Result
-<pre>FAIL</pre>
+<pre id=r1>FAIL</pre>
+<pre id=r2>FAIL</pre>
<script>
-function pass()
+function pass(id)
{
- var el = document.querySelector('pre');
+ var el = document.getElementById(id);
el.textContent = 'PASS';
}
@@ -31,7 +33,11 @@ window.onload = function()
if (!window.layoutTestController)
return;
- var aElement = document.getElementById('t');
+ var aElement = document.getElementById('t1');
+ eventSender.mouseMoveTo(aElement.offsetLeft + 2, aElement.offsetTop + 2);
+ eventSender.mouseDown();
+
+ aElement = document.getElementById('t2');
eventSender.mouseMoveTo(aElement.offsetLeft + 2, aElement.offsetTop + 2);
eventSender.mouseDown();
};
diff --git a/LayoutTests/platform/mac/fast/events/click-focus-anchor-expected.txt b/LayoutTests/platform/mac/fast/events/click-focus-anchor-expected.txt
new file mode 100644
index 0000000..c934629
--- /dev/null
+++ b/LayoutTests/platform/mac/fast/events/click-focus-anchor-expected.txt
@@ -0,0 +1,10 @@
+This test ensures that we can click to focus an a element. Click on the element below.
+
+Focusable anchor with tab index
+
+Focusable anchor
+
+Result
+
+PASS
+FAIL
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 1fc46e6..b2cadbd 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,13 @@
+2009-10-15 Shu Chang <Chang.Shu at nokia.com>
+
+ Reviewed by Adele Peterson.
+
+ Anchor elements should be mouse focusable regardless isLink flag.
+ https://bugs.webkit.org/show_bug.cgi?id=26856
+
+ * html/HTMLAnchorElement.cpp:
+ * html/HTMLAnchorElement.h:
+
2009-10-15 Nikolas Zimmermann <nzimmermann at rim.com>
Not reviewed. Sort XCode project file.
diff --git a/WebCore/html/HTMLAnchorElement.cpp b/WebCore/html/HTMLAnchorElement.cpp
index daa7919..927c81f 100644
--- a/WebCore/html/HTMLAnchorElement.cpp
+++ b/WebCore/html/HTMLAnchorElement.cpp
@@ -67,7 +67,7 @@ bool HTMLAnchorElement::supportsFocus() const
bool HTMLAnchorElement::isMouseFocusable() const
{
// Anchor elements should be mouse focusable, https://bugs.webkit.org/show_bug.cgi?id=26856
-#if !PLATFORM(GTK)
+#if PLATFORM(MAC)
if (isLink())
return false;
#endif
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list