[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
eric at webkit.org
eric at webkit.org
Thu Oct 29 20:47:04 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 3baa80d22d5dfedbbbffe6bb54d5161f80163c42
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sun Oct 18 16:23:15 2009 +0000
2009-10-18 Joanmarie Diggs <joanmarie.diggs at gmail.com>
Reviewed by Xan Lopez
https://bugs.webkit.org/show_bug.cgi?id=25901
Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag
Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_role):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 5890701..c5c4c78 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2009-10-18 Joanmarie Diggs <joanmarie.diggs at gmail.com>
+
+ Reviewed by Xan Lopez
+
+ https://bugs.webkit.org/show_bug.cgi?id=25901
+ Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag
+
+ Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (webkit_accessible_get_role):
+
2009-10-17 Nikolas Zimmermann <nzimmermann at rim.com>
Reviewed by George Staikos.
diff --git a/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp b/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
index 0ec073b..ce9d565 100644
--- a/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
+++ b/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
@@ -256,8 +256,6 @@ static AtkRole atkRole(AccessibilityRole role)
return ATK_ROLE_TABLE;
case ApplicationRole:
return ATK_ROLE_APPLICATION;
- //case LabelRole: // TODO: should this be covered in the switch?
- // return ATK_ROLE_LABEL;
case GroupRole:
case RadioGroupRole:
return ATK_ROLE_PANEL;
@@ -300,11 +298,17 @@ static AtkRole webkit_accessible_get_role(AtkObject* object)
return ATK_ROLE_LIST_ITEM;
}
- // WebCore does not know about paragraph role
+ // WebCore does not know about paragraph role, label role, or section role
if (AXObject->isAccessibilityRenderObject()) {
Node* node = static_cast<AccessibilityRenderObject*>(AXObject)->renderer()->node();
- if (node && node->hasTagName(HTMLNames::pTag))
- return ATK_ROLE_PARAGRAPH;
+ if (node) {
+ if (node->hasTagName(HTMLNames::pTag))
+ return ATK_ROLE_PARAGRAPH;
+ if (node->hasTagName(HTMLNames::labelTag))
+ return ATK_ROLE_LABEL;
+ if (node->hasTagName(HTMLNames::divTag))
+ return ATK_ROLE_SECTION;
+ }
}
// Note: Why doesn't WebCore have a password field for this
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list