[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
bweinstein at apple.com
bweinstein at apple.com
Thu Oct 29 20:49:46 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit fdf2635b9cb33af6dec80020c58cde5f077c0f14
Author: bweinstein at apple.com <bweinstein at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Oct 21 21:51:20 2009 +0000
WebCore: Fixes part of <http://webkit.org/b/30522>.
Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.
Reviewed by Eric Seidel.
Expose the description attribute that is now a member of
ExceptionBase as of r49723, so when a user logs an exception, they
can see the description in the Web Inspector.
Test: fast/dom/dom-exception-description.html
* dom/DOMCoreException.idl:
* dom/EventException.idl:
* dom/RangeException.idl:
* svg/SVGException.idl:
* xml/XMLHttpRequestException.idl:
* xml/XPathException.idl:
LayoutTests: Fixes part of <http://webkit.org/b/30522>.
Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.
Reviewed by Eric Seidel.
Adds a test to check the name and description of some DOM Exceptions.
* fast/dom/dom-exception-description-expected.txt: Added.
* fast/dom/dom-exception-description.html: Added.
* fast/dom/script-tests/dom-exception-description.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index c4f67b6..1b5077d 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,16 @@
+2009-10-21 Brian Weinstein <bweinstein at apple.com>
+
+ Reviewed by Eric Seidel.
+
+ Fixes part of <http://webkit.org/b/30522>.
+ Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.
+
+ Adds a test to check the name and description of some DOM Exceptions.
+
+ * fast/dom/dom-exception-description-expected.txt: Added.
+ * fast/dom/dom-exception-description.html: Added.
+ * fast/dom/script-tests/dom-exception-description.js: Added.
+
2009-10-21 Alejandro G. Castro <alex at igalia.com>
Reviewed by Xan Lopez.
diff --git a/LayoutTests/fast/dom/dom-exception-description-expected.txt b/LayoutTests/fast/dom/dom-exception-description-expected.txt
new file mode 100644
index 0000000..7237acf
--- /dev/null
+++ b/LayoutTests/fast/dom/dom-exception-description-expected.txt
@@ -0,0 +1,15 @@
+This test checks the names and descriptions of DOM exceptions matches what they should be.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.exception.name is "NOT_FOUND_ERR"
+An attempt was made to reference a Node in a context where it does not exist.
+PASS window.exception.name is "HIERARCHY_REQUEST_ERR"
+A Node was inserted somewhere it doesn't belong.
+PASS window.exception.name is "INDEX_SIZE_ERR"
+Index or size was negative, or greater than the allowed value.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/fast/dom/dom-exception-description.html b/LayoutTests/fast/dom/dom-exception-description.html
new file mode 100644
index 0000000..3f4d289
--- /dev/null
+++ b/LayoutTests/fast/dom/dom-exception-description.html
@@ -0,0 +1,13 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<link rel="stylesheet" href="../js/resources/js-test-style.css">
+<script src="../js/resources/js-test-pre.js"></script>
+</head>
+<body>
+<p id="description"></p>
+<div id="console"></div>
+<script src="script-tests/dom-exception-description.js"></script>
+<script src="../js/resources/js-test-post.js"></script>
+</body>
+</html>
diff --git a/LayoutTests/fast/dom/script-tests/dom-exception-description.js b/LayoutTests/fast/dom/script-tests/dom-exception-description.js
new file mode 100755
index 0000000..cc1b4ca
--- /dev/null
+++ b/LayoutTests/fast/dom/script-tests/dom-exception-description.js
@@ -0,0 +1,30 @@
+description("This test checks the names and descriptions of DOM exceptions matches what they should be.");
+
+try {
+ document.appendChild();
+} catch (e) {
+ // FIXME: Setting window.exception because shouldBe needs a global variable
+ window.exception = e;
+ shouldBeEqualToString("window.exception.name", "NOT_FOUND_ERR");
+ debug(e.description);
+}
+
+try {
+ document.appendChild(document.createElement());
+} catch (e) {
+ // FIXME: Setting window.exception because shouldBe needs a global variable
+ window.exception = e;
+ shouldBeEqualToString("window.exception.name", "HIERARCHY_REQUEST_ERR");
+ debug(e.description);
+}
+
+try {
+ document.createTextNode("foo").splitText(10000);
+} catch (e) {
+ // FIXME: Setting window.exception because shouldBe needs a global variable
+ window.exception = e;
+ shouldBeEqualToString("window.exception.name", "INDEX_SIZE_ERR");
+ debug(e.description);
+}
+
+var successfullyParsed = true;
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 46289a6..3f25995 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,5 +1,25 @@
2009-10-21 Brian Weinstein <bweinstein at apple.com>
+ Reviewed by Eric Seidel.
+
+ Fixes part of <http://webkit.org/b/30522>.
+ Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.
+
+ Expose the description attribute that is now a member of
+ ExceptionBase as of r49723, so when a user logs an exception, they
+ can see the description in the Web Inspector.
+
+ Test: fast/dom/dom-exception-description.html
+
+ * dom/DOMCoreException.idl:
+ * dom/EventException.idl:
+ * dom/RangeException.idl:
+ * svg/SVGException.idl:
+ * xml/XMLHttpRequestException.idl:
+ * xml/XPathException.idl:
+
+2009-10-21 Brian Weinstein <bweinstein at apple.com>
+
Reviewed by Timothy Hatcher.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30616>.
diff --git a/WebCore/dom/DOMCoreException.idl b/WebCore/dom/DOMCoreException.idl
index 3001995..abfb075 100644
--- a/WebCore/dom/DOMCoreException.idl
+++ b/WebCore/dom/DOMCoreException.idl
@@ -35,6 +35,7 @@ module core {
readonly attribute unsigned short code;
readonly attribute DOMString name;
readonly attribute DOMString message;
+ readonly attribute DOMString description;
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
// Override in a Mozilla compatible format
diff --git a/WebCore/dom/EventException.idl b/WebCore/dom/EventException.idl
index 3d82f85..c328dd8 100644
--- a/WebCore/dom/EventException.idl
+++ b/WebCore/dom/EventException.idl
@@ -37,6 +37,7 @@ module events {
readonly attribute unsigned short code;
readonly attribute DOMString name;
readonly attribute DOMString message;
+ readonly attribute DOMString description;
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
// Override in a Mozilla compatible format
diff --git a/WebCore/dom/RangeException.idl b/WebCore/dom/RangeException.idl
index d2cf385..b884b8c 100644
--- a/WebCore/dom/RangeException.idl
+++ b/WebCore/dom/RangeException.idl
@@ -26,6 +26,7 @@ module ranges {
readonly attribute unsigned short code;
readonly attribute DOMString name;
readonly attribute DOMString message;
+ readonly attribute DOMString description;
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
[DontEnum] DOMString toString();
diff --git a/WebCore/svg/SVGException.idl b/WebCore/svg/SVGException.idl
index 233f653..aaf4a69 100644
--- a/WebCore/svg/SVGException.idl
+++ b/WebCore/svg/SVGException.idl
@@ -28,6 +28,7 @@ module svg {
readonly attribute unsigned short code;
readonly attribute DOMString name;
readonly attribute DOMString message;
+ readonly attribute DOMString description;
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
// Override in a Mozilla compatible format
diff --git a/WebCore/xml/XMLHttpRequestException.idl b/WebCore/xml/XMLHttpRequestException.idl
index 380e426..66d5ec1 100644
--- a/WebCore/xml/XMLHttpRequestException.idl
+++ b/WebCore/xml/XMLHttpRequestException.idl
@@ -36,6 +36,7 @@ module xml {
readonly attribute unsigned short code;
readonly attribute DOMString name;
readonly attribute DOMString message;
+ readonly attribute DOMString description;
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
// Override in a Mozilla compatible format
diff --git a/WebCore/xml/XPathException.idl b/WebCore/xml/XPathException.idl
index c3c95e3..560f7cd 100644
--- a/WebCore/xml/XPathException.idl
+++ b/WebCore/xml/XPathException.idl
@@ -36,6 +36,7 @@ module xpath {
readonly attribute unsigned short code;
readonly attribute DOMString name;
readonly attribute DOMString message;
+ readonly attribute DOMString description;
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
// Override in a Mozilla compatible format
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list