[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75

benm at google.com benm at google.com
Thu Oct 29 20:50:36 UTC 2009


The following commit has been merged in the webkit-1.1 branch:
commit abebb0a26cb53ea6aae2f3e14722e883bc25fcfd
Author: benm at google.com <benm at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Oct 23 14:07:39 2009 +0000

    Fixes a leak in createThreadInternal on Android.
    https://bugs.webkit.org/show_bug.cgi?id=30698
    
    Patch by Steve Block <steveblock at google.com> on 2009-10-23
    Reviewed by Dmitry Titov.
    
    * wtf/ThreadingPthreads.cpp: Modified.
    (WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index a343865..b49793d 100644
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,13 @@
+2009-10-23  Steve Block  <steveblock at google.com>
+
+        Reviewed by Dmitry Titov.
+
+        Fixes a leak in createThreadInternal on Android.
+        https://bugs.webkit.org/show_bug.cgi?id=30698
+
+        * wtf/ThreadingPthreads.cpp: Modified.
+        (WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.
+
 2009-10-22  Geoffrey Garen  <ggaren at apple.com>
 
         Reviewed by Alexey Proskuryakov.
diff --git a/JavaScriptCore/wtf/ThreadingPthreads.cpp b/JavaScriptCore/wtf/ThreadingPthreads.cpp
index e4fb419..881455d 100644
--- a/JavaScriptCore/wtf/ThreadingPthreads.cpp
+++ b/JavaScriptCore/wtf/ThreadingPthreads.cpp
@@ -167,6 +167,7 @@ ThreadIdentifier createThreadInternal(ThreadFunction entryPoint, void* data, con
 
     if (pthread_create(&threadHandle, 0, runThreadWithRegistration, static_cast<void*>(threadData))) {
         LOG_ERROR("Failed to create pthread at entry point %p with data %p", entryPoint, data);
+        delete threadData;
         return 0;
     }
     return establishIdentifierForPthreadHandle(threadHandle);

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list