[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

[gramps]

The following commit has been merged in the debian/unstable branch:
commit fcf541ce966727064b2cf1b849d7c7b761d4e609
Author: gramps <gramps at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Sep 20 15:53:55 2001 +0000

    More QChar implementation and spelling fixes
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/kwq/KWQString.mm b/WebCore/kwq/KWQString.mm
index e01eada..0bcf4ef 100644
--- a/WebCore/kwq/KWQString.mm
+++ b/WebCore/kwq/KWQString.mm
@@ -25,6 +25,8 @@
 
 // FIXME: obviously many functions here can be made inline
 
+// FIXME: should QChar and QConstString be in separate source files?
+
 #include <qstring.h>
 
 // FIXME: what's the minimum capacity?
@@ -52,13 +54,11 @@ QChar::QChar()
 
 QChar::QChar(char ch)
 {
-    // FIXME: does this kind of conversion work?
     c = ch;
 }
 
 QChar::QChar(uchar uch)
 {
-    // FIXME: does this kind of conversion work?
     c = uch;
 }
 
@@ -94,92 +94,93 @@ QChar::~QChar()
 
 QChar QChar::lower() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return *this;
 }
 
 QChar QChar::upper() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return *this;
 }
 
 char QChar::latin1() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return 0;
 }
 
 bool QChar::isNull() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isDigit() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isSpace() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isLetter() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isLetterOrNumber() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isPunct() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 uchar QChar::cell() const
 {
-    // FIXME: unimplented
-    return 0;
+    // return least significant byte
+    return c & 0xff;
 }
 
 uchar QChar::row() const
 {
-    // FIXME: unimplented
-    return 0;
+    // return most significant byte
+    return (c & 0xff00) >> 8;
 }
 
 QChar::Direction QChar::direction() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented because we don't do BIDI yet
     return DirL;
 }
 
 bool QChar::mirrored() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented because we don't do BIDI yet
+    // return whether character should be reversed if text direction is reversed
     return FALSE;
 }
 
 QChar QChar::mirroredChar() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented because we don't do BIDI yet
+    // return mirrored character if it is mirrored else return itself
     return *this;
 }
 
 ushort QChar::unicode() const
 {
-    // FIXME: unimplented
-    return 0;
+    return c;
 }
 
 QString::QString()
diff --git a/WebCore/src/kwq/KWQString.mm b/WebCore/src/kwq/KWQString.mm
index e01eada..0bcf4ef 100644
--- a/WebCore/src/kwq/KWQString.mm
+++ b/WebCore/src/kwq/KWQString.mm
@@ -25,6 +25,8 @@
 
 // FIXME: obviously many functions here can be made inline
 
+// FIXME: should QChar and QConstString be in separate source files?
+
 #include <qstring.h>
 
 // FIXME: what's the minimum capacity?
@@ -52,13 +54,11 @@ QChar::QChar()
 
 QChar::QChar(char ch)
 {
-    // FIXME: does this kind of conversion work?
     c = ch;
 }
 
 QChar::QChar(uchar uch)
 {
-    // FIXME: does this kind of conversion work?
     c = uch;
 }
 
@@ -94,92 +94,93 @@ QChar::~QChar()
 
 QChar QChar::lower() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return *this;
 }
 
 QChar QChar::upper() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return *this;
 }
 
 char QChar::latin1() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return 0;
 }
 
 bool QChar::isNull() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isDigit() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isSpace() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isLetter() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isLetterOrNumber() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 bool QChar::isPunct() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented
     return FALSE;
 }
 
 uchar QChar::cell() const
 {
-    // FIXME: unimplented
-    return 0;
+    // return least significant byte
+    return c & 0xff;
 }
 
 uchar QChar::row() const
 {
-    // FIXME: unimplented
-    return 0;
+    // return most significant byte
+    return (c & 0xff00) >> 8;
 }
 
 QChar::Direction QChar::direction() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented because we don't do BIDI yet
     return DirL;
 }
 
 bool QChar::mirrored() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented because we don't do BIDI yet
+    // return whether character should be reversed if text direction is reversed
     return FALSE;
 }
 
 QChar QChar::mirroredChar() const
 {
-    // FIXME: unimplented
+    // FIXME: unimplemented because we don't do BIDI yet
+    // return mirrored character if it is mirrored else return itself
     return *this;
 }
 
 ushort QChar::unicode() const
 {
-    // FIXME: unimplented
-    return 0;
+    return c;
 }
 
 QString::QString()

-- 
WebKit Debian packaging