[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677
sullivan
sullivan at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:53:43 UTC 2009
The following commit has been merged in the debian/unstable branch:
commit 66557710f003d957942496521a00bf97a158b8e3
Author: sullivan <sullivan at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Aug 25 23:08:33 2003 +0000
- fixed 3391264 -- REGRESSION (Panther): Back/Forward buttons not
updating immediately after page load
The buttons are updated in response to window update notifications.
Jaguar was sending so many extra bogus notifications that it
masked the fact that we weren't ensuring that these notifications
were sent at all in the case of non-event-based interesting
changes that might affect menu items/toolbar items/etc.
Reviewed by Richard
* WebView.subproj/WebViewPrivate.m:
(-[WebView _didStartProvisionalLoadForFrame:]):
call -[NSApp setWindowsNeedUpdate:YES] so window update notices
will be sent
(-[WebView _didCommitLoadForFrame:]):
ditto
(-[WebView _didFinishLoadForFrame:]):
ditto
(-[WebView _didFailLoadWithError:forFrame:]):
ditto
(-[WebView _didFailProvisionalLoadWithError:forFrame:]):
ditto
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@4885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 2dbc4f6..320c4e4 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,29 @@
+2003-08-25 John Sullivan <sullivan at apple.com>
+
+ - fixed 3391264 -- REGRESSION (Panther): Back/Forward buttons not
+ updating immediately after page load
+
+ The buttons are updated in response to window update notifications.
+ Jaguar was sending so many extra bogus notifications that it
+ masked the fact that we weren't ensuring that these notifications
+ were sent at all in the case of non-event-based interesting
+ changes that might affect menu items/toolbar items/etc.
+
+ Reviewed by Richard
+
+ * WebView.subproj/WebViewPrivate.m:
+ (-[WebView _didStartProvisionalLoadForFrame:]):
+ call -[NSApp setWindowsNeedUpdate:YES] so window update notices
+ will be sent
+ (-[WebView _didCommitLoadForFrame:]):
+ ditto
+ (-[WebView _didFinishLoadForFrame:]):
+ ditto
+ (-[WebView _didFailLoadWithError:forFrame:]):
+ ditto
+ (-[WebView _didFailProvisionalLoadWithError:forFrame:]):
+ ditto
+
2003-08-24 Darin Adler <darin at apple.com>
Reviewed by John.
diff --git a/WebKit/WebView.subproj/WebViewPrivate.m b/WebKit/WebView.subproj/WebViewPrivate.m
index 6018d5a..8e25f21 100644
--- a/WebKit/WebView.subproj/WebViewPrivate.m
+++ b/WebKit/WebView.subproj/WebViewPrivate.m
@@ -821,12 +821,14 @@ NSString *_WebMainFrameURLKey = @"mainFrameURL";
[self _willChangeValueForKey: _WebIsLoadingKey];
[self _willChangeValueForKey: _WebMainFrameURLKey];
}
+ [NSApp setWindowsNeedUpdate:YES];
}
- (void)_didCommitLoadForFrame:(WebFrame *)frame
{
if (frame == [self mainFrame])
[self _didChangeValueForKey: _WebMainFrameURLKey];
+ [NSApp setWindowsNeedUpdate:YES];
}
- (void)_didFinishLoadForFrame:(WebFrame *)frame
@@ -834,6 +836,7 @@ NSString *_WebMainFrameURLKey = @"mainFrameURL";
[self _didChangeBackForwardKeys];
if (frame == [self mainFrame])
[self _didChangeValueForKey: _WebIsLoadingKey];
+ [NSApp setWindowsNeedUpdate:YES];
}
- (void)_didFailLoadWithError:(NSError *)error forFrame:(WebFrame *)frame
@@ -841,6 +844,7 @@ NSString *_WebMainFrameURLKey = @"mainFrameURL";
[self _didChangeBackForwardKeys];
if (frame == [self mainFrame])
[self _didChangeValueForKey: _WebIsLoadingKey];
+ [NSApp setWindowsNeedUpdate:YES];
}
- (void)_didFailProvisionalLoadWithError:(NSError *)error forFrame:(WebFrame *)frame
@@ -850,6 +854,7 @@ NSString *_WebMainFrameURLKey = @"mainFrameURL";
[self _didChangeValueForKey: _WebIsLoadingKey];
[self _didChangeValueForKey: _WebMainFrameURLKey];
}
+ [NSApp setWindowsNeedUpdate:YES];
}
@end
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list