[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

zoltan at webkit.org zoltan at webkit.org
Wed Apr 7 23:30:57 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit 5ecf980abffd0bc86aa1a561f47e1cc6d712b16f
Author: zoltan at webkit.org <zoltan at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Nov 11 17:06:13 2009 +0000

    Allow custom memory allocation control for the part of page directory in WebCore
    https://bugs.webkit.org/show_bug.cgi?id=31350
    
    Reviewed by Eric Seidel.
    
    Inherits the following classes from Noncopyable because these are instantiated
    by 'new' and these are no need to be copyable:
    
    class DragController         - instantiated at: WebCore/page/Page.cpp:107
    class FocusController        - instantiated at: WebCore/page/Page.cpp:109
    class Settings               - instantiated at: WebCore/page/Page.cpp:116
    class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
    struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
    class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
    struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
    class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
    class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
    
    Inherits PropertyWrapperBase class from Noncopyable because (its child class)
    PropertyWrapper is instantiated by 'new' in
    WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
    
    * page/DragController.h:
    * page/EventHandler.h:
    * page/FocusController.h:
    * page/FrameView.cpp:
    * page/PluginHalter.h:
    * page/Settings.h:
    * page/UserScript.h:
    * page/UserStyleSheet.h:
    * page/XSSAuditor.h:
    * page/animation/AnimationBase.cpp:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 26caf27..af17d67 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,38 @@
+2009-11-11  Zoltan Horvath  <zoltan at webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Allow custom memory allocation control for the part of page directory in WebCore
+        https://bugs.webkit.org/show_bug.cgi?id=31350
+
+        Inherits the following classes from Noncopyable because these are instantiated
+        by 'new' and these are no need to be copyable:
+
+        class DragController         - instantiated at: WebCore/page/Page.cpp:107
+        class FocusController        - instantiated at: WebCore/page/Page.cpp:109
+        class Settings               - instantiated at: WebCore/page/Page.cpp:116
+        class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
+        struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
+        class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
+        struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
+        class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
+        class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
+
+        Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
+        PropertyWrapper is instantiated by 'new' in 
+        WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
+
+        * page/DragController.h:
+        * page/EventHandler.h:
+        * page/FocusController.h:
+        * page/FrameView.cpp:
+        * page/PluginHalter.h:
+        * page/Settings.h:
+        * page/UserScript.h:
+        * page/UserStyleSheet.h:
+        * page/XSSAuditor.h:
+        * page/animation/AnimationBase.cpp:
+
 2009-11-11  Laszlo Gombos  <laszlo.1.gombos at nokia.com>
 
         Reviewed by Kenneth Rohde Christiansen.
diff --git a/WebCore/page/DragController.h b/WebCore/page/DragController.h
index 9472589..3d59ebf 100644
--- a/WebCore/page/DragController.h
+++ b/WebCore/page/DragController.h
@@ -47,7 +47,7 @@ namespace WebCore {
     class Range;
     class SelectionController;
     
-    class DragController {
+    class DragController : public Noncopyable {
     public:
         DragController(Page*, DragClient*);
         ~DragController();
diff --git a/WebCore/page/EventHandler.h b/WebCore/page/EventHandler.h
index fe87a1a..6cd0eab 100644
--- a/WebCore/page/EventHandler.h
+++ b/WebCore/page/EventHandler.h
@@ -199,7 +199,7 @@ private:
         PerformDragAndDrop
     };
 
-    struct EventHandlerDragState {
+    struct EventHandlerDragState : Noncopyable {
         RefPtr<Node> m_dragSrc; // element that may be a drag source, for the current mouse gesture
         bool m_dragSrcIsLink;
         bool m_dragSrcIsImage;
diff --git a/WebCore/page/FocusController.h b/WebCore/page/FocusController.h
index 33debf1..d86408a 100644
--- a/WebCore/page/FocusController.h
+++ b/WebCore/page/FocusController.h
@@ -28,6 +28,7 @@
 
 #include "FocusDirection.h"
 #include <wtf/Forward.h>
+#include <wtf/Noncopyable.h>
 #include <wtf/RefPtr.h>
 
 namespace WebCore {
@@ -37,7 +38,7 @@ namespace WebCore {
     class Node;
     class Page;
 
-    class FocusController {
+    class FocusController : public Noncopyable {
     public:
         FocusController(Page*);
 
diff --git a/WebCore/page/FrameView.cpp b/WebCore/page/FrameView.cpp
index e854de0..e2ac4b1 100644
--- a/WebCore/page/FrameView.cpp
+++ b/WebCore/page/FrameView.cpp
@@ -98,7 +98,7 @@ static const double deferredRepaintDelayIncrementDuringLoading = 0;
 // The maximum number of updateWidgets iterations that should be done before returning.
 static const unsigned maxUpdateWidgetsIterations = 2;
 
-struct ScheduledEvent {
+struct ScheduledEvent : Noncopyable {
     RefPtr<Event> m_event;
     RefPtr<Node> m_eventTarget;
 };
diff --git a/WebCore/page/PluginHalter.h b/WebCore/page/PluginHalter.h
index eddce34..af8b31e 100644
--- a/WebCore/page/PluginHalter.h
+++ b/WebCore/page/PluginHalter.h
@@ -35,7 +35,7 @@ namespace WebCore {
 
 class HaltablePlugin;
 
-class PluginHalter {
+class PluginHalter : public Noncopyable {
 public:
     PluginHalter(PluginHalterClient*);
 
diff --git a/WebCore/page/Settings.h b/WebCore/page/Settings.h
index fcc914a..9cb4362 100644
--- a/WebCore/page/Settings.h
+++ b/WebCore/page/Settings.h
@@ -64,7 +64,7 @@ namespace WebCore {
     // if possible in the future.
     enum EditingBehavior { EditingMacBehavior, EditingWindowsBehavior };
 
-    class Settings {
+    class Settings : public Noncopyable {
     public:
         Settings(Page*);
 
diff --git a/WebCore/page/UserScript.h b/WebCore/page/UserScript.h
index dbbb879..57a0c5d 100644
--- a/WebCore/page/UserScript.h
+++ b/WebCore/page/UserScript.h
@@ -34,7 +34,7 @@
 
 namespace WebCore {
 
-class UserScript {
+class UserScript : public Noncopyable {
 public:
     UserScript(const String& source, const KURL& url,
                PassOwnPtr<Vector<String> > whitelist, PassOwnPtr<Vector<String> > blacklist,
diff --git a/WebCore/page/UserStyleSheet.h b/WebCore/page/UserStyleSheet.h
index 56bec40..2f51ed4 100644
--- a/WebCore/page/UserStyleSheet.h
+++ b/WebCore/page/UserStyleSheet.h
@@ -34,7 +34,7 @@
 
 namespace WebCore {
 
-class UserStyleSheet {
+class UserStyleSheet : public Noncopyable {
 public:
     UserStyleSheet(const String& source, const KURL& url,
                    PassOwnPtr<Vector<String> > whitelist, PassOwnPtr<Vector<String> > blacklist,
diff --git a/WebCore/page/XSSAuditor.h b/WebCore/page/XSSAuditor.h
index 9cff790..4436f2e 100644
--- a/WebCore/page/XSSAuditor.h
+++ b/WebCore/page/XSSAuditor.h
@@ -63,7 +63,7 @@ namespace WebCore {
     // * ScriptController::createInlineEventListener - used to create JavaScript event handlers.
     // * HTMLTokenizer::scriptHandler - used to load external JavaScript scripts.
     //
-    class XSSAuditor {
+    class XSSAuditor : public Noncopyable {
     public:
         XSSAuditor(Frame*);
         ~XSSAuditor();
diff --git a/WebCore/page/animation/AnimationBase.cpp b/WebCore/page/animation/AnimationBase.cpp
index 59797da..f1ee750 100644
--- a/WebCore/page/animation/AnimationBase.cpp
+++ b/WebCore/page/animation/AnimationBase.cpp
@@ -190,7 +190,7 @@ class PropertyWrapperBase;
 static void addShorthandProperties();
 static PropertyWrapperBase* wrapperForProperty(int propertyID);
 
-class PropertyWrapperBase {
+class PropertyWrapperBase : public Noncopyable {
 public:
     PropertyWrapperBase(int prop)
         : m_prop(prop)

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list