[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373
eric at webkit.org
eric at webkit.org
Wed Apr 7 23:34:02 UTC 2010
The following commit has been merged in the webkit-1.2 branch:
commit ce7dc593b6a99cb68eb0469bbee858aabc0b4c25
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Nov 12 17:08:01 2009 +0000
2009-11-12 Patrick Mueller <Patrick_Mueller at us.ibm.com>
Reviewed by Timothy Hatcher.
Web Inspector: breakpoint sidebar entries should allow click over entire list item
https://bugs.webkit.org/show_bug.cgi?id=31411
No new tests; no new functionality, small usability change.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
(WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 215dffd..3d6ef45 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -2,6 +2,19 @@
Reviewed by Timothy Hatcher.
+ Web Inspector: breakpoint sidebar entries should allow click over entire list item
+ https://bugs.webkit.org/show_bug.cgi?id=31411
+
+ No new tests; no new functionality, small usability change.
+
+ * inspector/front-end/BreakpointsSidebarPane.js:
+ (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
+ (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
+
+2009-11-12 Patrick Mueller <Patrick_Mueller at us.ibm.com>
+
+ Reviewed by Timothy Hatcher.
+
Web Inspector: breakpoints in named evals are not restored after a reload
https://bugs.webkit.org/show_bug.cgi?id=31375
diff --git a/WebCore/inspector/front-end/BreakpointsSidebarPane.js b/WebCore/inspector/front-end/BreakpointsSidebarPane.js
index e6edece..1a99f16 100644
--- a/WebCore/inspector/front-end/BreakpointsSidebarPane.js
+++ b/WebCore/inspector/front-end/BreakpointsSidebarPane.js
@@ -67,12 +67,15 @@ WebInspector.BreakpointsSidebarPane.prototype = {
_appendBreakpointElement: function(breakpoint)
{
- function checkboxClicked()
+ function checkboxClicked(event)
{
breakpoint.enabled = !breakpoint.enabled;
+
+ // without this, we'd switch to the source of the clicked breakpoint
+ event.stopPropagation();
}
- function labelClicked()
+ function breakpointClicked()
{
var script = WebInspector.panels.scripts.scriptOrResourceForID(breakpoint.sourceID);
if (script)
@@ -82,6 +85,7 @@ WebInspector.BreakpointsSidebarPane.prototype = {
var breakpointElement = document.createElement("li");
breakpoint._breakpointListElement = breakpointElement;
breakpointElement._breakpointObject = breakpoint;
+ breakpointElement.addEventListener("click", breakpointClicked, false);
var checkboxElement = document.createElement("input");
checkboxElement.className = "checkbox-elem";
@@ -90,9 +94,7 @@ WebInspector.BreakpointsSidebarPane.prototype = {
checkboxElement.addEventListener("click", checkboxClicked, false);
breakpointElement.appendChild(checkboxElement);
- var labelElement = document.createElement("a");
- labelElement.textContent = breakpoint.label;
- labelElement.addEventListener("click", labelClicked, false);
+ var labelElement = document.createTextNode(breakpoint.label);
breakpointElement.appendChild(labelElement);
var sourceTextElement = document.createElement("div");
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list