[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

jhoneycutt at apple.com jhoneycutt at apple.com
Wed Apr 7 23:45:42 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit 691c348e0a4edb46601ff7ff8c3f7bd8eab640b9
Author: jhoneycutt at apple.com <jhoneycutt at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Nov 17 23:37:24 2009 +0000

    DOMHTMLInputElement::rectOnScreen() returns the wrong rect
    
    https://bugs.webkit.org/show_bug.cgi?id=31487
    
    Reviewed by Darin Adler.
    
    * DOMHTMLClasses.cpp:
    (DOMHTMLInputElement::rectOnScreen):
    Return the rect on screen, not the rect in the window.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/win/ChangeLog b/WebKit/win/ChangeLog
index f57b2f7..684bf07 100644
--- a/WebKit/win/ChangeLog
+++ b/WebKit/win/ChangeLog
@@ -1,3 +1,15 @@
+2009-11-12  Jon Honeycutt  <jhoneycutt at apple.com>
+
+        DOMHTMLInputElement::rectOnScreen() returns the wrong rect
+
+        https://bugs.webkit.org/show_bug.cgi?id=31487
+
+        Reviewed by Darin Adler.
+
+        * DOMHTMLClasses.cpp:
+        (DOMHTMLInputElement::rectOnScreen):
+        Return the rect on screen, not the rect in the window.
+
 2009-11-17  Brent Fulgham  <bfulgham at webkit.org>
 
         Reviewed by NOBODY - Build Fix.
diff --git a/WebKit/win/DOMHTMLClasses.cpp b/WebKit/win/DOMHTMLClasses.cpp
index 9ce6004..11ee323 100644
--- a/WebKit/win/DOMHTMLClasses.cpp
+++ b/WebKit/win/DOMHTMLClasses.cpp
@@ -1231,12 +1231,12 @@ HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::rectOnScreen(
     if (!renderer || !view)
         return E_FAIL;
 
-    IntRect coreRect = renderer->absoluteBoundingBoxRect();
-    coreRect.setLocation(view->contentsToWindow(coreRect.location()));
+    IntRect coreRect = view->contentsToScreen(renderer->absoluteBoundingBoxRect());
     rect->left = coreRect.x();
     rect->top = coreRect.y();
     rect->right = coreRect.right();
     rect->bottom = coreRect.bottom();
+
     return S_OK;
 }
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list