[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

[eric at webkit.org]

The following commit has been merged in the webkit-1.2 branch:
commit c5b46572c1918527d1804ca375cb270a2d5e41e8
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Nov 19 23:38:24 2009 +0000

    2009-11-19  Eric Seidel  <eric at webkit.org>
    
            No review, just adding a FIXME.
    
            Split out command parsing and help printing from BugzillaTool
            https://bugs.webkit.org/show_bug.cgi?id=31688
    
            * Scripts/bugzilla-tool: Add an extra comment about current design failures.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index e52f1dc..77eb3c1 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,5 +1,14 @@
 2009-11-19  Eric Seidel  <eric at webkit.org>
 
+        No review, just adding a FIXME.
+
+        Split out command parsing and help printing from BugzillaTool
+        https://bugs.webkit.org/show_bug.cgi?id=31688
+
+        * Scripts/bugzilla-tool: Add an extra comment about current design failures.
+
+2009-11-19  Eric Seidel  <eric at webkit.org>
+
         Reviewed by Adam Barth.
 
         Split out command parsing and help printing from BugzillaTool
diff --git a/WebKitTools/Scripts/bugzilla-tool b/WebKitTools/Scripts/bugzilla-tool
index 511cf89..3bbbc95 100755
--- a/WebKitTools/Scripts/bugzilla-tool
+++ b/WebKitTools/Scripts/bugzilla-tool
@@ -856,6 +856,9 @@ class HelpPrintingOptionParser(OptionParser):
 class MultiCommandTool:
     def __init__(self, commands):
         self.commands = commands
+        # FIXME: Calling self._commands_usage() in the constructor is bad because
+        # it calls self.should_show_command_help which is subclass-defined.
+        # The subclass will not be fully initialized at this point.
         self.global_option_parser = HelpPrintingOptionParser(usage=self._usage_line(), formatter=NonWrappingEpilogIndentedHelpFormatter(), epilog=self._commands_usage())
 
     @staticmethod

-- 
WebKit Debian packaging