[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

[eric at webkit.org]

The following commit has been merged in the webkit-1.2 branch:
commit 61febd824d8c6ec8e84f688385ef0c168ee4c28f
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Nov 20 19:22:46 2009 +0000

    2009-11-20  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Eric Seidel.
    
            Implement a build-queue
            https://bugs.webkit.org/show_bug.cgi?id=31725
    
            Currently this just builds the first 10 patches in the review queue.
            We'll want to do something smarter soon.
    
            * Scripts/bugzilla-tool:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index bf7e513..dafa75e 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -2,6 +2,18 @@
 
         Reviewed by Eric Seidel.
 
+        Implement a build-queue
+        https://bugs.webkit.org/show_bug.cgi?id=31725
+
+        Currently this just builds the first 10 patches in the review queue.
+        We'll want to do something smarter soon.
+
+        * Scripts/bugzilla-tool:
+
+2009-11-20  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by Eric Seidel.
+
         Make commit-queue and style-queue show up in help
         https://bugs.webkit.org/show_bug.cgi?id=31724
 
diff --git a/WebKitTools/Scripts/bugzilla-tool b/WebKitTools/Scripts/bugzilla-tool
index 6d8bfef..529af8f 100755
--- a/WebKitTools/Scripts/bugzilla-tool
+++ b/WebKitTools/Scripts/bugzilla-tool
@@ -717,8 +717,7 @@ class CommitQueue(AbstractQueue):
         self.tool.bugs.reject_patch_from_commit_queue(patch["id"], message)
 
 
-class StyleQueue(AbstractQueue):
-    name = "style-queue"
+class AbstractTryQueue(AbstractQueue):
     def __init__(self):
         AbstractQueue.__init__(self)
 
@@ -735,15 +734,40 @@ class StyleQueue(AbstractQueue):
         return self._patches.next()
 
     def should_proceed_with_work_item(self, patch):
-        return (True, "Checking style for patch %s on bug %s." % (patch["id"], patch["bug_id"]), patch["bug_id"])
+        raise NotImplementedError, "subclasses must implement"
 
     def process_work_item(self, patch):
-        self.run_bugzilla_tool(["check-style", "--force-clean", patch["id"]])
+        raise NotImplementedError, "subclasses must implement"
 
     def handle_unexpected_error(self, patch, message):
         log(message)
 
 
+class StyleQueue(AbstractTryQueue):
+    name = "style-queue"
+    def __init__(self):
+        AbstractTryQueue.__init__(self)
+
+    def should_proceed_with_work_item(self, patch):
+        return (True, "Checking style for patch %s on bug %s." % (patch["id"], patch["bug_id"]), patch["bug_id"])
+
+    def process_work_item(self, patch):
+        self.run_bugzilla_tool(["check-style", "--force-clean", patch["id"]])
+
+
+class BuildQueue(AbstractTryQueue):
+    name = "build-queue"
+    def __init__(self):
+        AbstractTryQueue.__init__(self)
+
+    def should_proceed_with_work_item(self, patch):
+        # FIXME: We should check whether we're currently able to build!
+        return (True, "Building patch %s on bug %s." % (patch["id"], patch["bug_id"]), patch["bug_id"])
+
+    def process_work_item(self, patch):
+        self.run_bugzilla_tool(["build-attachment", "--force-clean", patch["id"]])
+
+
 class BugzillaTool(MultiCommandTool):
     def __init__(self):
         # HACK: Set self.cached_scm before calling MultiCommandTool.__init__ because

-- 
WebKit Debian packaging