[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373
bweinstein at apple.com
bweinstein at apple.com
Thu Apr 8 00:37:36 UTC 2010
The following commit has been merged in the webkit-1.2 branch:
commit 58b67471e4d7dfc912261989fe727b3837788946
Author: bweinstein at apple.com <bweinstein at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Dec 15 21:52:40 2009 +0000
Fixes <https://bugs.webkit.org/show_bug.cgi?id=18498>.
REGRESSION: Tips are not shown for resources anymore.
Reviewed by Timothy Hatcher.
As discussed in the bug, Tips are not coming back, and the feature
will be moved to the audits panel. This patch is to remove the Tips
code and the resources that it needed.
* WebCore.gypi: Removed tips files.
* inspector/front-end/Images/tipBalloon.png: Removed.
* inspector/front-end/Images/tipBalloonBottom.png: Removed.
* inspector/front-end/Images/tipIcon.png: Removed.
* inspector/front-end/Images/tipIconPressed.png: Removed.
* inspector/front-end/Resource.js: Removed tips code.
(WebInspector.Resource.prototype.set finished):
* inspector/front-end/WebKit.qrc: Removed tips files.
* inspector/front-end/inspector.css: Removes tips style rules.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 0080a8f..2a15f6d 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,24 @@
+2009-12-15 Brian Weinstein <bweinstein at apple.com>
+
+ Reviewed by Timothy Hatcher.
+
+ Fixes <https://bugs.webkit.org/show_bug.cgi?id=18498>.
+ REGRESSION: Tips are not shown for resources anymore.
+
+ As discussed in the bug, Tips are not coming back, and the feature
+ will be moved to the audits panel. This patch is to remove the Tips
+ code and the resources that it needed.
+
+ * WebCore.gypi: Removed tips files.
+ * inspector/front-end/Images/tipBalloon.png: Removed.
+ * inspector/front-end/Images/tipBalloonBottom.png: Removed.
+ * inspector/front-end/Images/tipIcon.png: Removed.
+ * inspector/front-end/Images/tipIconPressed.png: Removed.
+ * inspector/front-end/Resource.js: Removed tips code.
+ (WebInspector.Resource.prototype.set finished):
+ * inspector/front-end/WebKit.qrc: Removed tips files.
+ * inspector/front-end/inspector.css: Removes tips style rules.
+
2009-12-15 Pavel Feldman <pfeldman at chromium.org>
Reviewed by Timothy Hatcher.
diff --git a/WebCore/WebCore.gypi b/WebCore/WebCore.gypi
index 6bcfff8..295b4fd 100644
--- a/WebCore/WebCore.gypi
+++ b/WebCore/WebCore.gypi
@@ -3842,10 +3842,6 @@
'inspector/front-end/Images/timelinePillPurple.png',
'inspector/front-end/Images/timelinePillRed.png',
'inspector/front-end/Images/timelinePillYellow.png',
- 'inspector/front-end/Images/tipBalloon.png',
- 'inspector/front-end/Images/tipBalloonBottom.png',
- 'inspector/front-end/Images/tipIcon.png',
- 'inspector/front-end/Images/tipIconPressed.png',
'inspector/front-end/Images/toolbarItemSelected.png',
'inspector/front-end/Images/treeDownTriangleBlack.png',
'inspector/front-end/Images/treeDownTriangleWhite.png',
diff --git a/WebCore/inspector/front-end/Images/tipBalloon.png b/WebCore/inspector/front-end/Images/tipBalloon.png
deleted file mode 100644
index 4cdf738..0000000
Binary files a/WebCore/inspector/front-end/Images/tipBalloon.png and /dev/null differ
diff --git a/WebCore/inspector/front-end/Images/tipBalloonBottom.png b/WebCore/inspector/front-end/Images/tipBalloonBottom.png
deleted file mode 100644
index 3317a5a..0000000
Binary files a/WebCore/inspector/front-end/Images/tipBalloonBottom.png and /dev/null differ
diff --git a/WebCore/inspector/front-end/Images/tipIcon.png b/WebCore/inspector/front-end/Images/tipIcon.png
deleted file mode 100644
index 8ca6124..0000000
Binary files a/WebCore/inspector/front-end/Images/tipIcon.png and /dev/null differ
diff --git a/WebCore/inspector/front-end/Images/tipIconPressed.png b/WebCore/inspector/front-end/Images/tipIconPressed.png
deleted file mode 100644
index 443e410..0000000
Binary files a/WebCore/inspector/front-end/Images/tipIconPressed.png and /dev/null differ
diff --git a/WebCore/inspector/front-end/Resource.js b/WebCore/inspector/front-end/Resource.js
index d23b5da..ce1ef95 100644
--- a/WebCore/inspector/front-end/Resource.js
+++ b/WebCore/inspector/front-end/Resource.js
@@ -323,7 +323,6 @@ WebInspector.Resource.prototype = {
this._finished = x;
if (x) {
- this._checkTips();
this._checkWarnings();
this.dispatchEventToListeners("finished");
}
@@ -539,58 +538,6 @@ WebInspector.Resource.prototype = {
this._warnings = x;
},
- get tips()
- {
- if (!("_tips" in this))
- this._tips = {};
- return this._tips;
- },
-
- _addTip: function(tip)
- {
- if (tip.id in this.tips)
- return;
-
- this.tips[tip.id] = tip;
-
- // FIXME: Re-enable this code once we have a scope bar in the Console.
- // Otherwise, we flood the Console with too many tips.
- /*
- var msg = new WebInspector.ConsoleMessage(WebInspector.ConsoleMessage.MessageSource.Other,
- WebInspector.ConsoleMessage.MessageType.Log, WebInspector.ConsoleMessage.MessageLevel.Tip,
- -1, this.url, null, 1, tip.message);
- WebInspector.console.addMessage(msg);
- */
- },
-
- _checkTips: function()
- {
- for (var tip in WebInspector.Tips)
- this._checkTip(WebInspector.Tips[tip]);
- },
-
- _checkTip: function(tip)
- {
- var addTip = false;
- switch (tip.id) {
- case WebInspector.Tips.ResourceNotCompressed.id:
- addTip = this._shouldCompress();
- break;
- }
-
- if (addTip)
- this._addTip(tip);
- },
-
- _shouldCompress: function()
- {
- return WebInspector.Resource.Type.isTextType(this.type)
- && this.domain
- && !("Content-Encoding" in this.responseHeaders)
- && this.contentLength !== undefined
- && this.contentLength >= 512;
- },
-
_mimeTypeIsConsistentWithType: function()
{
if (typeof this.type === "undefined"
diff --git a/WebCore/inspector/front-end/WebKit.qrc b/WebCore/inspector/front-end/WebKit.qrc
index 1bb2894..505861b 100644
--- a/WebCore/inspector/front-end/WebKit.qrc
+++ b/WebCore/inspector/front-end/WebKit.qrc
@@ -192,10 +192,6 @@
<file>Images/timelinePillPurple.png</file>
<file>Images/timelinePillRed.png</file>
<file>Images/timelinePillYellow.png</file>
- <file>Images/tipBalloon.png</file>
- <file>Images/tipBalloonBottom.png</file>
- <file>Images/tipIcon.png</file>
- <file>Images/tipIconPressed.png</file>
<file>Images/toolbarItemSelected.png</file>
<file>Images/treeDownTriangleBlack.png</file>
<file>Images/treeDownTriangleWhite.png</file>
diff --git a/WebCore/inspector/front-end/inspector.css b/WebCore/inspector/front-end/inspector.css
index 67f8eb2..c2862ae 100644
--- a/WebCore/inspector/front-end/inspector.css
+++ b/WebCore/inspector/front-end/inspector.css
@@ -2810,51 +2810,6 @@ button.enable-toggle-status-bar-item.toggled-on .glyph {
-webkit-border-image: url(Images/timelineHollowPillYellow.png) 6 7 6 7;
}
-.tip-button {
- background-image: url(Images/tipIcon.png);
- border: none;
- width: 16px;
- height: 16px;
- float: right;
- background-color: transparent;
- margin-top: 1px;
-}
-
-.tip-button:active {
- background-image: url(Images/tipIconPressed.png);
-}
-
-.tip-balloon {
- position: absolute;
- left: 145px;
- top: -5px;
- z-index: 1000;
- border-width: 51px 15px 18px 37px;
- -webkit-border-image: url(Images/tipBalloon.png) 51 15 18 37;
- width: 265px;
-}
-
-.tip-balloon.bottom {
- position: absolute;
- left: 145px;
- top: auto;
- bottom: -7px;
- z-index: 1000;
- border-width: 18px 15px 51px 37px;
- -webkit-border-image: url(Images/tipBalloonBottom.png) 18 15 51 37;
-}
-
-.tip-balloon-content {
- margin-top: -40px;
- margin-bottom: -2px;
- margin-left: 2px;
-}
-
-.tip-balloon.bottom .tip-balloon-content {
- margin-top: -10px;
- margin-bottom: -35px;
-}
-
#resource-views {
position: absolute;
top: 23px;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list