[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

eric at webkit.org eric at webkit.org
Thu Apr 8 00:42:49 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit bbceb8b8befe5a36b3dcfb9d2cf3be2faffdfe5e
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Dec 18 21:45:53 2009 +0000

    2009-12-18  Eric Seidel  <eric at webkit.org>
    
            Reviewed by David Levin.
    
            move bugzilla.py off of urllib2
            https://bugs.webkit.org/show_bug.cgi?id=32729
    
            * Scripts/modules/bugzilla.py: use mechanize for all url fetching.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index f837847..47dcf1e 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,12 @@
+2009-12-18  Eric Seidel  <eric at webkit.org>
+
+        Reviewed by David Levin.
+
+        move bugzilla.py off of urllib2
+        https://bugs.webkit.org/show_bug.cgi?id=32729
+
+        * Scripts/modules/bugzilla.py: use mechanize for all url fetching.
+
 2009-12-18  Gustavo Noronha Silva  <gustavo.noronha at collabora.co.uk>
 
         Rubber-stamped by Xan Lopez.
diff --git a/WebKitTools/Scripts/modules/bugzilla.py b/WebKitTools/Scripts/modules/bugzilla.py
index b306483..e5dd613 100644
--- a/WebKitTools/Scripts/modules/bugzilla.py
+++ b/WebKitTools/Scripts/modules/bugzilla.py
@@ -31,7 +31,6 @@
 
 import re
 import subprocess
-import urllib2
 
 from datetime import datetime # used in timestamp()
 
@@ -117,7 +116,7 @@ class Bugzilla(object):
         bug_url = self.bug_url_for_bug_id(bug_id, xml=True)
         log("Fetching: %s" % bug_url)
 
-        page = urllib2.urlopen(bug_url)
+        page = self.browser.open(bug_url)
         soup = BeautifulSoup(page)
 
         attachments = []
@@ -136,7 +135,7 @@ class Bugzilla(object):
     def bug_id_for_attachment_id(self, attachment_id):
         attachment_url = self.attachment_url_for_id(attachment_id, 'edit')
         log("Fetching: %s" % attachment_url)
-        page = urllib2.urlopen(attachment_url)
+        page = self.browser.open(attachment_url)
         return self._parse_bug_id_from_attachment_page(page)
 
     # This should really return an Attachment object
@@ -158,7 +157,7 @@ class Bugzilla(object):
 
     def fetch_title_from_bug(self, bug_id):
         bug_url = self.bug_url_for_bug_id(bug_id, xml=True)
-        page = urllib2.urlopen(bug_url)
+        page = self.browser.open(bug_url)
         soup = BeautifulSoup(page)
         return soup.find('short_desc').string
 
@@ -232,7 +231,7 @@ class Bugzilla(object):
         return commit_queue_patches
 
     def _fetch_bug_ids_advanced_query(self, query):
-        page = urllib2.urlopen(query)
+        page = self.browser.open(query)
         soup = BeautifulSoup(page)
 
         bug_ids = []
@@ -250,7 +249,7 @@ class Bugzilla(object):
         return [int(digits.search(tag["href"]).group(0)) for tag in BeautifulSoup(page, parseOnlyThese=attachment_links)]
 
     def _fetch_attachment_ids_request_query(self, query):
-        return self._parse_attachment_ids_request_query(urllib2.urlopen(query))
+        return self._parse_attachment_ids_request_query(self.browser.open(query))
 
     def fetch_bug_ids_from_commit_queue(self):
         commit_queue_url = self.bug_server_url + "buglist.cgi?query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=commit-queue%2B"

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list