[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

abarth at webkit.org abarth at webkit.org
Thu Apr 8 00:43:23 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit d5e4fa5ff609cd2fe5a59078ae50355a8b0331f5
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Dec 19 06:05:14 2009 +0000

    2009-12-18  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Eric Seidel.
    
            Add watches for EWS
            https://bugs.webkit.org/show_bug.cgi?id=32767
    
            dglazkov wanted to be added.
    
            * Scripts/modules/bugzilla.py:
            * Scripts/modules/commands/early_warning_system.py:
            * Scripts/modules/commands/queues.py:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 47dcf1e..24fc2c1 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,16 @@
+2009-12-18  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Add watches for EWS
+        https://bugs.webkit.org/show_bug.cgi?id=32767
+
+        dglazkov wanted to be added.
+
+        * Scripts/modules/bugzilla.py:
+        * Scripts/modules/commands/early_warning_system.py:
+        * Scripts/modules/commands/queues.py:
+
 2009-12-18  Eric Seidel  <eric at webkit.org>
 
         Reviewed by David Levin.
diff --git a/WebKitTools/Scripts/modules/bugzilla.py b/WebKitTools/Scripts/modules/bugzilla.py
index e5dd613..f72ee34 100644
--- a/WebKitTools/Scripts/modules/bugzilla.py
+++ b/WebKitTools/Scripts/modules/bugzilla.py
@@ -466,7 +466,7 @@ class Bugzilla(object):
             self.browser.set_value(comment_text, name='comment', nr=0)
         self.browser.submit()
 
-    def add_cc_to_bug(self, bug_id, email_address):
+    def add_cc_to_bug(self, bug_id, email_address_list):
         self.authenticate()
 
         log("Adding %s to the CC list for bug %s" % (email_address, bug_id))
@@ -475,7 +475,7 @@ class Bugzilla(object):
 
         self.browser.open(self.bug_url_for_bug_id(bug_id))
         self.browser.select_form(name="changeform")
-        self.browser["newcc"] = email_address
+        self.browser["newcc"] = email_address_list.join(", ")
         self.browser.submit()
 
     def post_comment_to_bug(self, bug_id, comment_text, cc=None):
@@ -490,7 +490,7 @@ class Bugzilla(object):
         self.browser.select_form(name="changeform")
         self.browser["comment"] = comment_text
         if cc:
-            self.browser["newcc"] = cc
+            self.browser["newcc"] = cc.join(", ")
         self.browser.submit()
 
     def close_bug_as_fixed(self, bug_id, comment_text=None):
diff --git a/WebKitTools/Scripts/modules/commands/early_warning_system.py b/WebKitTools/Scripts/modules/commands/early_warning_system.py
index c62bc56..3e9d2c7 100644
--- a/WebKitTools/Scripts/modules/commands/early_warning_system.py
+++ b/WebKitTools/Scripts/modules/commands/early_warning_system.py
@@ -88,3 +88,6 @@ class QtEWS(AbstractEarlyWarningSystem):
 class ChromiumEWS(AbstractEarlyWarningSystem):
     name = "chromium-ews"
     port_name = "chromium"
+    watchers = AbstractEarlyWarningSystem.watchers + [
+        "dglazkov at chromium.org",
+    ]
diff --git a/WebKitTools/Scripts/modules/commands/queues.py b/WebKitTools/Scripts/modules/commands/queues.py
index f8fef96..ebf06e6 100644
--- a/WebKitTools/Scripts/modules/commands/queues.py
+++ b/WebKitTools/Scripts/modules/commands/queues.py
@@ -44,7 +44,9 @@ from modules.stepsequence import StepSequenceErrorHandler
 from modules.workqueue import WorkQueue, WorkQueueDelegate
 
 class AbstractQueue(Command, WorkQueueDelegate):
-    watchers = "webkit-bot-watchers at googlegroups.com"
+    watchers = [
+        "webkit-bot-watchers at googlegroups.com",
+    ]
     def __init__(self, options=None): # Default values should never be collections (like []) as default values are shared between invocations
         options_list = (options or []) + [
             make_option("--no-confirm", action="store_false", dest="confirm", default=True, help="Do not ask the user for confirmation before running the queue.  Dangerous!"),

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list