[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

eric at webkit.org eric at webkit.org
Thu Apr 8 00:56:57 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit 75e0bd0645eceb03a8c97e49156bb93a1ce7208d
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Jan 7 10:52:04 2010 +0000

    2010-01-07  Kent Tamura  <tkent at chromium.org>
    
            Reviewed by Adam Barth.
    
            Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
            WebKitCSSTransformValue.idl correctly.
            https://bugs.webkit.org/show_bug.cgi?id=33193
    
            CodeGeneratorV8.pm doesn't handle inheritance very well and it
            tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
            which does not exist. Because WebKitCSSTransformValue inherits
            CSSValueList and CSSValueList already has HadIndexGetter, we don't
            need to do anything for WebKitCSSTransformValue about HasIndexGetter.
    
            * bindings/scripts/CodeGeneratorV8.pm:
              Reset $hasGetter for WebKitCSSTransformValue.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 02f3e1a..7f4ca09 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2010-01-07  Kent Tamura  <tkent at chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
+        WebKitCSSTransformValue.idl correctly.
+        https://bugs.webkit.org/show_bug.cgi?id=33193
+
+        CodeGeneratorV8.pm doesn't handle inheritance very well and it
+        tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
+        which does not exist. Because WebKitCSSTransformValue inherits
+        CSSValueList and CSSValueList already has HadIndexGetter, we don't
+        need to do anything for WebKitCSSTransformValue about HasIndexGetter.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+          Reset $hasGetter for WebKitCSSTransformValue.
+
 2010-01-07  Anton Muhin  <antonm at chromium.org>
 
         Reviewed by Adam Barth.
diff --git a/WebCore/bindings/scripts/CodeGeneratorV8.pm b/WebCore/bindings/scripts/CodeGeneratorV8.pm
index b459bec..76e8b2f 100644
--- a/WebCore/bindings/scripts/CodeGeneratorV8.pm
+++ b/WebCore/bindings/scripts/CodeGeneratorV8.pm
@@ -1222,6 +1222,11 @@ sub GenerateImplementationIndexer
     if ($interfaceName eq "HTMLOptionsCollection") {
         $hasGetter = 1;
     }
+    # FIXME: If the parent interface of $dataNode already has
+    # HasIndexGetter, we don't need to handle the getter here.
+    if ($interfaceName eq "WebKitCSSTransformValue") {
+        $hasGetter = 0;
+    }
 
     # FIXME: Investigate and remove this nastinesss. In V8, named property handling and indexer handling are apparently decoupled,
     # which means that object[X] where X is a number doesn't reach named property indexer. So we need to provide

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list