[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

eric at webkit.org eric at webkit.org
Thu Apr 8 00:56:59 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit e38731824acc3dbd2aa703345fc0bb43adda1c93
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Jan 7 11:35:40 2010 +0000

    2010-01-07  Kent Tamura  <tkent at chromium.org>
    
            Reviewed by Eric Seidel.
    
            Some IDL files lack "," separators for extended attributes.
            https://bugs.webkit.org/show_bug.cgi?id=33190
    
            To find such mistakes, IDLParser.pm rejects whitespace characters in
            extended attribute names.
    
            * bindings/scripts/IDLParser.pm:
              parseExtendedAttributes rejects whitespace in a name.
            * css/WebKitCSSTransformValue.idl: Add missing ",".
            * dom/EventTarget.idl: ditto.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 7f4ca09..acb1fe9 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,5 +1,20 @@
 2010-01-07  Kent Tamura  <tkent at chromium.org>
 
+        Reviewed by Eric Seidel.
+
+        Some IDL files lack "," separators for extended attributes.
+        https://bugs.webkit.org/show_bug.cgi?id=33190
+
+        To find such mistakes, IDLParser.pm rejects whitespace characters in
+        extended attribute names.
+
+        * bindings/scripts/IDLParser.pm:
+          parseExtendedAttributes rejects whitespace in a name.
+        * css/WebKitCSSTransformValue.idl: Add missing ",".
+        * dom/EventTarget.idl: ditto.
+
+2010-01-07  Kent Tamura  <tkent at chromium.org>
+
         Reviewed by Adam Barth.
 
         Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
diff --git a/WebCore/bindings/scripts/IDLParser.pm b/WebCore/bindings/scripts/IDLParser.pm
index 5affe94..74be8a4 100644
--- a/WebCore/bindings/scripts/IDLParser.pm
+++ b/WebCore/bindings/scripts/IDLParser.pm
@@ -158,6 +158,7 @@ sub parseExtendedAttributes
         # Attributes with no value are set to be true
         $value = 1 unless defined $value;
         $attrs{$name} = $value;
+        die("Invalid extended attribute name: '$name'\n") if $name =~ /\s/;
     }
 
     return \%attrs;
diff --git a/WebCore/css/WebKitCSSTransformValue.idl b/WebCore/css/WebKitCSSTransformValue.idl
index 67406f8..069c588 100644
--- a/WebCore/css/WebKitCSSTransformValue.idl
+++ b/WebCore/css/WebKitCSSTransformValue.idl
@@ -29,7 +29,7 @@
 module css {
 
     interface [
-            HasIndexGetter
+            HasIndexGetter,
             InterfaceUUID=303fe632-5dcf-4472-b977-33a5481e1d12,
             ImplementationUUID=eb49e5c6-6075-45b8-b5c4-7e775c01e7c4
     ] WebKitCSSTransformValue : CSSValueList {
diff --git a/WebCore/dom/EventTarget.idl b/WebCore/dom/EventTarget.idl
index b6efc37..baab021 100644
--- a/WebCore/dom/EventTarget.idl
+++ b/WebCore/dom/EventTarget.idl
@@ -24,7 +24,7 @@ module events {
     interface [
         ObjCProtocol,
         PureInterface,
-        OmitConstructor
+        OmitConstructor,
         InterfaceUUID=1D71C7EC-0BA0-4044-BDFD-56B3E8F5F9D4
     ] EventTarget {
         [OldStyleObjC] void addEventListener(in DOMString type, 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list