[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

abarth at webkit.org abarth at webkit.org
Thu Apr 8 01:01:22 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit a868a52cf73bfa103d5f83a45445f6b8b74a2967
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Jan 12 08:16:40 2010 +0000

    2010-01-12  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Eric Seidel.
    
            ecma/Date/15.9.5.12-1.js fails every night at midnight
            https://bugs.webkit.org/show_bug.cgi?id=28041
    
            Change the test to use a concrete time instead of "now".
    
            * tests/mozilla/ecma/Date/15.9.5.10-1.js:
            * tests/mozilla/ecma/Date/15.9.5.12-1.js:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index b1a0cde..78032c7 100644
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-01-12  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        ecma/Date/15.9.5.12-1.js fails every night at midnight
+        https://bugs.webkit.org/show_bug.cgi?id=28041
+
+        Change the test to use a concrete time instead of "now".
+
+        * tests/mozilla/ecma/Date/15.9.5.10-1.js:
+        * tests/mozilla/ecma/Date/15.9.5.12-1.js:
+
 2010-01-11  Csaba Osztrogonác  <ossy at webkit.org>
 
         Reviewed by Ariya Hidayat.
diff --git a/JavaScriptCore/tests/mozilla/ecma/Date/15.9.5.10-1.js b/JavaScriptCore/tests/mozilla/ecma/Date/15.9.5.10-1.js
index f887725..f13e9d7 100644
--- a/JavaScriptCore/tests/mozilla/ecma/Date/15.9.5.10-1.js
+++ b/JavaScriptCore/tests/mozilla/ecma/Date/15.9.5.10-1.js
@@ -61,14 +61,18 @@
 
     var DST_END_1998 = UTC( GetFirstSundayInNovember(TimeFromYear(1998)) + 2*msPerHour );
 
-    addTestCase( now );
 /*
+    // We don't use |now| because it fails every night at midnight.
+    // The test is more reproducable if we use concrete times.
+    addTestCase( now );
     addTestCase( TIME_YEAR_0 );
     addTestCase( TIME_1970 );
     addTestCase( TIME_1900 );
     addTestCase( TIME_2000 );
     addTestCase( UTC_FEB_29_2000 );
+*/
     addTestCase( UTC_JAN_1_2005 );
+/*
     addTestCase( DST_START_1998 );
     addTestCase( DST_START_1998-1 );
     addTestCase( DST_START_1998+1 );
diff --git a/JavaScriptCore/tests/mozilla/ecma/Date/15.9.5.12-1.js b/JavaScriptCore/tests/mozilla/ecma/Date/15.9.5.12-1.js
index 437a809..8dcf1a4 100644
--- a/JavaScriptCore/tests/mozilla/ecma/Date/15.9.5.12-1.js
+++ b/JavaScriptCore/tests/mozilla/ecma/Date/15.9.5.12-1.js
@@ -56,14 +56,19 @@
     var UTC_JAN_1_2005 = TIME_2000 + TimeInYear(2000)+TimeInYear(2001)+
     TimeInYear(2002)+TimeInYear(2003)+TimeInYear(2004);
 
-    addTestCase( now );
 /*
+    // We don't use |now| because it fails every night at midnight.
+    // The test is more reproducable if we use concrete times.
+    addTestCase( now );
+
     addTestCase( TIME_YEAR_0 );
     addTestCase( TIME_1970 );
     addTestCase( TIME_1900 );
     addTestCase( TIME_2000 );
     addTestCase( UTC_FEB_29_2000 );
+*/
     addTestCase( UTC_JAN_1_2005 );
+/*
 
     testcases[tc++] = new TestCase( SECTION,
                                     "(new Date(NaN)).getDay()",

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list