[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

benm at google.com benm at google.com
Thu Apr 8 01:12:34 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit 5d2751b7403f6a308f722edb2b8f56f0bf39f7e6
Author: benm at google.com <benm at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Jan 18 12:54:08 2010 +0000

    [Android] DOMWrapperMap::Visitor needs virtual destructor
    https://bugs.webkit.org/show_bug.cgi?id=33675
    
    Patch by Andrei Popescu <andreip at google.com> on 2010-01-18
    Reviewed by Adam Barth.
    
    Add protected virtual dtor to DOMWrapperMap::Visitor. See bug for further discussion.
    
    No new tests needed, functionality not changed.
    
    * bindings/v8/V8DOMMap.h:
    (WebCore::DOMWrapperMap::Visitor::~Visitor): Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 9ed3731..87492f7 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-01-18  Andrei Popescu  <andreip at google.com>
+
+        Reviewed by Adam Barth.
+
+        [Android] DOMWrapperMap::Visitor needs virtual destructor
+        https://bugs.webkit.org/show_bug.cgi?id=33675
+
+        Add protected virtual dtor to DOMWrapperMap::Visitor. See bug for further discussion.
+
+        No new tests needed, functionality not changed.
+
+        * bindings/v8/V8DOMMap.h:
+        (WebCore::DOMWrapperMap::Visitor::~Visitor): Added.
+
 2010-01-18  Simon Hausmann  <simon.hausmann at nokia.com>
 
         Unreviewed Symbian build fix.
diff --git a/WebCore/bindings/v8/V8DOMMap.h b/WebCore/bindings/v8/V8DOMMap.h
index 3a197fa..cddb0a4 100644
--- a/WebCore/bindings/v8/V8DOMMap.h
+++ b/WebCore/bindings/v8/V8DOMMap.h
@@ -102,6 +102,8 @@ namespace WebCore {
         class Visitor {
         public:
             virtual void visitDOMWrapper(KeyType*, v8::Persistent<ValueType>) = 0;
+        protected:
+            virtual ~Visitor() { }
         };
 
         virtual void visit(Visitor* visitor)

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list