[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373
eric at webkit.org
eric at webkit.org
Thu Apr 8 01:49:47 UTC 2010
The following commit has been merged in the webkit-1.2 branch:
commit 998bb26d58a7047dd69ab3123dd673a4140b495b
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Feb 17 03:21:48 2010 +0000
2010-02-16 James Hawkins <jhawkins at chromium.org>
Reviewed by Eric Seidel.
[Chromium] Remove calls to releaseRef when passing PassRefPtrs to base
classes. releaseRef releases the original pointer without decreasing
the reference count, and the base class constructor increases the
reference count, leading to a leak.
https://bugs.webkit.org/show_bug.cgi?id=35000
* src/WebDocument.cpp:
(WebKit::WebDocument::WebDocument):
* src/WebElement.cpp:
(WebKit::WebElement::WebElement):
* src/WebFormElement.cpp:
(WebKit::WebFormElement::WebFormElement):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::WebInputElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index 4c27dde..0d36913 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,3 +1,23 @@
+2010-02-16 James Hawkins <jhawkins at chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base
+ classes. releaseRef releases the original pointer without decreasing
+ the reference count, and the base class constructor increases the
+ reference count, leading to a leak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=35000
+
+ * src/WebDocument.cpp:
+ (WebKit::WebDocument::WebDocument):
+ * src/WebElement.cpp:
+ (WebKit::WebElement::WebElement):
+ * src/WebFormElement.cpp:
+ (WebKit::WebFormElement::WebFormElement):
+ * src/WebInputElement.cpp:
+ (WebKit::WebInputElement::WebInputElement):
+
2010-02-15 Jeremy Orlow <jorlow at chromium.org>
Reviewed by Darin Fisher.
diff --git a/WebKit/chromium/src/WebDocument.cpp b/WebKit/chromium/src/WebDocument.cpp
index 84f3004..c696f4f 100644
--- a/WebKit/chromium/src/WebDocument.cpp
+++ b/WebKit/chromium/src/WebDocument.cpp
@@ -53,7 +53,7 @@ using namespace WebCore;
namespace WebKit {
WebDocument::WebDocument(const PassRefPtr<Document>& elem)
- : WebNode(elem.releaseRef())
+ : WebNode(elem)
{
}
diff --git a/WebKit/chromium/src/WebElement.cpp b/WebKit/chromium/src/WebElement.cpp
index d0a0862..6501771 100644
--- a/WebKit/chromium/src/WebElement.cpp
+++ b/WebKit/chromium/src/WebElement.cpp
@@ -39,7 +39,7 @@ using namespace WebCore;
namespace WebKit {
WebElement::WebElement(const WTF::PassRefPtr<WebCore::Element>& elem)
- : WebNode(elem.releaseRef())
+ : WebNode(elem)
{
}
diff --git a/WebKit/chromium/src/WebFormElement.cpp b/WebKit/chromium/src/WebFormElement.cpp
index 5471608..0024892 100644
--- a/WebKit/chromium/src/WebFormElement.cpp
+++ b/WebKit/chromium/src/WebFormElement.cpp
@@ -47,7 +47,7 @@ class WebFormPrivate : public HTMLFormElement {
};
WebFormElement::WebFormElement(const WTF::PassRefPtr<HTMLFormElement>& e)
- : WebElement(e.releaseRef())
+ : WebElement(e)
{
}
diff --git a/WebKit/chromium/src/WebInputElement.cpp b/WebKit/chromium/src/WebInputElement.cpp
index 9fd317f..4ee1b93 100644
--- a/WebKit/chromium/src/WebInputElement.cpp
+++ b/WebKit/chromium/src/WebInputElement.cpp
@@ -41,7 +41,7 @@ using namespace WebCore;
namespace WebKit {
WebInputElement::WebInputElement(const WTF::PassRefPtr<HTMLInputElement>& elem)
- : WebElement(elem.releaseRef())
+ : WebElement(elem)
{
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list