[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

jamesr at google.com jamesr at google.com
Thu Apr 8 02:21:33 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit b095f1c0765ed71b8955a6cdc359b74a5e91011d
Author: jamesr at google.com <jamesr at google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Mar 13 01:02:47 2010 +0000

    2010-03-12  James Robinson  <jamesr at chromium.org>
    
            Reviewed by Adam Barth.
    
            Add virtual destructor to DOMWrapperWorld
            https://bugs.webkit.org/show_bug.cgi?id=36077
    
            DOMWrapperWorld is RefCounted<DOMWrapperWorld>.  IsolatedWorld
            inherits from DOMWrapperWorld and has member variables
            with destructors, so DOMWrapperWorld needs to have a declared virtual
            d'tor to ensure that its derived class's destructors are called.
    
            No new tests, no change in behavior
    
            * bindings/v8/DOMWrapperWorld.h:
            (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 44e11c1..21dbdae 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,21 @@
+2010-03-12  James Robinson  <jamesr at chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Add virtual destructor to DOMWrapperWorld
+        https://bugs.webkit.org/show_bug.cgi?id=36077
+
+        DOMWrapperWorld is RefCounted<DOMWrapperWorld>.  IsolatedWorld
+        inherits from DOMWrapperWorld and has member variables
+        with destructors, so DOMWrapperWorld needs to have a declared virtual
+        d'tor to ensure that its derived class's destructors are called.
+
+        No new tests, no change in behavior
+
+        * bindings/v8/DOMWrapperWorld.h:
+        (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
+
+
 2010-03-11  Gavin Barraclough  <barraclough at apple.com>
 
         Reviewed by Oliver Hunt.
diff --git a/WebCore/bindings/v8/DOMWrapperWorld.h b/WebCore/bindings/v8/DOMWrapperWorld.h
index f54cd4e..2a9df30 100644
--- a/WebCore/bindings/v8/DOMWrapperWorld.h
+++ b/WebCore/bindings/v8/DOMWrapperWorld.h
@@ -43,6 +43,7 @@ namespace WebCore {
 class DOMWrapperWorld : public RefCounted<DOMWrapperWorld> {
 public:
     static PassRefPtr<DOMWrapperWorld> create() { return adoptRef(new DOMWrapperWorld()); }
+    virtual ~DOMWrapperWorld() {}
 
 protected:
     DOMWrapperWorld();

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list