[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

Thu Apr 8 02:22:56 UTC 2010

The following commit has been merged in the webkit-1.2 branch:
commit 96bd4a06e6202eeb7a5af9fde38250198e6eed19
Author: cfleizach at apple.com <cfleizach at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Mar 15 22:07:20 2010 +0000

    VO not able to perform a VO-spacebar on facebook links
    https://bugs.webkit.org/show_bug.cgi?id=36132
    
    Reviewed by Beth Dakin.
    
    WebCore:
    
    When a label element is used as a click event handler, and it doesn't have any
    corresponding control, it should handle the action itself.
    
    Test: accessibility/label-element-press.html
    
    * html/HTMLLabelElement.cpp:
    (WebCore::HTMLLabelElement::accessKeyAction):
    
    LayoutTests:
    
    * accessibility/label-element-press-expected.txt: Added.
    * accessibility/label-element-press.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 0aeab0e..95e8927 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,13 @@
+2010-03-15  Chris Fleizach  <cfleizach at apple.com>
+
+        Reviewed by Beth Dakin.
+
+        VO not able to perform a VO-spacebar on facebook links
+        https://bugs.webkit.org/show_bug.cgi?id=36132
+
+        * accessibility/label-element-press-expected.txt: Added.
+        * accessibility/label-element-press.html: Added.
+
 2010-03-15  Simon Fraser  <simon.fraser at apple.com>
 
         Rubber-stamped by Dan Bernstein.
diff --git a/LayoutTests/accessibility/label-element-press-expected.txt b/LayoutTests/accessibility/label-element-press-expected.txt
new file mode 100644
index 0000000..01ca30c
--- /dev/null
+++ b/LayoutTests/accessibility/label-element-press-expected.txt
@@ -0,0 +1,10 @@
+label
+This tests that a label element without a corresponding control will perform a press action on itself instead of nothing.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/accessibility/label-element-press.html b/LayoutTests/accessibility/label-element-press.html
new file mode 100644
index 0000000..403ad45
--- /dev/null
+++ b/LayoutTests/accessibility/label-element-press.html
@@ -0,0 +1,42 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<link rel="stylesheet" href="../fast/js/resources/js-test-style.css">
+<script>
+var successfullyParsed = false;
+</script>
+<script src="../fast/js/resources/js-test-pre.js"></script>
+</head>
+
+<body id="body">
+
+<label tabindex=0 onclick="performEvent();" id="labelElement">label</label>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+    description("This tests that a label element without a corresponding control will perform a press action on itself instead of nothing.");
+ 
+    function performEvent() {
+       layoutTestController.notifyDone();
+    }
+
+    if (window.accessibilityController) {
+ 
+        layoutTestController.waitUntilDone();
+        document.getElementById("body").focus();
+        var body = accessibilityController.focusedElement;
+        var label = body.childAtIndex(0).childAtIndex(0);
+    
+        // if successful, performEvent() will be called and we'll successfully parse.        
+        label.press();
+    }
+
+    successfullyParsed = true;
+</script>
+
+<script src="../fast/js/resources/js-test-post.js"></script>
+</body>
+</html>
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 2bfbf1d..61ce6af 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-03-15  Chris Fleizach  <cfleizach at apple.com>
+
+        Reviewed by Beth Dakin.
+
+        VO not able to perform a VO-spacebar on facebook links
+        https://bugs.webkit.org/show_bug.cgi?id=36132
+
+        When a label element is used as a click event handler, and it doesn't have any
+        corresponding control, it should handle the action itself.
+
+        Test: accessibility/label-element-press.html
+
+        * html/HTMLLabelElement.cpp:
+        (WebCore::HTMLLabelElement::accessKeyAction):
+
 2010-03-15  Cameron Zwarich  <zwarich at apple.com>
 
         Reviewed by Geoff Garen.
diff --git a/WebCore/html/HTMLLabelElement.cpp b/WebCore/html/HTMLLabelElement.cpp
index 06b3b2f..645017d 100644
--- a/WebCore/html/HTMLLabelElement.cpp
+++ b/WebCore/html/HTMLLabelElement.cpp
@@ -139,6 +139,8 @@ void HTMLLabelElement::accessKeyAction(bool sendToAnyElement)
 {
     if (HTMLElement* element = correspondingControl())
         element->accessKeyAction(sendToAnyElement);
+    else
+        HTMLElement::accessKeyAction(sendToAnyElement);
 }
 
 String HTMLLabelElement::accessKey() const

-- 
WebKit Debian packaging

