[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373
eric at webkit.org
eric at webkit.org
Thu Apr 8 02:20:51 UTC 2010
The following commit has been merged in the webkit-1.2 branch:
commit 57bd3a33dc3791e28c09e774383d042035545c5a
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Mar 12 17:03:50 2010 +0000
2010-03-12 Nicolas Weber <thakis at chromium.org>
Reviewed by David Levin.
[Chromium] Cmd-clicking submit buttons should submit in new tab
https://bugs.webkit.org/show_bug.cgi?id=36023
Take modifiers into account when clicking form buttons. E.g.
cmd-clicking a submit button will submit in a new background tab,
cmd-shift-clicking in a new foreground tab, shift-clicking in a new
window. (On windows/linux, it's ctrl instead of cmd.)
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index 9397272..d6f3541 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,3 +1,18 @@
+2010-03-12 Nicolas Weber <thakis at chromium.org>
+
+ Reviewed by David Levin.
+
+ [Chromium] Cmd-clicking submit buttons should submit in new tab
+ https://bugs.webkit.org/show_bug.cgi?id=36023
+
+ Take modifiers into account when clicking form buttons. E.g.
+ cmd-clicking a submit button will submit in a new background tab,
+ cmd-shift-clicking in a new foreground tab, shift-clicking in a new
+ window. (On windows/linux, it's ctrl instead of cmd.)
+
+ * src/FrameLoaderClientImpl.cpp:
+ (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
+
2010-03-12 Kavita Kanetkar <kkanetkar at chromium.org>
Reviewed by Darin Fisher.
diff --git a/WebKit/chromium/src/FrameLoaderClientImpl.cpp b/WebKit/chromium/src/FrameLoaderClientImpl.cpp
index 03899a7..d298ab2 100644
--- a/WebKit/chromium/src/FrameLoaderClientImpl.cpp
+++ b/WebKit/chromium/src/FrameLoaderClientImpl.cpp
@@ -1477,10 +1477,19 @@ bool FrameLoaderClientImpl::actionSpecifiesNavigationPolicy(
const NavigationAction& action,
WebNavigationPolicy* policy)
{
- if ((action.type() != NavigationTypeLinkClicked) || !action.event()->isMouseEvent())
+ const MouseEvent* event = 0;
+ if (action.type() == NavigationTypeLinkClicked
+ && action.event()->isMouseEvent())
+ event = static_cast<const MouseEvent*>(action.event());
+ else if (action.type() == NavigationTypeFormSubmitted
+ && action.event()
+ && action.event()->underlyingEvent()
+ && action.event()->underlyingEvent()->isMouseEvent())
+ event = static_cast<const MouseEvent*>(action.event()->underlyingEvent());
+
+ if (!event)
return false;
- const MouseEvent* event = static_cast<const MouseEvent*>(action.event());
return WebViewImpl::navigationPolicyFromMouseEvent(
event->button(), event->ctrlKey(), event->shiftKey(), event->altKey(),
event->metaKey(), policy);
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list