[SCM] WebKit Debian packaging branch, webkit-1.2, updated. upstream/1.1.90-6072-g9a69373

eric at webkit.org eric at webkit.org
Thu Apr 8 00:30:20 UTC 2010


The following commit has been merged in the webkit-1.2 branch:
commit 1939ced98bb38ff82b1098ce8e061aad2a41c8f9
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Dec 9 22:54:17 2009 +0000

    2009-12-09  Steve Block  <steveblock at google.com>
    
            Reviewed by Darin Adler.
    
            Adds ENABLE(INSPECTOR) guards around script binding methods that use types
            defined only when INSPECTOR is enabled.
            https://bugs.webkit.org/show_bug.cgi?id=32328
    
            Build fix only, no new tests.
    
            * bindings/js/ScriptValue.cpp: Modified. Added ENABLE(INSPECTOR) guard to ScriptValue::quarantineValue.
            * bindings/v8/ScriptObject.cpp: Modified. Added ENABLE(INSPECTOR) guard to some overloads of ScriptGlobalObject::set.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 63e5e86..84bfa33 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,5 +1,18 @@
 2009-12-09  Steve Block  <steveblock at google.com>
 
+        Reviewed by Darin Adler.
+
+        Adds ENABLE(INSPECTOR) guards around script binding methods that use types
+        defined only when INSPECTOR is enabled.
+        https://bugs.webkit.org/show_bug.cgi?id=32328
+
+        Build fix only, no new tests.
+
+        * bindings/js/ScriptValue.cpp: Modified. Added ENABLE(INSPECTOR) guard to ScriptValue::quarantineValue.
+        * bindings/v8/ScriptObject.cpp: Modified. Added ENABLE(INSPECTOR) guard to some overloads of ScriptGlobalObject::set.
+
+2009-12-09  Steve Block  <steveblock at google.com>
+
         Reviewed by Adam Barth.
 
         Adds Android Makefiles for building with V8.
diff --git a/WebCore/bindings/js/ScriptValue.cpp b/WebCore/bindings/js/ScriptValue.cpp
index ad43636..5444e0e 100644
--- a/WebCore/bindings/js/ScriptValue.cpp
+++ b/WebCore/bindings/js/ScriptValue.cpp
@@ -42,11 +42,13 @@ using namespace JSC;
 
 namespace WebCore {
 
+#if ENABLE(INSPECTOR)
 ScriptValue ScriptValue::quarantineValue(ScriptState* scriptState, const ScriptValue& value)
 {
     JSLock lock(SilenceAssertionsOnly);
     return ScriptValue(JSInspectedObjectWrapper::wrap(scriptState, value.jsValue()));
 }
+#endif
 
 bool ScriptValue::getString(ScriptState* scriptState, String& result) const
 {
diff --git a/WebCore/bindings/v8/ScriptObject.cpp b/WebCore/bindings/v8/ScriptObject.cpp
index 94bb4da..8d80d34 100644
--- a/WebCore/bindings/v8/ScriptObject.cpp
+++ b/WebCore/bindings/v8/ScriptObject.cpp
@@ -140,6 +140,7 @@ bool ScriptGlobalObject::set(ScriptState* scriptState, const char* name, const S
     return scope.success();
 }
 
+#if ENABLE(INSPECTOR)
 bool ScriptGlobalObject::set(ScriptState* scriptState, const char* name, InspectorBackend* value)
 {
     ScriptScope scope(scriptState);
@@ -160,6 +161,7 @@ bool ScriptGlobalObject::set(ScriptState* scriptState, const char* name, Injecte
     scope.global()->Set(v8::String::New(name), V8DOMWrapper::convertToV8Object(V8ClassIndex::INJECTEDSCRIPTHOST, value));
     return scope.success();
 }
+#endif
 
 bool ScriptGlobalObject::get(ScriptState* scriptState, const char* name, ScriptObject& value)
 {

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list