[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
commit-queue at webkit.org
commit-queue at webkit.org
Wed Dec 22 11:08:52 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 1ca52c49c2a76646117ec439bbdc41a638797257
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Jul 13 19:56:50 2010 +0000
2010-07-13 Scott Violet <sky at chromium.org>
Reviewed by David Levin.
[Chromium] Makes pressing tab accept the currently selected item in a popup.
https://bugs.webkit.org/show_bug.cgi?id=42172
* WebCore/platform/chromium/PopupMenuChromium.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/ChangeLog b/ChangeLog
index 8279cd0..e27569e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2010-07-13 Scott Violet <sky at chromium.org>
+
+ Reviewed by David Levin.
+
+ [Chromium] Makes pressing tab accept the currently selected item in a popup.
+ https://bugs.webkit.org/show_bug.cgi?id=42172
+
+ * WebCore/platform/chromium/PopupMenuChromium.cpp:
+
2010-07-12 Xan Lopez <xlopez at igalia.com>
Reviewed by Gustavo Noronha.
diff --git a/WebCore/platform/chromium/PopupMenuChromium.cpp b/WebCore/platform/chromium/PopupMenuChromium.cpp
index 54dce16..41a758b 100644
--- a/WebCore/platform/chromium/PopupMenuChromium.cpp
+++ b/WebCore/platform/chromium/PopupMenuChromium.cpp
@@ -752,8 +752,11 @@ bool PopupListBox::handleKeyEvent(const PlatformKeyboardEvent& event)
if (event.windowsVirtualKeyCode() == VKEY_TAB) {
// TAB is a special case as it should select the current item if any and
// advance focus.
- if (m_selectedIndex >= 0)
- m_popupClient->setTextFromItem(m_selectedIndex);
+ if (m_selectedIndex >= 0) {
+ acceptIndex(m_selectedIndex); // May delete us.
+ // Return false so the TAB key event is propagated to the page.
+ return false;
+ }
// Call abandon() so we honor m_acceptedIndexOnAbandon if set.
abandon();
// Return false so the TAB key event is propagated to the page.
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list