[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

commit-queue at webkit.org commit-queue at webkit.org
Wed Dec 22 11:09:52 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 881e294e5227e8d4ca5e70a8f3e11acec3a1616d
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Jul 14 08:49:57 2010 +0000

    2010-07-14  Lucas De Marchi  <lucas.demarchi at profusion.mobi>
    
            Reviewed by Antonio Gomes.
    
            [EFL] Add eina_safety to popup menu deletion.
            https://bugs.webkit.org/show_bug.cgi?id=41873
    
            Since this is a public call, it's better to have an eina_safety on
            public calls. It would crash if browser calls this function to select
            an item of a nonexistent popup.
    
            * efl/ewk/ewk_view.cpp: add eina_safety to return if popup menu client does
            not exist.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index b76ad27..2867fc1 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,17 @@
+2010-07-14  Lucas De Marchi  <lucas.demarchi at profusion.mobi>
+
+        Reviewed by Antonio Gomes.
+
+        [EFL] Add eina_safety to popup menu deletion.
+        https://bugs.webkit.org/show_bug.cgi?id=41873
+
+        Since this is a public call, it's better to have an eina_safety on
+        public calls. It would crash if browser calls this function to select
+        an item of a nonexistent popup.
+
+        * efl/ewk/ewk_view.cpp: add eina_safety to return if popup menu client does
+        not exist.
+
 2010-07-13  Simon Fraser  <simon.fraser at apple.com>
 
         Reviewed by Dan Bernstein.
diff --git a/WebKit/efl/ewk/ewk_view.cpp b/WebKit/efl/ewk/ewk_view.cpp
index 39dc0a7..6ce8eda 100644
--- a/WebKit/efl/ewk/ewk_view.cpp
+++ b/WebKit/efl/ewk/ewk_view.cpp
@@ -3737,6 +3737,7 @@ void ewk_view_popup_selected_set(Evas_Object* o, int index)
     INF("o=%p", o);
     EWK_VIEW_SD_GET_OR_RETURN(o, sd);
     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv);
+    EINA_SAFETY_ON_NULL_RETURN(priv->popup.menu_client);
 
     priv->popup.menu_client->valueChanged(index);
 }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list