[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

jcivelli at chromium.org jcivelli at chromium.org
Wed Dec 22 11:11:51 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit d0ca69eae737360dcb9e2055656880316d6e74ba
Author: jcivelli at chromium.org <jcivelli at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Jul 14 23:02:23 2010 +0000

    2010-07-14  Jay Civelli  <jcivelli at chromium.org>
    
            Reviewed by David Levin.
    
            Don't notify the WebView that the popup has been closed when the
            selection is cleared, as the popup is not gone and would linger
            as a ghost popup.
            https://bugs.webkit.org/show_bug.cgi?id=42180
    
            * src/AutoFillPopupMenuClient.cpp:
            (WebKit::AutoFillPopupMenuClient::selectionCleared):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
index 32c5abc..09bbc6c 100644
--- a/WebKit/chromium/ChangeLog
+++ b/WebKit/chromium/ChangeLog
@@ -1,3 +1,15 @@
+2010-07-14  Jay Civelli  <jcivelli at chromium.org>
+
+        Reviewed by David Levin.
+
+        Don't notify the WebView that the popup has been closed when the
+        selection is cleared, as the popup is not gone and would linger
+        as a ghost popup.
+        https://bugs.webkit.org/show_bug.cgi?id=42180
+
+        * src/AutoFillPopupMenuClient.cpp:
+        (WebKit::AutoFillPopupMenuClient::selectionCleared):
+
 2010-07-14  Sam Weinig  <sam at webkit.org>
 
         Fix the chromium mac build.
diff --git a/WebKit/chromium/src/AutoFillPopupMenuClient.cpp b/WebKit/chromium/src/AutoFillPopupMenuClient.cpp
index 30d91f9..3af6f56 100644
--- a/WebKit/chromium/src/AutoFillPopupMenuClient.cpp
+++ b/WebKit/chromium/src/AutoFillPopupMenuClient.cpp
@@ -143,8 +143,9 @@ void AutoFillPopupMenuClient::selectionChanged(unsigned listIndex, bool fireEven
 
 void AutoFillPopupMenuClient::selectionCleared()
 {
-    // Same effect desired as popupDidHide, so call through.
-    popupDidHide();
+    WebViewImpl* webView = getWebView();
+    if (webView)
+        webView->client()->didClearAutoFillSelection(WebNode(getTextField()));
 }
 
 String AutoFillPopupMenuClient::itemText(unsigned listIndex) const

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list