[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

mrowe at apple.com mrowe at apple.com
Wed Dec 22 11:13:34 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 22e5203bfb6f2c1942475ee28825ef56e189fc66
Author: mrowe at apple.com <mrowe at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Jul 15 09:55:26 2010 +0000

    Fix a leak of Vector instances seen on the build bot.
    
    Reviewed by Maciej Stachowiak.
    
    * rendering/RenderObject.cpp:
    (WebCore::RenderObject::drawBoxSideFromPath): Don't unnecessarily heap allocate then leak the DashArray.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 60065ac..71f2ab3 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,5 +1,14 @@
 2010-07-15  Mark Rowe  <mrowe at apple.com>
 
+        Reviewed by Maciej Stachowiak.
+
+        Fix a leak of Vector instances seen on the build bot.
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::drawBoxSideFromPath): Don't unnecessarily heap allocate then leak the DashArray.
+
+2010-07-15  Mark Rowe  <mrowe at apple.com>
+
         Update the sorting in the Xcode project files.
 
         * WebCore.xcodeproj/project.pbxproj:
diff --git a/WebCore/rendering/RenderObject.cpp b/WebCore/rendering/RenderObject.cpp
index d3213b6..27eabcd 100644
--- a/WebCore/rendering/RenderObject.cpp
+++ b/WebCore/rendering/RenderObject.cpp
@@ -941,10 +941,10 @@ void RenderObject::drawBoxSideFromPath(GraphicsContext* graphicsContext, IntRect
             whiteSpaceWidth += (patWidth  / numberOfWhitespaceDashes);
         }
 
-        DashArray* lineDash = new DashArray();
-        lineDash->append(patWidth);
-        lineDash->append(whiteSpaceWidth);
-        graphicsContext->setLineDash(*lineDash, patWidth);
+        DashArray lineDash;
+        lineDash.append(patWidth);
+        lineDash.append(whiteSpaceWidth);
+        graphicsContext->setLineDash(lineDash, patWidth);
         graphicsContext->addPath(borderPath);
         graphicsContext->strokePath();
         return;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list