[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

weinig at apple.com weinig at apple.com
Wed Dec 22 11:14:40 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 78b463aa38e709e57b867492ef9a9b3aeb634648
Author: weinig at apple.com <weinig at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Jul 15 21:49:39 2010 +0000

    Patch for https://bugs.webkit.org/show_bug.cgi?id=42410
    Many leaking DatasetDOMStringMaps seen on buildbot
    
    Reviewed by Oliver Hunt.
    
    * dom/NodeRareData.h:
    (WebCore::NodeRareData::~NodeRareData): Add a virtual destructor so
    that the ElementRareData's destructor will be called when this is deleted
    from the Node's destructor.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 2425fce..2cec331 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-07-15  Sam Weinig  <sam at webkit.org>
+
+        Reviewed by Oliver Hunt.
+
+        Patch for https://bugs.webkit.org/show_bug.cgi?id=42410
+        Many leaking DatasetDOMStringMaps seen on buildbot
+
+        * dom/NodeRareData.h:
+        (WebCore::NodeRareData::~NodeRareData): Add a virtual destructor so
+        that the ElementRareData's destructor will be called when this is deleted
+        from the Node's destructor.
+
 2010-07-15  Chris Fleizach  <cfleizach at apple.com>
 
         Reviewed by Darin Adler.
diff --git a/WebCore/dom/NodeRareData.h b/WebCore/dom/NodeRareData.h
index 4d80cee..531fc57 100644
--- a/WebCore/dom/NodeRareData.h
+++ b/WebCore/dom/NodeRareData.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008 Apple Inc. All rights reserved.
+ * Copyright (C) 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 David Smith <catfish.man at gmail.com>
  *
  * This library is free software; you can redistribute it and/or
@@ -29,8 +29,8 @@
 #include "StringHash.h"
 #include "TagNodeList.h"
 #include <wtf/HashSet.h>
-#include <wtf/PassOwnPtr.h>
 #include <wtf/OwnPtr.h>
+#include <wtf/PassOwnPtr.h>
 
 namespace WebCore {
 
@@ -77,6 +77,10 @@ public:
     {
     }
 
+    virtual ~NodeRareData()
+    {
+    }
+
     typedef HashMap<const Node*, NodeRareData*> NodeRareDataMap;
     
     static NodeRareDataMap& rareDataMap()
@@ -123,6 +127,6 @@ private:
     bool m_needsFocusAppearanceUpdateSoonAfterAttach : 1;
 };
 
-} //namespace
+} // namespace WebCore
 
-#endif
+#endif // NodeRareData_h

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list