[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
simon.fraser at apple.com
simon.fraser at apple.com
Wed Dec 22 11:19:53 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit e8b8829cd4cf1313aab69f9f552589a78dfe9b33
Author: simon.fraser at apple.com <simon.fraser at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Jul 19 21:05:51 2010 +0000
2010-07-19 Simon Fraser <simon.fraser at apple.com>
Reviewed by Brady Eidson.
Fix MiniBrowser to update URL as you browse
https://bugs.webkit.org/show_bug.cgi?id=42591
Hook up various loading notifications to update the URL bar in MiniBrowser.
* MiniBrowser/mac/BrowserWindowController.m:
(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFailLoadWithErrorForFrame):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
(-[BrowserWindowController didStartProvisionalLoadForFrame:]):
(-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
(-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
(-[BrowserWindowController didFailLoadWithErrorForFrame:]):
(-[BrowserWindowController didCommitLoadForFrame:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index baad9ad..859b307 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,25 @@
+2010-07-19 Simon Fraser <simon.fraser at apple.com>
+
+ Reviewed by Brady Eidson.
+
+ Fix MiniBrowser to update URL as you browse
+ https://bugs.webkit.org/show_bug.cgi?id=42591
+
+ Hook up various loading notifications to update the URL bar in MiniBrowser.
+
+ * MiniBrowser/mac/BrowserWindowController.m:
+ (_didStartProvisionalLoadForFrame):
+ (_didReceiveServerRedirectForProvisionalLoadForFrame):
+ (_didFailProvisionalLoadWithErrorForFrame):
+ (_didCommitLoadForFrame):
+ (_didFailLoadWithErrorForFrame):
+ (-[BrowserWindowController updateProvisionalURLForFrame:]):
+ (-[BrowserWindowController didStartProvisionalLoadForFrame:]):
+ (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
+ (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
+ (-[BrowserWindowController didFailLoadWithErrorForFrame:]):
+ (-[BrowserWindowController didCommitLoadForFrame:]):
+
2010-07-19 Alexey Proskuryakov <ap at apple.com>
Reviewed by Darin Adler.
diff --git a/WebKitTools/MiniBrowser/mac/BrowserWindowController.m b/WebKitTools/MiniBrowser/mac/BrowserWindowController.m
index a12a926..234c04c 100644
--- a/WebKitTools/MiniBrowser/mac/BrowserWindowController.m
+++ b/WebKitTools/MiniBrowser/mac/BrowserWindowController.m
@@ -33,6 +33,11 @@
- (void)didStartProgress;
- (void)didChangeProgress:(double)value;
- (void)didFinishProgress;
+- (void)didStartProvisionalLoadForFrame:(WKFrameRef)frame;
+- (void)didCommitLoadForFrame:(WKFrameRef)frame;
+- (void)didReceiveServerRedirectForProvisionalLoadForFrame:(WKFrameRef)frame;
+- (void)didFailProvisionalLoadWithErrorForFrame:(WKFrameRef)frame;
+- (void)didFailLoadWithErrorForFrame:(WKFrameRef)frame;
@end
@implementation BrowserWindowController
@@ -149,22 +154,22 @@
static void _didStartProvisionalLoadForFrame(WKPageRef page, WKFrameRef frame, const void *clientInfo)
{
- LOG(@"didStartProvisionalLoadForFrame");
+ [(BrowserWindowController *)clientInfo didStartProvisionalLoadForFrame:frame];
}
static void _didReceiveServerRedirectForProvisionalLoadForFrame(WKPageRef page, WKFrameRef frame, const void *clientInfo)
{
- LOG(@"didReceiveServerRedirectForProvisionalLoadForFrame");
+ [(BrowserWindowController *)clientInfo didReceiveServerRedirectForProvisionalLoadForFrame:frame];
}
static void _didFailProvisionalLoadWithErrorForFrame(WKPageRef page, WKFrameRef frame, const void *clientInfo)
{
- LOG(@"didFailProvisionalLoadWithErrorForFrame");
+ [(BrowserWindowController *)clientInfo didFailProvisionalLoadWithErrorForFrame:frame];
}
static void _didCommitLoadForFrame(WKPageRef page, WKFrameRef frame, const void *clientInfo)
{
- LOG(@"didCommitLoadForFrame");
+ [(BrowserWindowController *)clientInfo didCommitLoadForFrame:frame];
}
static void _didFinishLoadForFrame(WKPageRef page, WKFrameRef frame, const void *clientInfo)
@@ -174,7 +179,7 @@ static void _didFinishLoadForFrame(WKPageRef page, WKFrameRef frame, const void
static void _didFailLoadWithErrorForFrame(WKPageRef page, WKFrameRef frame, const void *clientInfo)
{
- LOG(@"didFailLoadWithErrorForFrame");
+ [(BrowserWindowController *)clientInfo didFailLoadWithErrorForFrame:frame];
}
static void _didReceiveTitleForFrame(WKPageRef page, WKStringRef title, WKFrameRef frame, const void *clientInfo)
@@ -403,6 +408,53 @@ static void _didUpdateHistoryTitle(WKPageRef page, WKStringRef title, WKURLRef U
[progressIndicator setDoubleValue:1.0];
}
+- (void)updateProvisionalURLForFrame:(WKFrameRef)frame
+{
+ WKURLRef url = WKFrameGetProvisionalURL(frame);
+ if (!url)
+ return;
+
+ CFURLRef cfSourceURL = WKURLCopyCFURL(0, url);
+ [urlText setStringValue:(NSString*)CFURLGetString(cfSourceURL)];
+ CFRelease(cfSourceURL);
+}
+
+- (void)didStartProvisionalLoadForFrame:(WKFrameRef)frame
+{
+ if (!WKFrameIsMainFrame(frame))
+ return;
+
+ [self updateProvisionalURLForFrame:frame];
+}
+
+- (void)didReceiveServerRedirectForProvisionalLoadForFrame:(WKFrameRef)frame
+{
+ if (!WKFrameIsMainFrame(frame))
+ return;
+
+ [self updateProvisionalURLForFrame:frame];
+}
+
+- (void)didFailProvisionalLoadWithErrorForFrame:(WKFrameRef)frame
+{
+ if (!WKFrameIsMainFrame(frame))
+ return;
+
+ [self updateProvisionalURLForFrame:frame];
+}
+
+- (void)didFailLoadWithErrorForFrame:(WKFrameRef)frame
+{
+ if (!WKFrameIsMainFrame(frame))
+ return;
+
+ [self updateProvisionalURLForFrame:frame];
+}
+
+- (void)didCommitLoadForFrame:(WKFrameRef)frame
+{
+}
+
- (void)loadURLString:(NSString *)urlString
{
// FIXME: We shouldn't have to set the url text here.
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list