[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

abarth at webkit.org abarth at webkit.org
Wed Dec 22 11:22:01 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit ffc4832830c7f458f98f5027b6d91ff7f136ef5d
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Jul 20 18:28:22 2010 +0000

    2010-07-20  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Darin Adler.
    
            HTML5 tree builder should restore form state
            https://bugs.webkit.org/show_bug.cgi?id=42644
    
            We need to tell self-closing tags that we're done parsing their
            children.  This patch fixes the following LayoutTests when run with
            --html5-treebuilder:
    
              fast/forms/button-state-restore.html
              fast/forms/state-restore-to-non-autocomplete-form.html
              fast/forms/state-restore-to-non-edited-controls.html
              fast/history/saves-state-after-fragment-nav.html
              http/tests/navigation/restore-form-state-https.html
    
            * html/HTMLConstructionSite.cpp:
            (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 0ac1a6c..e85a728 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,23 @@
+2010-07-20  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by Darin Adler.
+
+        HTML5 tree builder should restore form state
+        https://bugs.webkit.org/show_bug.cgi?id=42644
+
+        We need to tell self-closing tags that we're done parsing their
+        children.  This patch fixes the following LayoutTests when run with
+        --html5-treebuilder:
+
+          fast/forms/button-state-restore.html
+          fast/forms/state-restore-to-non-autocomplete-form.html
+          fast/forms/state-restore-to-non-edited-controls.html
+          fast/history/saves-state-after-fragment-nav.html
+          http/tests/navigation/restore-form-state-https.html
+
+        * html/HTMLConstructionSite.cpp:
+        (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
+
 2010-07-20  Sheriff Bot  <webkit.review.bot at gmail.com>
 
         Unreviewed, rolling out r63750.
diff --git a/WebCore/html/HTMLConstructionSite.cpp b/WebCore/html/HTMLConstructionSite.cpp
index 11dea00..fed794c 100644
--- a/WebCore/html/HTMLConstructionSite.cpp
+++ b/WebCore/html/HTMLConstructionSite.cpp
@@ -233,7 +233,11 @@ void HTMLConstructionSite::insertHTMLElement(AtomicHTMLToken& token)
 void HTMLConstructionSite::insertSelfClosingHTMLElement(AtomicHTMLToken& token)
 {
     ASSERT(token.type() == HTMLToken::StartTag);
-    attachToCurrent(createHTMLElement(token));
+    RefPtr<Element> element = attachToCurrent(createHTMLElement(token));
+    // Normally HTMLElementStack is responsible for calling finishParsingChildren,
+    // but self-closing elements are never in the element stack so the stack
+    // doesn't get a chance to tell them that we're done parsing their children.
+    element->finishParsingChildren();
     // FIXME: Do we want to acknowledge the token's self-closing flag?
     // http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.html#acknowledge-self-closing-flag
 }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list