[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

abarth at webkit.org abarth at webkit.org
Wed Dec 22 11:26:44 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 0c2be585445caa15494d173bbdceadc75e9abd90
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Jul 23 18:54:03 2010 +0000

    2010-07-23  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Eric Seidel.
    
            Inline HTMLElementStack::top
            https://bugs.webkit.org/show_bug.cgi?id=42879
    
            According to sampling, HTMLElementStack::top is the hotest function in
            the treebuilder.  Inlining it is about a 0.3% improvement to the
            parsing benchmark.  This squares with how often it occurs in samples.
    
            * html/HTMLElementStack.cpp:
            * html/HTMLElementStack.h:
            (WebCore::HTMLElementStack::top):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index dacf6f9..baea8b7 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-07-23  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Inline HTMLElementStack::top
+        https://bugs.webkit.org/show_bug.cgi?id=42879
+
+        According to sampling, HTMLElementStack::top is the hotest function in
+        the treebuilder.  Inlining it is about a 0.3% improvement to the
+        parsing benchmark.  This squares with how often it occurs in samples.
+
+        * html/HTMLElementStack.cpp:
+        * html/HTMLElementStack.h:
+        (WebCore::HTMLElementStack::top):
+
 2010-07-23  Patrick Gansterer  <paroga at paroga.com>
 
         Reviewed by Adam Roben.
diff --git a/WebCore/html/HTMLElementStack.cpp b/WebCore/html/HTMLElementStack.cpp
index f3e78f5..75ae751 100644
--- a/WebCore/html/HTMLElementStack.cpp
+++ b/WebCore/html/HTMLElementStack.cpp
@@ -278,12 +278,6 @@ HTMLElementStack::ElementRecord* HTMLElementStack::topRecord() const
     return m_top.get();
 }
 
-Element* HTMLElementStack::top() const
-{
-    ASSERT(m_top->element());
-    return m_top->element();
-}
-
 Element* HTMLElementStack::oneBelowTop() const
 {
     // We should never be calling this if it could be 0.
diff --git a/WebCore/html/HTMLElementStack.h b/WebCore/html/HTMLElementStack.h
index 5969c80..7fc4043 100644
--- a/WebCore/html/HTMLElementStack.h
+++ b/WebCore/html/HTMLElementStack.h
@@ -66,8 +66,15 @@ public:
         RefPtr<Element> m_element;
         OwnPtr<ElementRecord> m_next;
     };
-    
-    Element* top() const;
+
+    // Inlining this function is a (small) performance win on the parsing
+    // benchmark.
+    Element* top() const
+    {
+        ASSERT(m_top->element());
+        return m_top->element();
+    }
+
     Element* oneBelowTop() const;
     ElementRecord* topRecord() const;
     Element* bottom() const;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list