[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
ap at apple.com
ap at apple.com
Wed Dec 22 11:23:33 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit ce371390f992867d618a611145ee02b2bfbb8e0b
Author: ap at apple.com <ap at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Jul 21 17:20:30 2010 +0000
https://bugs.webkit.org/show_bug.cgi?id=42717
<rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
credential storage, and is sent with subsequent requests
WebCore:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Don't use that direct a
copy/paste, oops!
LayoutTests:
* platform/gtk/Skipped:
* platform/qt/Skipped:
Skip the new tests, they don't pass.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index e9a0b65..b6e278e 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2010-07-21 Alexey Proskuryakov <ap at apple.com>
+
+ Unreviewed.
+
+ https://bugs.webkit.org/show_bug.cgi?id=42717
+ <rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
+ credential storage, and is sent with subsequent requests
+
+ * platform/gtk/Skipped:
+ * platform/qt/Skipped:
+ Skip the new tests, they don't pass.
+
2010-07-20 Alexey Proskuryakov <ap at apple.com>
Reviewed by Darin Adler.
diff --git a/LayoutTests/platform/gtk/Skipped b/LayoutTests/platform/gtk/Skipped
index f00edc9..e35a0c6 100644
--- a/LayoutTests/platform/gtk/Skipped
+++ b/LayoutTests/platform/gtk/Skipped
@@ -5872,3 +5872,7 @@ http/tests/misc/webtiming-two-redirects.php
# Accuracy problems in the results
# https://bugs.webkit.org/show_bug.cgi?id=42624
svg/dom/path-parser.html
+
+# Advanced credential handling
+http/tests/security/401-logout/401-logout.php
+http/tests/xmlhttprequest/remember-bad-password.html
diff --git a/LayoutTests/platform/qt/Skipped b/LayoutTests/platform/qt/Skipped
index 74c6fca..cb1d9a3 100644
--- a/LayoutTests/platform/qt/Skipped
+++ b/LayoutTests/platform/qt/Skipped
@@ -5443,3 +5443,7 @@ fast/dom/webtiming.html
fast/dom/webtiming-navigate-within-document.html
http/tests/misc/webtiming-one-redirect.php
http/tests/misc/webtiming-two-redirects.php
+
+# Advanced credential handling
+http/tests/security/401-logout/401-logout.php
+http/tests/xmlhttprequest/remember-bad-password.html
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 9e57514..70019d0 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2010-07-21 Alexey Proskuryakov <ap at apple.com>
+
+ Unreviewed Windows build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=42717
+ <rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
+ credential storage, and is sent with subsequent requests
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Don't use that direct a
+ copy/paste, oops!
+
2010-07-21 Simon Fraser <simon.fraser at apple.com>
Reviewed by Darin Adler.
diff --git a/WebCore/platform/network/cf/ResourceHandleCFNet.cpp b/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
index 089549e..419e397 100644
--- a/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
+++ b/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
@@ -534,7 +534,8 @@ void ResourceHandle::didReceiveAuthenticationChallenge(const AuthenticationChall
// Store the credential back, possibly adding it as a default for this directory.
CredentialStorage::set(credential, challenge.protectionSpace(), firstRequest().url());
}
- [challenge.sender() useCredential:mac(credential) forAuthenticationChallenge:mac(challenge)];
+ RetainPtr<CFURLCredentialRef> cfCredential(AdoptCF, createCF(credential));
+ CFURLConnectionUseCredential(d->m_connection.get(), cfCredential.get(), challenge.cfURLAuthChallengeRef());
return;
}
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list