[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

aroben at apple.com aroben at apple.com
Wed Dec 22 11:32:19 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 6bcfb5891c03b37e3b4df92edd2f7d941d0bc090
Author: aroben at apple.com <aroben at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Jul 28 19:53:50 2010 +0000

    Stop leaking Connection::m_readState.hEvent on Windows
    
    Fixes <http://webkit.org/b/43129> CoreIPC::Connection leaks its read
    event on Windows
    
    Reviewed by Darin Adler.
    
    * Platform/CoreIPC/win/ConnectionWin.cpp:
    (CoreIPC::Connection::platformInvalidate): Close the event handle.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
index 67c3cd8..c23408a 100644
--- a/WebKit2/ChangeLog
+++ b/WebKit2/ChangeLog
@@ -1,3 +1,15 @@
+2010-07-28  Adam Roben  <aroben at apple.com>
+
+        Stop leaking Connection::m_readState.hEvent on Windows
+
+        Fixes <http://webkit.org/b/43129> CoreIPC::Connection leaks its read
+        event on Windows
+
+        Reviewed by Darin Adler.
+
+        * Platform/CoreIPC/win/ConnectionWin.cpp:
+        (CoreIPC::Connection::platformInvalidate): Close the event handle.
+
 2010-07-26  Steve Block  <steveblock at google.com>
 
        Reviewed by Jeremy Orlow.
diff --git a/WebKit2/Platform/CoreIPC/win/ConnectionWin.cpp b/WebKit2/Platform/CoreIPC/win/ConnectionWin.cpp
index c153f70..47b6b31 100644
--- a/WebKit2/Platform/CoreIPC/win/ConnectionWin.cpp
+++ b/WebKit2/Platform/CoreIPC/win/ConnectionWin.cpp
@@ -92,7 +92,10 @@ void Connection::platformInvalidate()
     if (m_connectionPipe == INVALID_HANDLE_VALUE)
         return;
 
-    // FIXME: Unregister the handle.
+    // FIXME: Unregister the handles.
+
+    ::CloseHandle(m_readState.hEvent);
+    m_readState.hEvent = 0;
 
     ::CloseHandle(m_connectionPipe);
     m_connectionPipe = INVALID_HANDLE_VALUE;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list