[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
zimmermann at webkit.org
zimmermann at webkit.org
Wed Dec 22 11:36:02 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit 8c0a9366efc31cea8c5c1c2841d990819582e769
Author: zimmermann at webkit.org <zimmermann at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Jul 30 11:10:14 2010 +0000
2010-07-30 Nikolas Zimmermann <nzimmermann at rim.com>
Reviewed by Dirk Schulze.
svg/dynamic-updates: cursor attribute changes not respected
https://bugs.webkit.org/show_bug.cgi?id=42615
Turns out the tests were wrong, specifying a hot spot which is too large.
Switched to a larger cursor image to make the changes easier to detect, when using the browser.
All svg/dynamic-updates tests work again, without regressions.
* platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
* svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt:
* svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt:
* svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt:
* svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt:
* svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js:
* svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js:
* svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js:
* svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 4d9b676..e8937aa 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,32 @@
+2010-07-30 Nikolas Zimmermann <nzimmermann at rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ svg/dynamic-updates: cursor attribute changes not respected
+ https://bugs.webkit.org/show_bug.cgi?id=42615
+
+ Turns out the tests were wrong, specifying a hot spot which is too large.
+ Switched to a larger cursor image to make the changes easier to detect, when using the browser.
+
+ All svg/dynamic-updates tests work again, without regressions.
+
+ * platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum:
+ * platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
+ * platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum:
+ * platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
+ * platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum:
+ * platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
+ * platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum:
+ * platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
+ * svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt:
+ * svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt:
+ * svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt:
+ * svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt:
+ * svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js:
+ * svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js:
+ * svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js:
+ * svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js:
+
2010-07-30 Kent Tamura <tkent at chromium.org>
Unreviewed, test expectation update.
diff --git a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum
index 0f2d2ae..bec7d5e 100644
--- a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum
+++ b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum
@@ -1 +1 @@
-68e6ddad4147b871f21014d9f34cc4e5
\ No newline at end of file
+6155be7c28c9029d052f4244c484c4b0
\ No newline at end of file
diff --git a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png
index c0073ed..31e4f72 100644
Binary files a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png and b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png differ
diff --git a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum
index 8939139..20cb0e4 100644
--- a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum
+++ b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum
@@ -1 +1 @@
-fc80a9f8c6d315d743e21bced6cf8f04
\ No newline at end of file
+1ca091212f0ea37247c5ac67d7f53c25
\ No newline at end of file
diff --git a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png
index 828e572..d2b6f26 100644
Binary files a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png and b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png differ
diff --git a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum
index 46f85fa..01b39cb 100644
--- a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum
+++ b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum
@@ -1 +1 @@
-5d7a14c0f87bf6bf73471689f10964f3
\ No newline at end of file
+866fd8429aa1147a1a2de901cf2713b1
\ No newline at end of file
diff --git a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png
index e05f65f..137578a 100644
Binary files a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png and b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png differ
diff --git a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum
index 127727c..aa86db8 100644
--- a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum
+++ b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum
@@ -1 +1 @@
-385120b220874b27c01178693b3de163
\ No newline at end of file
+961b13541f3270374f5024a7f548e323
\ No newline at end of file
diff --git a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png
index f40af8f..5e430bf 100644
Binary files a/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png and b/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png differ
diff --git a/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt b/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt
index 606b8ab..e993281 100644
--- a/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt
+++ b/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt
@@ -5,7 +5,7 @@ Tests dynamic updates of the 'x' attribute of the SVGCursorElement object
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS cursorElement.getAttribute('x') is "500"
+PASS cursorElement.getAttribute('x') is "100"
PASS cursorElement.getAttribute('x') is "0"
PASS successfullyParsed is true
diff --git a/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt b/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt
index 59c610c..ef5dfaa 100644
--- a/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt
+++ b/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt
@@ -5,7 +5,7 @@ Tests dynamic updates of the 'y' attribute of the SVGCursorElement object
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS cursorElement.getAttribute('y') is "500"
+PASS cursorElement.getAttribute('y') is "100"
PASS cursorElement.getAttribute('y') is "0"
PASS successfullyParsed is true
diff --git a/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt b/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt
index d81c4a9..8917de1 100644
--- a/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt
+++ b/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt
@@ -5,7 +5,7 @@ Tests dynamic updates of the 'x' property of the SVGCursorElement object
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS cursorElement.x.baseVal.value is 500
+PASS cursorElement.x.baseVal.value is 100
PASS cursorElement.x.baseVal.value is 0
PASS successfullyParsed is true
diff --git a/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt b/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt
index 0914973..544171d 100644
--- a/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt
+++ b/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt
@@ -5,7 +5,7 @@ Tests dynamic updates of the 'y' property of the SVGCursorElement object
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS cursorElement.y.baseVal.value is 500
+PASS cursorElement.y.baseVal.value is 100
PASS cursorElement.y.baseVal.value is 0
PASS successfullyParsed is true
diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js
index a330552..a78828c 100644
--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js
+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js
@@ -1,13 +1,13 @@
// [Name] SVGCursorElement-dom-x-attr.js
-// [Expected rendering result] verify manually that the cursor is visible when hovering the rect - and a series of PASS messages
+// [Expected rendering result] cursor image should hang from the upper-left corner of the cursor after clicking - and a series of PASS mesasges
description("Tests dynamic updates of the 'x' attribute of the SVGCursorElement object")
createSVGTestCase();
var cursorElement = createSVGElement("cursor");
cursorElement.setAttribute("id", "cursor");
-cursorElement.setAttribute("x", "500");
-cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/magnify.png");
+cursorElement.setAttribute("x", "100");
+cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/sphere.png");
rootSVGElement.appendChild(cursorElement);
var rectElement = createSVGElement("rect");
@@ -17,7 +17,7 @@ rectElement.setAttribute("height", "200");
rectElement.setAttribute("fill", "green");
rootSVGElement.appendChild(rectElement);
-shouldBeEqualToString("cursorElement.getAttribute('x')", "500");
+shouldBeEqualToString("cursorElement.getAttribute('x')", "100");
function executeTest() {
cursorElement.setAttribute("x", "0");
diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js
index 781b1ec..78e293d 100644
--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js
+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js
@@ -1,13 +1,13 @@
// [Name] SVGCursorElement-dom-y-attr.js
-// [Expected rendering result] verify manually that the cursor is visible when hovering the rect - and a series of PASS messages
+// [Expected rendering result] cursor image should hang from the upper-left corner of the cursor after clicking - and a series of PASS mesasges
description("Tests dynamic updates of the 'y' attribute of the SVGCursorElement object")
createSVGTestCase();
var cursorElement = createSVGElement("cursor");
cursorElement.setAttribute("id", "cursor");
-cursorElement.setAttribute("y", "500");
-cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/magnify.png");
+cursorElement.setAttribute("y", "100");
+cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/sphere.png");
rootSVGElement.appendChild(cursorElement);
var rectElement = createSVGElement("rect");
@@ -17,7 +17,7 @@ rectElement.setAttribute("height", "200");
rectElement.setAttribute("fill", "green");
rootSVGElement.appendChild(rectElement);
-shouldBeEqualToString("cursorElement.getAttribute('y')", "500");
+shouldBeEqualToString("cursorElement.getAttribute('y')", "100");
function executeTest() {
cursorElement.setAttribute("y", "0");
diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js
index d4e6e1f..e119de9 100644
--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js
+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js
@@ -1,13 +1,13 @@
// [Name] SVGCursorElement-svgdom-x-prop.js
-// [Expected rendering result] verify manually that the cursor is visible when hovering the rect - and a series of PASS messages
+// [Expected rendering result] cursor image should hang from the upper-left corner of the cursor after clicking - and a series of PASS mesasges
description("Tests dynamic updates of the 'x' property of the SVGCursorElement object")
createSVGTestCase();
var cursorElement = createSVGElement("cursor");
cursorElement.setAttribute("id", "cursor");
-cursorElement.setAttribute("x", "500");
-cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/magnify.png");
+cursorElement.setAttribute("x", "100");
+cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/sphere.png");
rootSVGElement.appendChild(cursorElement);
var rectElement = createSVGElement("rect");
@@ -17,7 +17,7 @@ rectElement.setAttribute("height", "200");
rectElement.setAttribute("fill", "green");
rootSVGElement.appendChild(rectElement);
-shouldBe("cursorElement.x.baseVal.value", "500");
+shouldBe("cursorElement.x.baseVal.value", "100");
function executeTest() {
cursorElement.x.baseVal.value = 0;
diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js
index 4aace90..d0b9e9f 100644
--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js
+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js
@@ -1,13 +1,13 @@
-// [Name] SVGCursorElement-sgdom-y-prop.js
-// [Expected rendering result] verify manually that the cursor is visible when hovering the rect - and a series of PASS messages
+// [Name] SVGCursorElement-svgdom-y-prop.js
+// [Expected rendering result] cursor image should hang from the upper-left corner of the cursor after clicking - and a series of PASS mesasges
description("Tests dynamic updates of the 'y' property of the SVGCursorElement object")
createSVGTestCase();
var cursorElement = createSVGElement("cursor");
cursorElement.setAttribute("id", "cursor");
-cursorElement.setAttribute("y", "500");
-cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/magnify.png");
+cursorElement.setAttribute("y", "100");
+cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/sphere.png");
rootSVGElement.appendChild(cursorElement);
var rectElement = createSVGElement("rect");
@@ -17,7 +17,7 @@ rectElement.setAttribute("height", "200");
rectElement.setAttribute("fill", "green");
rootSVGElement.appendChild(rectElement);
-shouldBe("cursorElement.y.baseVal.value", "500");
+shouldBe("cursorElement.y.baseVal.value", "100");
function executeTest() {
cursorElement.y.baseVal.value = 0;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list